René's URL Explorer Experiment


Title: stream: fix pipeToSync byte accounting by trivikr · Pull Request #63564 · nodejs/node · GitHub

Open Graph Title: stream: fix pipeToSync byte accounting by trivikr · Pull Request #63564 · nodejs/node

X Title: stream: fix pipeToSync byte accounting by trivikr · Pull Request #63564 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #63562 pipeToSync() ignored explicit false returns from writeSync() and writevSync(), so it could report bytes for chunks that were not accepted by the writer. This updates pipeToSync() to s...

X Description: Fixes: #63562 pipeToSync() ignored explicit false returns from writeSync() and writevSync(), so it could report bytes for chunks that were not accepted by the writer. This updates pipeToSync() to s...

Opengraph URL: https://github.com/nodejs/node/pull/63564

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d845e26b-0571-aa06-4119-c20023b4dc8e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E80:1956FA:35C4F4:4BD9A0:6A4CA11F
html-safe-nonce60bddf3044f2b9dc05bd71fe70a16982ab74d1edbe9ba92feebd4637d3db3b2d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTgwOjE5NTZGQTozNUM0RjQ6NEJEOUEwOjZBNENBMTFGIiwidmlzaXRvcl9pZCI6Ijc3MjY2MjkzOTU0NDAxMTU5OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac117ac03e33ca5c27572b46d19dee35de4fb9838afdf9e93ad877eea42dc42156
hovercard-subject-tagpull_request:3743206028
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63564/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/62c7273da8f66ac456616b192ab99e9ae0e6841bfc294d286d5635e630d43edc/nodejs/node/pull/63564
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/62c7273da8f66ac456616b192ab99e9ae0e6841bfc294d286d5635e630d43edc/nodejs/node/pull/63564
og:image:altFixes: #63562 pipeToSync() ignored explicit false returns from writeSync() and writevSync(), so it could report bytes for chunks that were not accepted by the writer. This updates pipeToSync() to s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseae90d426644ca15e89bacceb72e51f4e9dbf85f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63564#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63564
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63564
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63564
Reloadhttps://github.com/nodejs/node/pull/63564
Reloadhttps://github.com/nodejs/node/pull/63564
Please reload this pagehttps://github.com/nodejs/node/pull/63564
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63564
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-pipetosync-writesync-backpressurehttps://github.com/trivikr/node/tree/stream-iter-pipetosync-writesync-backpressure
Conversationhttps://github.com/nodejs/node/pull/63564
Commits1 (1)https://github.com/nodejs/node/pull/63564/commits
Checkshttps://github.com/nodejs/node/pull/63564/checks
Files changedhttps://github.com/nodejs/node/pull/63564/files
stream: fix pipeToSync byte accountinghttps://github.com/nodejs/node/pull/63564#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-pipetosync-writesync-backpressurehttps://github.com/trivikr/node/tree/stream-iter-pipetosync-writesync-backpressure
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 25, 2026https://github.com/nodejs/node/pull/63564#issue-4518378614
#63562https://github.com/nodejs/node/issues/63562
Please reload this pagehttps://github.com/nodejs/node/pull/63564
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 25, 2026https://github.com/nodejs/node/pull/63564#issuecomment-4535818080
Please reload this pagehttps://github.com/nodejs/node/pull/63564
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
May 25, 2026https://github.com/nodejs/node/pull/63564#event-25933961869
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/0b933ffacf87b9fe2eb86f53a6351049a3d6937c..8b50431309ebebe3804c66ccfbd7525d4c1281af
0b933ffhttps://github.com/nodejs/node/commit/0b933ffacf87b9fe2eb86f53a6351049a3d6937c
8b50431https://github.com/nodejs/node/commit/8b50431309ebebe3804c66ccfbd7525d4c1281af
Compare https://github.com/nodejs/node/compare/0b933ffacf87b9fe2eb86f53a6351049a3d6937c..8b50431309ebebe3804c66ccfbd7525d4c1281af
May 25, 2026 16:54https://github.com/nodejs/node/pull/63564#event-25934069735
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 25, 2026https://github.com/nodejs/node/pull/63564#event-25934079812
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 25, 2026https://github.com/nodejs/node/pull/63564#issuecomment-4536426242
Please reload this pagehttps://github.com/nodejs/node/pull/63564
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63564?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
49dcaa0https://app.codecov.io/gh/nodejs/node/commit/49dcaa09db860a8c76704cf8597be8f97cdcd9cf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
8b50431https://app.codecov.io/gh/nodejs/node/commit/8b50431309ebebe3804c66ccfbd7525d4c1281af?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63564?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/pull.jshttps://app.codecov.io/gh/nodejs/node/pull/63564?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fpull.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9wdWxsLmpz
3 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63564?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63564?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/pull.jshttps://app.codecov.io/gh/nodejs/node/pull/63564?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fpull.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9wdWxsLmpz
43 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63564/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63564
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 25, 2026 23:01https://github.com/nodejs/node/pull/63564#event-25942443130
https://github.com/trivikr
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63564
https://github.com/trivikr
trivikrhttps://github.com/trivikr
June 8, 2026 01:49https://github.com/nodejs/node/pull/63564#event-26450600076
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/8b50431309ebebe3804c66ccfbd7525d4c1281af..7daf002daf78514371e9b168a1ab0adf8980e76e
8b50431https://github.com/nodejs/node/commit/8b50431309ebebe3804c66ccfbd7525d4c1281af
7daf002https://github.com/nodejs/node/commit/7daf002daf78514371e9b168a1ab0adf8980e76e
Compare https://github.com/nodejs/node/compare/8b50431309ebebe3804c66ccfbd7525d4c1281af..7daf002daf78514371e9b168a1ab0adf8980e76e
June 8, 2026 01:49https://github.com/nodejs/node/pull/63564#event-26450608665
https://github.com/trivikr
stream: fix pipeToSync byte accountinghttps://github.com/nodejs/node/pull/63564/commits/70cf4f83693ecf10672a0398a1210a84e8f0c8c9
70cf4f8https://github.com/nodejs/node/pull/63564/commits/70cf4f83693ecf10672a0398a1210a84e8f0c8c9
nodejs#63562https://github.com/nodejs/node/issues/63562
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/7daf002daf78514371e9b168a1ab0adf8980e76e..70cf4f83693ecf10672a0398a1210a84e8f0c8c9
7daf002https://github.com/nodejs/node/commit/7daf002daf78514371e9b168a1ab0adf8980e76e
70cf4f8https://github.com/nodejs/node/commit/70cf4f83693ecf10672a0398a1210a84e8f0c8c9
Compare https://github.com/nodejs/node/compare/7daf002daf78514371e9b168a1ab0adf8980e76e..70cf4f83693ecf10672a0398a1210a84e8f0c8c9
June 8, 2026 02:06https://github.com/nodejs/node/pull/63564#event-26450895937
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 8, 2026 https://github.com/nodejs/node/pull/63564#pullrequestreview-4453290343
View reviewed changes https://github.com/nodejs/node/pull/63564/files/70cf4f83693ecf10672a0398a1210a84e8f0c8c9
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/63564#pullrequestreview-4453290343
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/63564
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 8, 2026https://github.com/nodejs/node/pull/63564#event-26491451489
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 8, 2026https://github.com/nodejs/node/pull/63564#event-26492424484
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 8, 2026https://github.com/nodejs/node/pull/63564#event-26492639902
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 8, 2026https://github.com/nodejs/node/pull/63564#issuecomment-4653643964
https://ci.nodejs.org/job/node-test-pull-request/73983/https://ci.nodejs.org/job/node-test-pull-request/73983/
Please reload this pagehttps://github.com/nodejs/node/pull/63564
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 8, 2026https://github.com/nodejs/node/pull/63564#event-26495079455
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 8, 2026https://github.com/nodejs/node/pull/63564#event-26495134460
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
696030dhttps://github.com/nodejs/node/commit/696030d7a1e915dff2b71db2342159e2852f1631
Jun 8, 2026https://github.com/nodejs/node/pull/63564#event-26495194325
Please reload this pagehttps://github.com/nodejs/node/pull/63564
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 8, 2026https://github.com/nodejs/node/pull/63564#issuecomment-4654205455
696030dhttps://github.com/nodejs/node/commit/696030d7a1e915dff2b71db2342159e2852f1631
Please reload this pagehttps://github.com/nodejs/node/pull/63564
https://github.com/trivikr
trivikrhttps://github.com/trivikr
June 8, 2026 22:52https://github.com/nodejs/node/pull/63564#event-26495375239
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jun 9, 2026 https://github.com/nodejs/node/pull/63564#ref-pullrequest-4564668564
stream: refine stream/iter backpressure and error handling #63697 https://github.com/nodejs/node/pull/63697
aduh95https://github.com/aduh95
Jun 18, 2026 https://github.com/nodejs/node/pull/63564#ref-commit-792c410
https://github.com/trivikr
https://github.com/aduh95
stream: fix pipeToSync byte accountinghttps://github.com/nodejs/node/commit/792c4106310d040e5d70b821c7052d5fe0fe2e53
792c410https://github.com/nodejs/node/commit/792c4106310d040e5d70b821c7052d5fe0fe2e53
#63562https://github.com/nodejs/node/issues/63562
#63564https://github.com/nodejs/node/pull/63564
#63562https://github.com/nodejs/node/issues/63562
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 22, 2026 https://github.com/nodejs/node/pull/63564#ref-pullrequest-4714405542
2026-06-23, Version 26.4.0 (Current) #64058 https://github.com/nodejs/node/pull/64058
luanmunizhttps://github.com/luanmuniz
Jun 25, 2026 https://github.com/nodejs/node/pull/63564#ref-commit-466db66
https://github.com/trivikr
https://github.com/luanmuniz
stream: fix pipeToSync byte accountinghttps://github.com/luanmuniz/node/commit/466db66896af96f95e068ac5e481348d89796c00
466db66https://github.com/luanmuniz/node/commit/466db66896af96f95e068ac5e481348d89796c00
nodejs#63562https://github.com/nodejs/node/issues/63562
nodejs#63564https://github.com/nodejs/node/pull/63564
nodejs#63562https://github.com/nodejs/node/issues/63562
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63564
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/63564/files/70cf4f83693ecf10672a0398a1210a84e8f0c8c9
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: pipeToSync() ignores writeSync() backpressure and overcounts bytes https://github.com/nodejs/node/issues/63562
Please reload this pagehttps://github.com/nodejs/node/pull/63564
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.