René's URL Explorer Experiment


Title: stream: reject pending reads on iterator throw by trivikr · Pull Request #63555 · nodejs/node · GitHub

Open Graph Title: stream: reject pending reads on iterator throw by trivikr · Pull Request #63555 · nodejs/node

X Title: stream: reject pending reads on iterator throw by trivikr · Pull Request #63555 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #63554 Stream.push() readable iterators could leave an already pending next() promise unresolved when iterator.throw() was called. This updates consumer cancellation handling so pending read...

X Description: Fixes: #63554 Stream.push() readable iterators could leave an already pending next() promise unresolved when iterator.throw() was called. This updates consumer cancellation handling so pending read...

Opengraph URL: https://github.com/nodejs/node/pull/63555

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d491ca33-90e2-ea6d-3fb4-d332e8a87dbc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCAA:39CFC7:2459AF9:346DD26:6A4D1764
html-safe-nonce2434cca81e2d4ace0eb4e003346ceb5b787d70c9df31839acc7e87eb2cc2e875
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0FBOjM5Q0ZDNzoyNDU5QUY5OjM0NkREMjY6NkE0RDE3NjQiLCJ2aXNpdG9yX2lkIjoiMTE4MDcxNjA2NTEyMzgwMDkzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9f92c675532ebcf7d46c6db6d41e73de9c6e01ae5ff51d3d51245b9660b6bd53
hovercard-subject-tagpull_request:3740445005
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63555/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/db406520e206b7ac86d882eea8e6af99806e90c8b80a03227329353b86a8b294/nodejs/node/pull/63555
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/db406520e206b7ac86d882eea8e6af99806e90c8b80a03227329353b86a8b294/nodejs/node/pull/63555
og:image:altFixes: #63554 Stream.push() readable iterators could leave an already pending next() promise unresolved when iterator.throw() was called. This updates consumer cancellation handling so pending read...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
Nonebcb4661e6fb4fe8b394c51ea02ccdb2236d40dc59afc75a3bbba50bf6517134c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefb70bd3c4b2bec429781b65419e912c66e2d5581
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63555#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63555
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63555
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63555
Reloadhttps://github.com/nodejs/node/pull/63555
Reloadhttps://github.com/nodejs/node/pull/63555
Please reload this pagehttps://github.com/nodejs/node/pull/63555
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63555
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 958 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-push-throw-pending-nexthttps://github.com/trivikr/node/tree/stream-iter-push-throw-pending-next
Conversationhttps://github.com/nodejs/node/pull/63555
Commits1 (1)https://github.com/nodejs/node/pull/63555/commits
Checkshttps://github.com/nodejs/node/pull/63555/checks
Files changedhttps://github.com/nodejs/node/pull/63555/files
stream: reject pending reads on iterator throwhttps://github.com/nodejs/node/pull/63555#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-push-throw-pending-nexthttps://github.com/trivikr/node/tree/stream-iter-push-throw-pending-next
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 25, 2026https://github.com/nodejs/node/pull/63555#issue-4515128121
#63554https://github.com/nodejs/node/issues/63554
Please reload this pagehttps://github.com/nodejs/node/pull/63555
https://github.com/trivikr
stream: reject pending reads on iterator throwhttps://github.com/nodejs/node/pull/63555/commits/cbf0957ff1207df5f610c3fdd962f159afcba477
cbf0957https://github.com/nodejs/node/pull/63555/commits/cbf0957ff1207df5f610c3fdd962f159afcba477
nodejs#63554https://github.com/nodejs/node/issues/63554
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 25, 2026https://github.com/nodejs/node/pull/63555#issuecomment-4532410968
Please reload this pagehttps://github.com/nodejs/node/pull/63555
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
May 25, 2026https://github.com/nodejs/node/pull/63555#event-25916545776
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 25, 2026https://github.com/nodejs/node/pull/63555#issuecomment-4532929798
Please reload this pagehttps://github.com/nodejs/node/pull/63555
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63555?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
8c495c8https://app.codecov.io/gh/nodejs/node/commit/8c495c80309f58aab5e6d9035a22054a638110e0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
cbf0957https://app.codecov.io/gh/nodejs/node/commit/cbf0957ff1207df5f610c3fdd962f159afcba477?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63555?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/push.jshttps://app.codecov.io/gh/nodejs/node/pull/63555?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fpush.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9wdXNoLmpz
4 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63555?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63555?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/push.jshttps://app.codecov.io/gh/nodejs/node/pull/63555?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fpush.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9wdXNoLmpz
45 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63555/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63555
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 25, 2026 https://github.com/nodejs/node/pull/63555#pullrequestreview-4357035189
View reviewed changes https://github.com/nodejs/node/pull/63555/files/cbf0957ff1207df5f610c3fdd962f159afcba477
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 25, 2026https://github.com/nodejs/node/pull/63555#event-25930191331
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 25, 2026https://github.com/nodejs/node/pull/63555#event-25930442475
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63555
https://github.com/aduh95
aduh95https://github.com/aduh95
May 26, 2026 https://github.com/nodejs/node/pull/63555#pullrequestreview-4368056501
View reviewed changes https://github.com/nodejs/node/pull/63555/files/cbf0957ff1207df5f610c3fdd962f159afcba477
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 26, 2026https://github.com/nodejs/node/pull/63555#issuecomment-4549685308
https://ci.nodejs.org/job/node-test-pull-request/73767/https://ci.nodejs.org/job/node-test-pull-request/73767/
Please reload this pagehttps://github.com/nodejs/node/pull/63555
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 27, 2026https://github.com/nodejs/node/pull/63555#event-25993390101
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 27, 2026https://github.com/nodejs/node/pull/63555#event-26004965712
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
7dbded2https://github.com/nodejs/node/commit/7dbded23af87b93ab21b2c126a8bddf276bb2b0b
May 27, 2026https://github.com/nodejs/node/pull/63555#event-26004970329
Please reload this pagehttps://github.com/nodejs/node/pull/63555
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 27, 2026https://github.com/nodejs/node/pull/63555#issuecomment-4552716079
7dbded2https://github.com/nodejs/node/commit/7dbded23af87b93ab21b2c126a8bddf276bb2b0b
Please reload this pagehttps://github.com/nodejs/node/pull/63555
https://github.com/aduh95
aduh95https://github.com/aduh95
May 27, 2026 https://github.com/nodejs/node/pull/63555#ref-pullrequest-4531387635
stream: fix lint error #63598 https://github.com/nodejs/node/pull/63598
aduh95https://github.com/aduh95
May 27, 2026 https://github.com/nodejs/node/pull/63555#ref-commit-1608d90
https://github.com/trivikr
https://github.com/aduh95
stream: reject pending reads on iterator throwhttps://github.com/nodejs/node/commit/1608d905a782e5b2ddea73f4ba3e07450b4b562d
1608d90https://github.com/nodejs/node/commit/1608d905a782e5b2ddea73f4ba3e07450b4b562d
#63554https://github.com/nodejs/node/issues/63554
#63555https://github.com/nodejs/node/pull/63555
#63554https://github.com/nodejs/node/issues/63554
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/MattiasBuelens
May 27, 2026 https://github.com/nodejs/node/pull/63555#pullrequestreview-4371912228
View reviewed changes https://github.com/nodejs/node/pull/63555/files/cbf0957ff1207df5f610c3fdd962f159afcba477
test/parallel/test-stream-iter-push-writer.jshttps://github.com/nodejs/node/pull/63555/files/cbf0957ff1207df5f610c3fdd962f159afcba477#diff-dbf58f410d7fddd13b8b4164a080a791be5e32096b71f6a707ff1937042ff3c5
Please reload this pagehttps://github.com/nodejs/node/pull/63555
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 27, 2026 17:21https://github.com/nodejs/node/pull/63555#event-26026485097
stream/iter: pending next() hangs after iterator return() #63519 https://github.com/nodejs/node/issues/63519
stream: settle pending stream iter reads on return #63521 https://github.com/nodejs/node/pull/63521
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 30, 2026 https://github.com/nodejs/node/pull/63555#ref-pullrequest-4555076114
2026-06-01, Version 26.3.0 (Current) #63664 https://github.com/nodejs/node/pull/63664
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63555
https://github.com/MattiasBuelens
MattiasBuelens https://github.com/MattiasBuelens
https://github.com/nodejs/node/pull/63555/files/cbf0957ff1207df5f610c3fdd962f159afcba477
https://github.com/jakecastelli
jakecastelli https://github.com/jakecastelli
https://github.com/nodejs/node/pull/63555/files/cbf0957ff1207df5f610c3fdd962f159afcba477
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/63555/files/cbf0957ff1207df5f610c3fdd962f159afcba477
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/63555/files/cbf0957ff1207df5f610c3fdd962f159afcba477
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: push() iterator throw() leaves pending next() unresolved https://github.com/nodejs/node/issues/63554
Please reload this pagehttps://github.com/nodejs/node/pull/63555
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/MattiasBuelens
https://github.com/aduh95
https://github.com/jakecastelli
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.