René's URL Explorer Experiment


Title: src: fix crash when reading length on Storage.prototype by 3zrv · Pull Request #63529 · nodejs/node · GitHub

Open Graph Title: src: fix crash when reading length on Storage.prototype by 3zrv · Pull Request #63529 · nodejs/node

X Title: src: fix crash when reading length on Storage.prototype by 3zrv · Pull Request #63529 · nodejs/node

Description: Fixes: #63514 The following one-liner reliably segfaults: $ node -e 'globalThis.sessionStorage.setItem.length;globalThis.Storage.prototype.length' [1] 42883 segmentation fault (core dumped) Stack trace: #0 sqlite3LockAndPrepare () #1 sqlite3_prepare_v2 () #2 node::webstorage::Storage::Length () #3 node::webstorage::StorageLengthGetter () Root cause Storage's length accessor is defined on the prototype template: Local length_getter = FunctionTemplate::New(isolate, StorageLengthGetter); // no signature ctor_tmpl->PrototypeTemplate()->SetAccessorProperty(env->length_string(), ...); Fix Create the getter's FunctionTemplate with a v8::Signature bound to the Storage constructor template, exactly as the methods do. V8 now rejects an incompatible receiver with a TypeError: Illegal invocation before the C++ callback runs matching browser behavior instead of crashing. Real localStorage/sessionStorage instances are unaffected.

Open Graph Description: Fixes: #63514 The following one-liner reliably segfaults: $ node -e 'globalThis.sessionStorage.setItem.length;globalThis.Storage.prototype.length' [1] 42883 segmentation fault (core dump...

X Description: Fixes: #63514 The following one-liner reliably segfaults: $ node -e 'globalThis.sessionStorage.setItem.length;globalThis.Storage.prototype.length' [1] 42883 segmentation fault (c...

Opengraph URL: https://github.com/nodejs/node/pull/63529

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a956aa7d-cb20-ca84-d20c-b7151043cd2b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8196:17F796:29289EE:3A31F85:6A4CEFA1
html-safe-nonce3e9b18dd9270daf89a265e72715d20ca903f67b3092ba055f97cfbe71e1393c6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTk2OjE3Rjc5NjoyOTI4OUVFOjNBMzFGODU6NkE0Q0VGQTEiLCJ2aXNpdG9yX2lkIjoiMzkyMTg2MTQ4NjE5NjEyMDY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0f23a78b015cbaa6a5d8f212e7959a151618e99068045d353df0ec20aeba9185
hovercard-subject-tagpull_request:3736912294
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/63529/files
twitter:imagehttps://avatars.githubusercontent.com/u/73386311?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/73386311?s=400&v=4
og:image:altFixes: #63514 The following one-liner reliably segfaults: $ node -e 'globalThis.sessionStorage.setItem.length;globalThis.Storage.prototype.length' [1] 42883 segmentation fault (core dump...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None299b43bca6e02ad35197ffeba30d2466846d5fb02ab96fbced5b5e6cec589fb8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseefec6750a5afcaeaf5dfcf629f404cf98c8371e3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63529/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63529%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63529%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63529/files
Reloadhttps://github.com/nodejs/node/pull/63529/files
Reloadhttps://github.com/nodejs/node/pull/63529/files
Please reload this pagehttps://github.com/nodejs/node/pull/63529/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63529/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 959 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
3zrv:fix-webstorage-lengthhttps://github.com/3zrv/node/tree/fix-webstorage-length
Conversation 8 https://github.com/nodejs/node/pull/63529
Commits 1 https://github.com/nodejs/node/pull/63529/commits
Checks 44 https://github.com/nodejs/node/pull/63529/checks
Files changed 2 https://github.com/nodejs/node/pull/63529/files
src: fix crash when reading length on Storage.prototype https://github.com/nodejs/node/pull/63529/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/63529/files
a3b7b08 src: fix crash when reading length on Storage.prototype May 26, 2026 https://github.com/nodejs/node/pull/63529/commits/a3b7b089f1fdc691be0d29c929018c233b446b9a
Clear filters https://github.com/nodejs/node/pull/63529/files
Please reload this pagehttps://github.com/nodejs/node/pull/63529/files
Please reload this pagehttps://github.com/nodejs/node/pull/63529/files
node_webstorage.cc https://github.com/nodejs/node/pull/63529/files#diff-9db77e69b882a1a27952f7c02939474c044ba385d9de529087e93bb5e6b32ff1
test-webstorage.js https://github.com/nodejs/node/pull/63529/files#diff-e751717181263fc6bdb98902fa288995974ee1947cf47fc8651281dcb40bac47
src/node_webstorage.cchttps://github.com/nodejs/node/pull/63529/files#diff-9db77e69b882a1a27952f7c02939474c044ba385d9de529087e93bb5e6b32ff1
View file https://github.com/3zrv/node/blob/a3b7b089f1fdc691be0d29c929018c233b446b9a/src/node_webstorage.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/63529/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/63529/files#diff-9db77e69b882a1a27952f7c02939474c044ba385d9de529087e93bb5e6b32ff1
https://github.com/nodejs/node/pull/63529/files#diff-9db77e69b882a1a27952f7c02939474c044ba385d9de529087e93bb5e6b32ff1
https://github.com/nodejs/node/pull/63529/files#diff-9db77e69b882a1a27952f7c02939474c044ba385d9de529087e93bb5e6b32ff1
https://github.com/nodejs/node/pull/63529/files#diff-9db77e69b882a1a27952f7c02939474c044ba385d9de529087e93bb5e6b32ff1
test/parallel/test-webstorage.jshttps://github.com/nodejs/node/pull/63529/files#diff-e751717181263fc6bdb98902fa288995974ee1947cf47fc8651281dcb40bac47
View file https://github.com/3zrv/node/blob/a3b7b089f1fdc691be0d29c929018c233b446b9a/test/parallel/test-webstorage.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/63529/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/63529/files#diff-e751717181263fc6bdb98902fa288995974ee1947cf47fc8651281dcb40bac47
https://github.com/nodejs/node/pull/63529/files#diff-e751717181263fc6bdb98902fa288995974ee1947cf47fc8651281dcb40bac47
Please reload this pagehttps://github.com/nodejs/node/pull/63529/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.