René's URL Explorer Experiment


Title: tools: enforce iterator result property order by trivikr · Pull Request #63526 · nodejs/node · GitHub

Open Graph Title: tools: enforce iterator result property order by trivikr · Pull Request #63526 · nodejs/node

X Title: tools: enforce iterator result property order by trivikr · Pull Request #63526 · nodejs/node

Description: Adds a custom ESLint rule to enforce done before value in iterator result objects. This keeps iterator result object literals consistent across lib/, and includes a fixer that swaps the properties when they are in the wrong order. The existing iterator result object literals in lib/ have been updated to match the new rule. Refs: #63521 (comment) Assisted-by: openai:gpt-5.5

Open Graph Description: Adds a custom ESLint rule to enforce done before value in iterator result objects. This keeps iterator result object literals consistent across lib/, and includes a fixer that swaps the properties ...

X Description: Adds a custom ESLint rule to enforce done before value in iterator result objects. This keeps iterator result object literals consistent across lib/, and includes a fixer that swaps the properties ...

Opengraph URL: https://github.com/nodejs/node/pull/63526

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8a01faf5-7944-f917-a7cd-1e1ee38bcc40
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC30:3452D4:83121E:B6B664:6A4C9382
html-safe-nonce414c9fd2d09789d6483ccb4e5544941359d4c40bf99eeea9b111f7376363587a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzMwOjM0NTJENDo4MzEyMUU6QjZCNjY0OjZBNEM5MzgyIiwidmlzaXRvcl9pZCI6IjYyODcyNTI4ODY2NTc5OTU2NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf857adf856a40f06f5359c5c55c4a2b7258a5413996e9c860209b4be3b08dc53
hovercard-subject-tagpull_request:3736410803
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/63526/files
twitter:imagehttps://avatars.githubusercontent.com/u/16024985?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/16024985?s=400&v=4
og:image:altAdds a custom ESLint rule to enforce done before value in iterator result objects. This keeps iterator result object literals consistent across lib/, and includes a fixer that swaps the properties ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a2dede45637df6b92ddcfe2a557e67d4b5854ae
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63526/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63526%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63526%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63526/files
Reloadhttps://github.com/nodejs/node/pull/63526/files
Reloadhttps://github.com/nodejs/node/pull/63526/files
Please reload this pagehttps://github.com/nodejs/node/pull/63526/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63526/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:eslint-iterator-result-object-done-valuehttps://github.com/trivikr/node/tree/eslint-iterator-result-object-done-value
Conversation 9 https://github.com/nodejs/node/pull/63526
Commits 1 https://github.com/nodejs/node/pull/63526/commits
Checks 53 https://github.com/nodejs/node/pull/63526/checks
Files changed https://github.com/nodejs/node/pull/63526/files
Please reload this pagehttps://github.com/nodejs/node/pull/63526/files
tools: enforce iterator result property order https://github.com/nodejs/node/pull/63526/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/63526/files
d25477b tools: enforce iterator result property order trivikr May 24, 2026 https://github.com/nodejs/node/pull/63526/commits/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171
Clear filters https://github.com/nodejs/node/pull/63526/files
Please reload this pagehttps://github.com/nodejs/node/pull/63526/files
Please reload this pagehttps://github.com/nodejs/node/pull/63526/files
eslint.config_partial.mjs https://github.com/nodejs/node/pull/63526/files#diff-89eb5442de2dcd59f1f3932873799b3f49d48e4ce12e7c003bfa9d5bd45a03a5
events.js https://github.com/nodejs/node/pull/63526/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9
promises.js https://github.com/nodejs/node/pull/63526/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
push.js https://github.com/nodejs/node/pull/63526/files#diff-df19d90f1ff5d68c5be20e0510aa6322f174a51bececf2d0c57c12cf59e10cb4
url.js https://github.com/nodejs/node/pull/63526/files#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e
watcher.js https://github.com/nodejs/node/pull/63526/files#diff-9358f0b3cfe79dc95fce554f19b8b2840a0c278c277644cec4f0c1d0930b5b95
readablestream.js https://github.com/nodejs/node/pull/63526/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47
test-eslint-iterator-result-done-first.js https://github.com/nodejs/node/pull/63526/files#diff-ae8f771f699712b0b8c3cf8fb46c630182c451611485aabb823953fad7c50fb7
iterator-result-done-first.js https://github.com/nodejs/node/pull/63526/files#diff-c6fbda750c1e3dd9069513d7cb2dac9bac7d05b04a071cde3d3e90b73a7f9fab
lib/eslint.config_partial.mjshttps://github.com/nodejs/node/pull/63526/files#diff-89eb5442de2dcd59f1f3932873799b3f49d48e4ce12e7c003bfa9d5bd45a03a5
View file https://github.com/trivikr/node/blob/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171/lib/eslint.config_partial.mjs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/63526/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/63526/files#diff-89eb5442de2dcd59f1f3932873799b3f49d48e4ce12e7c003bfa9d5bd45a03a5
https://github.com/nodejs/node/pull/63526/files#diff-89eb5442de2dcd59f1f3932873799b3f49d48e4ce12e7c003bfa9d5bd45a03a5
lib/events.jshttps://github.com/nodejs/node/pull/63526/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9
View file https://github.com/trivikr/node/blob/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171/lib/events.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/63526/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/63526/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9
https://github.com/nodejs/node/pull/63526/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9
lib/internal/fs/promises.jshttps://github.com/nodejs/node/pull/63526/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
View file https://github.com/trivikr/node/blob/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171/lib/internal/fs/promises.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/63526/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/63526/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
https://github.com/nodejs/node/pull/63526/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
https://github.com/nodejs/node/pull/63526/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
lib/internal/streams/iter/push.jshttps://github.com/nodejs/node/pull/63526/files#diff-df19d90f1ff5d68c5be20e0510aa6322f174a51bececf2d0c57c12cf59e10cb4
View file https://github.com/trivikr/node/blob/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171/lib/internal/streams/iter/push.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/63526/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/63526/files#diff-df19d90f1ff5d68c5be20e0510aa6322f174a51bececf2d0c57c12cf59e10cb4
https://github.com/nodejs/node/pull/63526/files#diff-df19d90f1ff5d68c5be20e0510aa6322f174a51bececf2d0c57c12cf59e10cb4
https://github.com/nodejs/node/pull/63526/files#diff-df19d90f1ff5d68c5be20e0510aa6322f174a51bececf2d0c57c12cf59e10cb4
https://github.com/nodejs/node/pull/63526/files#diff-df19d90f1ff5d68c5be20e0510aa6322f174a51bececf2d0c57c12cf59e10cb4
https://github.com/nodejs/node/pull/63526/files#diff-df19d90f1ff5d68c5be20e0510aa6322f174a51bececf2d0c57c12cf59e10cb4
https://github.com/nodejs/node/pull/63526/files#diff-df19d90f1ff5d68c5be20e0510aa6322f174a51bececf2d0c57c12cf59e10cb4
lib/internal/url.jshttps://github.com/nodejs/node/pull/63526/files#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e
View file https://github.com/trivikr/node/blob/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171/lib/internal/url.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/63526/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/63526/files#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e
https://github.com/nodejs/node/pull/63526/files#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e
https://github.com/nodejs/node/pull/63526/files#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e
lib/internal/vfs/watcher.jshttps://github.com/nodejs/node/pull/63526/files#diff-9358f0b3cfe79dc95fce554f19b8b2840a0c278c277644cec4f0c1d0930b5b95
View file https://github.com/trivikr/node/blob/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171/lib/internal/vfs/watcher.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/63526/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/63526/files#diff-9358f0b3cfe79dc95fce554f19b8b2840a0c278c277644cec4f0c1d0930b5b95
https://github.com/nodejs/node/pull/63526/files#diff-9358f0b3cfe79dc95fce554f19b8b2840a0c278c277644cec4f0c1d0930b5b95
https://github.com/nodejs/node/pull/63526/files#diff-9358f0b3cfe79dc95fce554f19b8b2840a0c278c277644cec4f0c1d0930b5b95
https://github.com/nodejs/node/pull/63526/files#diff-9358f0b3cfe79dc95fce554f19b8b2840a0c278c277644cec4f0c1d0930b5b95
https://github.com/nodejs/node/pull/63526/files#diff-9358f0b3cfe79dc95fce554f19b8b2840a0c278c277644cec4f0c1d0930b5b95
https://github.com/nodejs/node/pull/63526/files#diff-9358f0b3cfe79dc95fce554f19b8b2840a0c278c277644cec4f0c1d0930b5b95
https://github.com/nodejs/node/pull/63526/files#diff-9358f0b3cfe79dc95fce554f19b8b2840a0c278c277644cec4f0c1d0930b5b95
lib/internal/webstreams/readablestream.jshttps://github.com/nodejs/node/pull/63526/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47
View file https://github.com/trivikr/node/blob/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171/lib/internal/webstreams/readablestream.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/63526/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/63526/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47
https://github.com/nodejs/node/pull/63526/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47
https://github.com/nodejs/node/pull/63526/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47
https://github.com/nodejs/node/pull/63526/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47
https://github.com/nodejs/node/pull/63526/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47
https://github.com/nodejs/node/pull/63526/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47
test/parallel/test-eslint-iterator-result-done-first.jshttps://github.com/nodejs/node/pull/63526/files#diff-ae8f771f699712b0b8c3cf8fb46c630182c451611485aabb823953fad7c50fb7
View file https://github.com/trivikr/node/blob/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171/test/parallel/test-eslint-iterator-result-done-first.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/63526/{{ revealButtonHref }}
tools/eslint-rules/iterator-result-done-first.jshttps://github.com/nodejs/node/pull/63526/files#diff-c6fbda750c1e3dd9069513d7cb2dac9bac7d05b04a071cde3d3e90b73a7f9fab
View file https://github.com/trivikr/node/blob/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171/tools/eslint-rules/iterator-result-done-first.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/63526/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodejs/node/pull/63526/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.