René's URL Explorer Experiment


Title: tools: enforce iterator result property order by trivikr · Pull Request #63526 · nodejs/node · GitHub

Open Graph Title: tools: enforce iterator result property order by trivikr · Pull Request #63526 · nodejs/node

X Title: tools: enforce iterator result property order by trivikr · Pull Request #63526 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Adds a custom ESLint rule to enforce done before value in iterator result objects. This keeps iterator result object literals consistent across lib/, and includes a fixer that swaps the properties ...

X Description: Adds a custom ESLint rule to enforce done before value in iterator result objects. This keeps iterator result object literals consistent across lib/, and includes a fixer that swaps the properties ...

Opengraph URL: https://github.com/nodejs/node/pull/63526

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7e8769d1-3ed2-c822-d8f5-6438ef256b6b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1A6:29BB0:36A538:4B86DE:6A4C7D29
html-safe-nonce07a860e2da5a439353fb3a494fc3885d9c545cc27bc03f87dc70a9f3256849fd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUE2OjI5QkIwOjM2QTUzODo0Qjg2REU6NkE0QzdEMjkiLCJ2aXNpdG9yX2lkIjoiODcwNzQwNTAyMDIzMDYxNDMxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac80ddd787aa01a406813797fd60042213cdfb932fe19057bec7c0e1f4ce94b17e
hovercard-subject-tagpull_request:3736410803
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63526/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5e96b6dd3c897d34836e9b8a4877f35fa23de477be8cc266bb7149578887e62f/nodejs/node/pull/63526
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5e96b6dd3c897d34836e9b8a4877f35fa23de477be8cc266bb7149578887e62f/nodejs/node/pull/63526
og:image:altAdds a custom ESLint rule to enforce done before value in iterator result objects. This keeps iterator result object literals consistent across lib/, and includes a fixer that swaps the properties ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecd470457e909b9d062f8002cf438ba870e6acff6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63526#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63526
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63526
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63526
Reloadhttps://github.com/nodejs/node/pull/63526
Reloadhttps://github.com/nodejs/node/pull/63526
Please reload this pagehttps://github.com/nodejs/node/pull/63526
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63526
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:eslint-iterator-result-object-done-valuehttps://github.com/trivikr/node/tree/eslint-iterator-result-object-done-value
Conversationhttps://github.com/nodejs/node/pull/63526
Commits1 (1)https://github.com/nodejs/node/pull/63526/commits
Checkshttps://github.com/nodejs/node/pull/63526/checks
Files changedhttps://github.com/nodejs/node/pull/63526/files
tools: enforce iterator result property orderhttps://github.com/nodejs/node/pull/63526#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:eslint-iterator-result-object-done-valuehttps://github.com/trivikr/node/tree/eslint-iterator-result-object-done-value
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 24, 2026https://github.com/nodejs/node/pull/63526#issue-4510046264
#63521 (comment)https://github.com/nodejs/node/pull/63521#discussion_r3293510501
Please reload this pagehttps://github.com/nodejs/node/pull/63526
https://github.com/trivikr
tools: enforce iterator result property orderhttps://github.com/nodejs/node/pull/63526/commits/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171
d25477bhttps://github.com/nodejs/node/pull/63526/commits/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 24, 2026https://github.com/nodejs/node/pull/63526#issuecomment-4526948072
Please reload this pagehttps://github.com/nodejs/node/pull/63526
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 24, 2026https://github.com/nodejs/node/pull/63526#event-25891394187
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 24, 2026 https://github.com/nodejs/node/pull/63526#ref-pullrequest-4508897381
stream: settle pending stream iter reads on return #63521 https://github.com/nodejs/node/pull/63521
https://github.com/trivikr
trivikrhttps://github.com/trivikr
jasnellhttps://github.com/jasnell
May 24, 2026 00:42https://github.com/nodejs/node/pull/63526#event-25891408123
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 24, 2026https://github.com/nodejs/node/pull/63526#issuecomment-4527103590
Please reload this pagehttps://github.com/nodejs/node/pull/63526
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63526?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
837910dhttps://app.codecov.io/gh/nodejs/node/commit/837910d298b0e1bd0c93491d51c0022f13e830f1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
d25477bhttps://app.codecov.io/gh/nodejs/node/commit/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63526?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/push.jshttps://app.codecov.io/gh/nodejs/node/pull/63526?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fpush.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9wdXNoLmpz
2 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63526?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/vfs/watcher.jshttps://app.codecov.io/gh/nodejs/node/pull/63526?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Fwatcher.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy93YXRjaGVyLmpz
1 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63526?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63526?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/events.jshttps://app.codecov.io/gh/nodejs/node/pull/63526?src=pr&el=tree&filepath=lib%2Fevents.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2V2ZW50cy5qcw==
lib/internal/fs/promises.jshttps://app.codecov.io/gh/nodejs/node/pull/63526?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fpromises.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL3Byb21pc2VzLmpz
lib/internal/url.jshttps://app.codecov.io/gh/nodejs/node/pull/63526?src=pr&el=tree&filepath=lib%2Finternal%2Furl.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3VybC5qcw==
lib/internal/webstreams/readablestream.jshttps://app.codecov.io/gh/nodejs/node/pull/63526?src=pr&el=tree&filepath=lib%2Finternal%2Fwebstreams%2Freadablestream.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3dlYnN0cmVhbXMvcmVhZGFibGVzdHJlYW0uanM=
lib/internal/vfs/watcher.jshttps://app.codecov.io/gh/nodejs/node/pull/63526?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Fwatcher.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy93YXRjaGVyLmpz
lib/internal/streams/iter/push.jshttps://app.codecov.io/gh/nodejs/node/pull/63526?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fpush.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9wdXNoLmpz
28 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63526/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63526
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 24, 2026https://github.com/nodejs/node/pull/63526#event-25892526069
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/MattiasBuelens
May 24, 2026 https://github.com/nodejs/node/pull/63526#pullrequestreview-4352933715
View reviewed changes https://github.com/nodejs/node/pull/63526/files/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 24, 2026https://github.com/nodejs/node/pull/63526#event-25900044073
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63526
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 24, 2026 https://github.com/nodejs/node/pull/63526#pullrequestreview-4353047878
View reviewed changes https://github.com/nodejs/node/pull/63526/files/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 24, 2026https://github.com/nodejs/node/pull/63526#event-25901280532
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63526
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63526
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63526
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63526
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 26, 2026https://github.com/nodejs/node/pull/63526#issuecomment-4545259645
https://ci.nodejs.org/job/node-test-pull-request/73745/https://ci.nodejs.org/job/node-test-pull-request/73745/
Please reload this pagehttps://github.com/nodejs/node/pull/63526
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 26, 2026https://github.com/nodejs/node/pull/63526#event-25976389102
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 26, 2026https://github.com/nodejs/node/pull/63526#event-25978324216
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
92f48f4https://github.com/nodejs/node/commit/92f48f43fec1c8cf84c1461db9863311ac0660ec
May 26, 2026https://github.com/nodejs/node/pull/63526#event-25978398716
Please reload this pagehttps://github.com/nodejs/node/pull/63526
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 26, 2026https://github.com/nodejs/node/pull/63526#issuecomment-4546792192
92f48f4https://github.com/nodejs/node/commit/92f48f43fec1c8cf84c1461db9863311ac0660ec
Please reload this pagehttps://github.com/nodejs/node/pull/63526
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 27, 2026 07:49https://github.com/nodejs/node/pull/63526#event-26004072006
aduh95https://github.com/aduh95
Jun 20, 2026 https://github.com/nodejs/node/pull/63526#ref-commit-325087b
https://github.com/trivikr
https://github.com/aduh95
tools: enforce iterator result property orderhttps://github.com/nodejs/node/commit/325087be5b4244a8bde42680daad10eb48a76d85
325087bhttps://github.com/nodejs/node/commit/325087be5b4244a8bde42680daad10eb48a76d85
#63526https://github.com/nodejs/node/pull/63526
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 22, 2026 https://github.com/nodejs/node/pull/63526#ref-pullrequest-4714405542
2026-06-23, Version 26.4.0 (Current) #64058 https://github.com/nodejs/node/pull/64058
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63526
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/63526/files/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171
https://github.com/MattiasBuelens
MattiasBuelens https://github.com/MattiasBuelens
https://github.com/nodejs/node/pull/63526/files/d25477b1a26dc9fdc70c68c9656b7ce86bb7e171
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/63526
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/MattiasBuelens
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.