René's URL Explorer Experiment


Title: stream: wait for push writer end fallback to drain by trivikr · Pull Request #63503 · nodejs/node · GitHub

Open Graph Title: stream: wait for push writer end fallback to drain by trivikr · Pull Request #63503 · nodejs/node

X Title: stream: wait for push writer end fallback to drain by trivikr · Pull Request #63503 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes an issue in node:stream/iter where push() writer end() could resolve before buffered data was consumed when called after endSync() returned -1. endSync() already transitions the queue to clos...

X Description: Fixes an issue in node:stream/iter where push() writer end() could resolve before buffered data was consumed when called after endSync() returned -1. endSync() already transitions the queue to clos...

Opengraph URL: https://github.com/nodejs/node/pull/63503

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6b692509-8d05-35b5-e578-00405237a366
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC446:35AEBB:C17454:103A1F5:6A4D48AA
html-safe-nonce3902b41ebf3480a56a2c0909c300bb268dfd511a4446b7c544b19dd2302eabd7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDQ2OjM1QUVCQjpDMTc0NTQ6MTAzQTFGNTo2QTRENDhBQSIsInZpc2l0b3JfaWQiOiI1OTU2NTk1MTU3MTA5MTMxNDM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac292a1a54a3bb2e8c58fb8de7c9b1324adc1cba59204c0956b84352b7b82a68a6
hovercard-subject-tagpull_request:3734046328
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63503/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d01d3ac76e523bd324f3fa1e6d56b0f34a8834cbc1dcdf821d58617f8823b069/nodejs/node/pull/63503
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d01d3ac76e523bd324f3fa1e6d56b0f34a8834cbc1dcdf821d58617f8823b069/nodejs/node/pull/63503
og:image:altFixes an issue in node:stream/iter where push() writer end() could resolve before buffered data was consumed when called after endSync() returned -1. endSync() already transitions the queue to clos...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release56fc8347865a14e2ec811533d68f929cf4e0ec19
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63503#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63503
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63503
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63503
Reloadhttps://github.com/nodejs/node/pull/63503
Reloadhttps://github.com/nodejs/node/pull/63503
Please reload this pagehttps://github.com/nodejs/node/pull/63503
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63503
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 958 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-push-writer-end-resolvehttps://github.com/trivikr/node/tree/stream-iter-push-writer-end-resolve
Conversationhttps://github.com/nodejs/node/pull/63503
Commits1 (1)https://github.com/nodejs/node/pull/63503/commits
Checkshttps://github.com/nodejs/node/pull/63503/checks
Files changedhttps://github.com/nodejs/node/pull/63503/files
stream: wait for push writer end fallback to drainhttps://github.com/nodejs/node/pull/63503#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-push-writer-end-resolvehttps://github.com/trivikr/node/tree/stream-iter-push-writer-end-resolve
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 23, 2026https://github.com/nodejs/node/pull/63503#issue-4507075575
Please reload this pagehttps://github.com/nodejs/node/pull/63503
#63502https://github.com/nodejs/node/issues/63502
Please reload this pagehttps://github.com/nodejs/node/pull/63503
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 23, 2026https://github.com/nodejs/node/pull/63503#issuecomment-4524360466
Please reload this pagehttps://github.com/nodejs/node/pull/63503
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
May 23, 2026https://github.com/nodejs/node/pull/63503#event-25877297176
https://github.com/trivikr
stream: wait for push writer end fallback to drainhttps://github.com/nodejs/node/pull/63503/commits/cee20670d40bdf58475462ec811311d5a89e7aa8
cee2067https://github.com/nodejs/node/pull/63503/commits/cee20670d40bdf58475462ec811311d5a89e7aa8
nodejs#63502https://github.com/nodejs/node/issues/63502
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/7fa1d2605eacaf5298a7c83fee722207a29e6556..cee20670d40bdf58475462ec811311d5a89e7aa8
7fa1d26https://github.com/nodejs/node/commit/7fa1d2605eacaf5298a7c83fee722207a29e6556
cee2067https://github.com/nodejs/node/commit/cee20670d40bdf58475462ec811311d5a89e7aa8
Compare https://github.com/nodejs/node/compare/7fa1d2605eacaf5298a7c83fee722207a29e6556..cee20670d40bdf58475462ec811311d5a89e7aa8
May 23, 2026 06:50https://github.com/nodejs/node/pull/63503#event-25877829751
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 23, 2026https://github.com/nodejs/node/pull/63503#issuecomment-4524792749
Please reload this pagehttps://github.com/nodejs/node/pull/63503
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63503?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
8d3245ehttps://app.codecov.io/gh/nodejs/node/commit/8d3245e551eb98f910119595a7c9103eae7744a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
cee2067https://app.codecov.io/gh/nodejs/node/commit/cee20670d40bdf58475462ec811311d5a89e7aa8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63503?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/push.jshttps://app.codecov.io/gh/nodejs/node/pull/63503?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fpush.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9wdXNoLmpz
3 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63503?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/duplex.jshttps://app.codecov.io/gh/nodejs/node/pull/63503?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fduplex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9kdXBsZXguanM=
lib/internal/streams/iter/push.jshttps://app.codecov.io/gh/nodejs/node/pull/63503?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fpush.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9wdXNoLmpz
28 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63503/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63503
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 23, 2026https://github.com/nodejs/node/pull/63503#event-25881956898
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 23, 2026 https://github.com/nodejs/node/pull/63503#pullrequestreview-4351456123
View reviewed changes https://github.com/nodejs/node/pull/63503/files/cee20670d40bdf58475462ec811311d5a89e7aa8
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 23, 2026https://github.com/nodejs/node/pull/63503#event-25889651759
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 23, 2026https://github.com/nodejs/node/pull/63503#issuecomment-4526589906
https://ci.nodejs.org/job/node-test-pull-request/73638/https://ci.nodejs.org/job/node-test-pull-request/73638/
Please reload this pagehttps://github.com/nodejs/node/pull/63503
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 24, 2026https://github.com/nodejs/node/pull/63503#event-25891055098
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 24, 2026 https://github.com/nodejs/node/pull/63503#pullrequestreview-4353281274
View reviewed changes https://github.com/nodejs/node/pull/63503/files/cee20670d40bdf58475462ec811311d5a89e7aa8
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/63503#pullrequestreview-4353281274
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/63503
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 24, 2026https://github.com/nodejs/node/pull/63503#event-25904264019
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 25, 2026https://github.com/nodejs/node/pull/63503#event-25915257235
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
8c495c8https://github.com/nodejs/node/commit/8c495c80309f58aab5e6d9035a22054a638110e0
May 25, 2026https://github.com/nodejs/node/pull/63503#event-25915340170
Please reload this pagehttps://github.com/nodejs/node/pull/63503
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 25, 2026https://github.com/nodejs/node/pull/63503#issuecomment-4532174962
8c495c8https://github.com/nodejs/node/commit/8c495c80309f58aab5e6d9035a22054a638110e0
Please reload this pagehttps://github.com/nodejs/node/pull/63503
araujoguihttps://github.com/araujogui
May 26, 2026 https://github.com/nodejs/node/pull/63503#ref-commit-89a0f6a
https://github.com/trivikr
https://github.com/araujogui
stream: wait for push writer end fallback to drainhttps://github.com/araujogui/node/commit/89a0f6aae4b00ce7bce05b905f7c7a1304061d70
89a0f6ahttps://github.com/araujogui/node/commit/89a0f6aae4b00ce7bce05b905f7c7a1304061d70
nodejs#63502https://github.com/nodejs/node/issues/63502
nodejs#63503https://github.com/nodejs/node/pull/63503
nodejs#63502https://github.com/nodejs/node/issues/63502
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 27, 2026 07:49https://github.com/nodejs/node/pull/63503#event-26004073016
aduh95https://github.com/aduh95
May 27, 2026 https://github.com/nodejs/node/pull/63503#ref-commit-dc12b73
https://github.com/trivikr
https://github.com/aduh95
stream: wait for push writer end fallback to drainhttps://github.com/nodejs/node/commit/dc12b730d850c632dd76dcefb8c7d82342e06899
dc12b73https://github.com/nodejs/node/commit/dc12b730d850c632dd76dcefb8c7d82342e06899
#63502https://github.com/nodejs/node/issues/63502
#63503https://github.com/nodejs/node/pull/63503
#63502https://github.com/nodejs/node/issues/63502
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 30, 2026 https://github.com/nodejs/node/pull/63503#ref-pullrequest-4555076114
2026-06-01, Version 26.3.0 (Current) #63664 https://github.com/nodejs/node/pull/63664
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63503
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/63503/files/cee20670d40bdf58475462ec811311d5a89e7aa8
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/63503/files/cee20670d40bdf58475462ec811311d5a89e7aa8
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: push writer.end() resolves before readable drains buffered data https://github.com/nodejs/node/issues/63502
Please reload this pagehttps://github.com/nodejs/node/pull/63503
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.