René's URL Explorer Experiment


Title: http2: finish pending writes after stream close by trivikr · Pull Request #63439 · nodejs/node · GitHub

Open Graph Title: http2: finish pending writes after stream close by trivikr · Pull Request #63439 · nodejs/node

X Title: http2: finish pending writes after stream close by trivikr · Pull Request #63439 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This fixes a race where an HTTP/2 stream can close while writes are still queued. In that state, pending write callbacks could be left unresolved, which kept the test process alive until timeout. T...

X Description: This fixes a race where an HTTP/2 stream can close while writes are still queued. In that state, pending write callbacks could be left unresolved, which kept the test process alive until timeout. T...

Opengraph URL: https://github.com/nodejs/node/pull/63439

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fbbe7719-b2c4-8f24-cd1b-c08a5b7606f7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F08:2165A6:90F11D:9511A0:6A6385D7
html-safe-nonce710d7492b5f812af4c3a9582f9557372ba4442855b4e9b5358d86177c0eb0da3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjA4OjIxNjVBNjo5MEYxMUQ6OTUxMUEwOjZBNjM4NUQ3IiwidmlzaXRvcl9pZCI6Ijg3OTU5MjYyOTc2NTc0NDM3OTkiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ==
visitor-hmacbe34a92ed99e29873137374cf8c49d405b03985e661f624a97595cf3fbc1d3e2
hovercard-subject-tagpull_request:3711368495
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63439/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/740efc4d50c497879966f6c2a75dbb01ead03c0782a6fbfab3414342447fcc80/nodejs/node/pull/63439
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/740efc4d50c497879966f6c2a75dbb01ead03c0782a6fbfab3414342447fcc80/nodejs/node/pull/63439
og:image:altThis fixes a race where an HTTP/2 stream can close while writes are still queued. In that state, pending write callbacks could be left unresolved, which kept the test process alive until timeout. T...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
Nonee4fb64aef87da454ec25b158147f7f5f14aef29216e5ca1612c2e48faa599d1f
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee839936ba5faffb9c836dda1cf4729d50c88a32e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63439#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63439
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63439
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63439
Reloadhttps://github.com/nodejs/node/pull/63439
Reloadhttps://github.com/nodejs/node/pull/63439
Please reload this pagehttps://github.com/nodejs/node/pull/63439
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63439
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 1k https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
trivikrhttps://github.com/trivikr
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:flaky-test-http2-close-while-writing-2https://github.com/trivikr/node/tree/flaky-test-http2-close-while-writing-2
Conversationhttps://github.com/nodejs/node/pull/63439
Commits1 (1)https://github.com/nodejs/node/pull/63439/commits
Checkshttps://github.com/nodejs/node/pull/63439/checks
Files changedhttps://github.com/nodejs/node/pull/63439/files
http2: finish pending writes after stream closehttps://github.com/nodejs/node/pull/63439#top
trivikrhttps://github.com/trivikr
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:flaky-test-http2-close-while-writing-2https://github.com/trivikr/node/tree/flaky-test-http2-close-while-writing-2
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 19, 2026https://github.com/nodejs/node/pull/63439#issue-4480301156
Please reload this pagehttps://github.com/nodejs/node/pull/63439
#58252https://github.com/nodejs/node/issues/58252
Please reload this pagehttps://github.com/nodejs/node/pull/63439
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 19, 2026https://github.com/nodejs/node/pull/63439#issuecomment-4491199669
Please reload this pagehttps://github.com/nodejs/node/pull/63439
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 19, 2026https://github.com/nodejs/node/pull/63439#event-25722674598
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/2bdb909ff600201673a258b23fa7cf9d88751824..125b0920dd155d57647ae75bb561f6915bbf7759
2bdb909https://github.com/nodejs/node/commit/2bdb909ff600201673a258b23fa7cf9d88751824
125b092https://github.com/nodejs/node/commit/125b0920dd155d57647ae75bb561f6915bbf7759
Compare https://github.com/nodejs/node/compare/2bdb909ff600201673a258b23fa7cf9d88751824..125b0920dd155d57647ae75bb561f6915bbf7759
May 19, 2026 19:23https://github.com/nodejs/node/pull/63439#event-25722941750
https://github.com/trivikr
http2: finish pending writes after stream closehttps://github.com/nodejs/node/pull/63439/commits/58e9183baf61e527425e484341babaed3f40c921
58e9183https://github.com/nodejs/node/pull/63439/commits/58e9183baf61e527425e484341babaed3f40c921
nodejs#58252https://github.com/nodejs/node/issues/58252
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/125b0920dd155d57647ae75bb561f6915bbf7759..58e9183baf61e527425e484341babaed3f40c921
125b092https://github.com/nodejs/node/commit/125b0920dd155d57647ae75bb561f6915bbf7759
58e9183https://github.com/nodejs/node/commit/58e9183baf61e527425e484341babaed3f40c921
Compare https://github.com/nodejs/node/compare/125b0920dd155d57647ae75bb561f6915bbf7759..58e9183baf61e527425e484341babaed3f40c921
May 19, 2026 19:40https://github.com/nodejs/node/pull/63439#event-25723659602
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 19, 2026https://github.com/nodejs/node/pull/63439#issuecomment-4491458986
#63249https://github.com/nodejs/node/pull/63249
#58252https://github.com/nodejs/node/issues/58252
Please reload this pagehttps://github.com/nodejs/node/pull/63439
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 19, 2026https://github.com/nodejs/node/pull/63439#issuecomment-4492044818
Please reload this pagehttps://github.com/nodejs/node/pull/63439
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63439?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
0b5b189https://app.codecov.io/gh/nodejs/node/commit/0b5b1894267f154b4e6b4c75b0057a2331f1f0ef?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
58e9183https://app.codecov.io/gh/nodejs/node/commit/58e9183baf61e527425e484341babaed3f40c921?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63439?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_http2.cchttps://app.codecov.io/gh/nodejs/node/pull/63439?src=pr&el=tree&filepath=src%2Fnode_http2.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfaHR0cDIuY2M=
0 Missing and 2 partials ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63439?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63439?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/http2/core.jshttps://app.codecov.io/gh/nodejs/node/pull/63439?src=pr&el=tree&filepath=lib%2Finternal%2Fhttp2%2Fcore.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2h0dHAyL2NvcmUuanM=
src/node_http2.hhttps://app.codecov.io/gh/nodejs/node/pull/63439?src=pr&el=tree&filepath=src%2Fnode_http2.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfaHR0cDIuaA==
src/node_http2.cchttps://app.codecov.io/gh/nodejs/node/pull/63439?src=pr&el=tree&filepath=src%2Fnode_http2.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfaHR0cDIuY2M=
29 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63439/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63439
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 19, 2026https://github.com/nodejs/node/pull/63439#event-25727454830
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 27, 2026 07:49https://github.com/nodejs/node/pull/63439#event-26004077097
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63439
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
parallel/test-http2-close-while-writing is flaky https://github.com/nodejs/node/issues/58252
Please reload this pagehttps://github.com/nodejs/node/pull/63439
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.