René's URL Explorer Experiment


Title: http2: emit ERR_HTTP2_INVALID_SESSION async instead of throwing synchronously by DavidUmunna · Pull Request #63422 · nodejs/node · GitHub

Open Graph Title: http2: emit ERR_HTTP2_INVALID_SESSION async instead of throwing synchronously by DavidUmunna · Pull Request #63422 · nodejs/node

X Title: http2: emit ERR_HTTP2_INVALID_SESSION async instead of throwing synchronously by DavidUmunna · Pull Request #63422 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This pull request addresses a subtle but important issue in the HTTP/2 session shutdown process to ensure correct event ordering when a session is closed, particularly when the underlying socket is...

X Description: This pull request addresses a subtle but important issue in the HTTP/2 session shutdown process to ensure correct event ordering when a session is closed, particularly when the underlying socket is...

Opengraph URL: https://github.com/nodejs/node/pull/63422

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b1b9f355-1c3d-0f1a-4387-53aed09c9b3f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCDA:34E523:9E7B3C:D7C4D0:6A4D4ED2
html-safe-nonce37132b7011bbebb378be3daba5f15f3e6f36d5769e57314dc4ccab3c4bb5afc6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0RBOjM0RTUyMzo5RTdCM0M6RDdDNEQwOjZBNEQ0RUQyIiwidmlzaXRvcl9pZCI6IjYyMTkzMzk5MzE3NjU3ODgzNzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf58f1567d985df2178e27135f0797f6caee4823f5f62b9d21a51424ac5a45a74
hovercard-subject-tagpull_request:3705803599
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63422/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7b8fb2e7a319d9fd16e930927aadc2e9a1e8e37c84f5e6409f0d4f6439dafbc8/nodejs/node/pull/63422
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7b8fb2e7a319d9fd16e930927aadc2e9a1e8e37c84f5e6409f0d4f6439dafbc8/nodejs/node/pull/63422
og:image:altThis pull request addresses a subtle but important issue in the HTTP/2 session shutdown process to ensure correct event ordering when a session is closed, particularly when the underlying socket is...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDavidUmunna
hostnamegithub.com
expected-hostnamegithub.com
None92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release56fc8347865a14e2ec811533d68f929cf4e0ec19
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63422#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63422
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63422
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63422
Reloadhttps://github.com/nodejs/node/pull/63422
Reloadhttps://github.com/nodejs/node/pull/63422
Please reload this pagehttps://github.com/nodejs/node/pull/63422
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63422
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 959 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
DavidUmunnahttps://github.com/DavidUmunna
nodejs:mainhttps://github.com/nodejs/node/tree/main
DavidUmunna:mainhttps://github.com/DavidUmunna/node/tree/main
Conversationhttps://github.com/nodejs/node/pull/63422
Commits9 (9)https://github.com/nodejs/node/pull/63422/commits
Checkshttps://github.com/nodejs/node/pull/63422/checks
Files changedhttps://github.com/nodejs/node/pull/63422/files
http2: emit ERR_HTTP2_INVALID_SESSION async instead of throwing synchronouslyhttps://github.com/nodejs/node/pull/63422#top
DavidUmunnahttps://github.com/DavidUmunna
nodejs:mainhttps://github.com/nodejs/node/tree/main
DavidUmunna:mainhttps://github.com/DavidUmunna/node/tree/main
https://github.com/DavidUmunna
DavidUmunnahttps://github.com/DavidUmunna
May 19, 2026https://github.com/nodejs/node/pull/63422#issue-4473737551
Please reload this pagehttps://github.com/nodejs/node/pull/63422
Please reload this pagehttps://github.com/nodejs/node/pull/63422
DavidUmunnahttps://github.com/DavidUmunna
May 19, 2026 01:55https://github.com/nodejs/node/pull/63422#commits-pushed-bac135f
https://github.com/DavidUmunna
http2: ensure session close event fires before stream close callbackshttps://github.com/nodejs/node/pull/63422/commits/bac135f6cdc608773979499b367a6da16c30ff84
bac135fhttps://github.com/nodejs/node/pull/63422/commits/bac135f6cdc608773979499b367a6da16c30ff84
https://github.com/DavidUmunna
Merge branch 'nodejs:main' into mainhttps://github.com/nodejs/node/pull/63422/commits/e922ae8c9fb168f3200297a4ab9b568de9ae4672
e922ae8https://github.com/nodejs/node/pull/63422/commits/e922ae8c9fb168f3200297a4ab9b568de9ae4672
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 19, 2026https://github.com/nodejs/node/pull/63422#issuecomment-4483674848
Please reload this pagehttps://github.com/nodejs/node/pull/63422
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 19, 2026https://github.com/nodejs/node/pull/63422#event-25684497784
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 19, 2026https://github.com/nodejs/node/pull/63422#issuecomment-4484830115
Please reload this pagehttps://github.com/nodejs/node/pull/63422
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63422?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
3553a34https://app.codecov.io/gh/nodejs/node/commit/3553a34c2c596d9b1974e826b3a97bd25ec397d9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
a538ee7https://app.codecov.io/gh/nodejs/node/commit/a538ee746dcd1ba67f82a846700fd1f7c84d1e90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63422?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/http2/core.jshttps://app.codecov.io/gh/nodejs/node/pull/63422?src=pr&el=tree&filepath=lib%2Finternal%2Fhttp2%2Fcore.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2h0dHAyL2NvcmUuanM=
1 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63422?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/http2/core.jshttps://app.codecov.io/gh/nodejs/node/pull/63422?src=pr&el=tree&filepath=lib%2Finternal%2Fhttp2%2Fcore.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2h0dHAyL2NvcmUuanM=
23 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63422/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63422
https://github.com/pimterry
pimterryhttps://github.com/pimterry
May 19, 2026https://github.com/nodejs/node/pull/63422#issuecomment-4486393533
@DavidUmunnahttps://github.com/DavidUmunna
Please reload this pagehttps://github.com/nodejs/node/pull/63422
https://github.com/DavidUmunna
DavidUmunnahttps://github.com/DavidUmunna
May 19, 2026https://github.com/nodejs/node/pull/63422#issuecomment-4486776320
@DavidUmunnahttps://github.com/DavidUmunna
@pimterryhttps://github.com/pimterry
Please reload this pagehttps://github.com/nodejs/node/pull/63422
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 19, 2026https://github.com/nodejs/node/pull/63422#issuecomment-4487510723
#63412https://github.com/nodejs/node/issues/63412
#63412https://github.com/nodejs/node/issues/63412
Please reload this pagehttps://github.com/nodejs/node/pull/63422
DavidUmunnahttps://github.com/DavidUmunna
May 22, 2026 15:45https://github.com/nodejs/node/pull/63422#commits-pushed-857a01f
https://github.com/DavidUmunna
http2: ensure session.request() does not throw synchronously in strea…https://github.com/nodejs/node/pull/63422/commits/857a01f700dd31f8206cff8d44de5a0688b2fc1e
857a01fhttps://github.com/nodejs/node/pull/63422/commits/857a01f700dd31f8206cff8d44de5a0688b2fc1e
https://github.com/DavidUmunna
Merge branch 'nodejs:main' into mainhttps://github.com/nodejs/node/pull/63422/commits/a538ee746dcd1ba67f82a846700fd1f7c84d1e90
a538ee7https://github.com/nodejs/node/pull/63422/commits/a538ee746dcd1ba67f82a846700fd1f7c84d1e90
https://github.com/DavidUmunna
DavidUmunnahttps://github.com/DavidUmunna
May 22, 2026https://github.com/nodejs/node/pull/63422#event-25856403848
https://github.com/DavidUmunna
DavidUmunnahttps://github.com/DavidUmunna
May 22, 2026https://github.com/nodejs/node/pull/63422#issuecomment-4519822951
@pimterryhttps://github.com/pimterry
@mcollinahttps://github.com/mcollina
#63414https://github.com/nodejs/node/pull/63414
Please reload this pagehttps://github.com/nodejs/node/pull/63422
https://github.com/Qard
Qardhttps://github.com/Qard
May 22, 2026 https://github.com/nodejs/node/pull/63422#pullrequestreview-4346894742
View reviewed changes https://github.com/nodejs/node/pull/63422/files/a538ee746dcd1ba67f82a846700fd1f7c84d1e90
https://github.com/Giaxasidis
Giaxasidishttps://github.com/Giaxasidis
May 22, 2026 https://github.com/nodejs/node/pull/63422#ref-issue-4470047792
http2: ClientHttp2Session can be invalid before close event is emitted #63412 https://github.com/nodejs/node/issues/63412
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 24, 2026 https://github.com/nodejs/node/pull/63422#pullrequestreview-4352123701
View reviewed changes https://github.com/nodejs/node/pull/63422/files/a538ee746dcd1ba67f82a846700fd1f7c84d1e90
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/63422#pullrequestreview-4352123701
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/63422
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 24, 2026https://github.com/nodejs/node/pull/63422#event-25896812279
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 24, 2026https://github.com/nodejs/node/pull/63422#event-25897076003
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 24, 2026https://github.com/nodejs/node/pull/63422#issuecomment-4528124719
https://ci.nodejs.org/job/node-test-pull-request/73653/https://ci.nodejs.org/job/node-test-pull-request/73653/
Please reload this pagehttps://github.com/nodejs/node/pull/63422
DavidUmunnahttps://github.com/DavidUmunna
May 24, 2026 17:12https://github.com/nodejs/node/pull/63422#commits-pushed-df4cc96
https://github.com/DavidUmunna
http2: update client.request() to return a stream that errors asynchr…https://github.com/nodejs/node/pull/63422/commits/df4cc96f83b6281c40e0e9c10ccf60d667de15f2
df4cc96https://github.com/nodejs/node/pull/63422/commits/df4cc96f83b6281c40e0e9c10ccf60d667de15f2
https://github.com/DavidUmunna
Merge branch 'main' ofhttps://github.com/nodejs/node/pull/63422/commits/d0b96eae8a919404335deb36ccfbcdc0ac2c5051
https://github.com/DavidUmunna/nodehttps://github.com/DavidUmunna/node
d0b96eahttps://github.com/nodejs/node/pull/63422/commits/d0b96eae8a919404335deb36ccfbcdc0ac2c5051
https://github.com/DavidUmunna
Merge branch 'nodejs:main' into mainhttps://github.com/nodejs/node/pull/63422/commits/e16075819ee568103452546fb0d574b4389ea132
e160758https://github.com/nodejs/node/pull/63422/commits/e16075819ee568103452546fb0d574b4389ea132
https://github.com/DavidUmunna
test: remove obsolete HTTP/2 session close testshttps://github.com/nodejs/node/pull/63422/commits/94593f9ce6a43b11ca949582d17a39eb958ff2bd
94593f9https://github.com/nodejs/node/pull/63422/commits/94593f9ce6a43b11ca949582d17a39eb958ff2bd
https://github.com/DavidUmunna
DavidUmunnahttps://github.com/DavidUmunna
Qardhttps://github.com/Qard
mcollinahttps://github.com/mcollina
May 26, 2026 20:00https://github.com/nodejs/node/pull/63422#event-25984308465
https://github.com/Qard
Qardhttps://github.com/Qard
May 28, 2026 https://github.com/nodejs/node/pull/63422#pullrequestreview-4378087462
View reviewed changes https://github.com/nodejs/node/pull/63422/files/94593f9ce6a43b11ca949582d17a39eb958ff2bd
https://github.com/DavidUmunna
Merge branch 'main' into mainhttps://github.com/nodejs/node/pull/63422/commits/9dbe14d3a57accef8792186ed3f8f733dd869931
9dbe14dhttps://github.com/nodejs/node/pull/63422/commits/9dbe14d3a57accef8792186ed3f8f733dd869931
https://github.com/Qard
Qardhttps://github.com/Qard
May 28, 2026 https://github.com/nodejs/node/pull/63422#pullrequestreview-4383453381
View reviewed changes https://github.com/nodejs/node/pull/63422/files/9dbe14d3a57accef8792186ed3f8f733dd869931
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63422
https://github.com/Qard
Qard https://github.com/Qard
https://github.com/nodejs/node/pull/63422/files/9dbe14d3a57accef8792186ed3f8f733dd869931
https://github.com/mcollina
mcollina https://github.com/mcollina
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/63422
https://github.com/DavidUmunna
https://github.com/nodejs-github-bot
https://github.com/pimterry
https://github.com/mcollina
https://github.com/Qard
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.