René's URL Explorer Experiment


Title: stream: propagate abort reason in share and broadcast by trivikr · Pull Request #63358 · nodejs/node · GitHub

Open Graph Title: stream: propagate abort reason in share and broadcast by trivikr · Pull Request #63358 · nodejs/node

X Title: stream: propagate abort reason in share and broadcast by trivikr · Pull Request #63358 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This updates broadcast({ signal }) and share(source, { signal }) to propagate signal.reason when the signal aborts. Previously, the abort handlers called cancel() with no reason. That made waiting ...

X Description: This updates broadcast({ signal }) and share(source, { signal }) to propagate signal.reason when the signal aborts. Previously, the abort handlers called cancel() with no reason. That made waiting ...

Opengraph URL: https://github.com/nodejs/node/pull/63358

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:49cb0d0c-c195-18fa-3aeb-e3fb32aa9a68
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F02:39FFB3:1A8CBD:250E6E:6A4C9990
html-safe-nonce8fcc5ddb4997532568070c415f2cfac1019c1f77e52f84c940c6c48101aaad5f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjAyOjM5RkZCMzoxQThDQkQ6MjUwRTZFOjZBNEM5OTkwIiwidmlzaXRvcl9pZCI6IjYyNDk5NjU2NTU2MzEzNzA2NDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf38a1b9da1aedac7b0151a1381492689ee44c915080a29b207c3be9de5b40b72
hovercard-subject-tagpull_request:3692834698
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63358/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0f283d8e4b24117865f13ed94e41860af9d42813dd6540137c46f3cfa862701a/nodejs/node/pull/63358
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0f283d8e4b24117865f13ed94e41860af9d42813dd6540137c46f3cfa862701a/nodejs/node/pull/63358
og:image:altThis updates broadcast({ signal }) and share(source, { signal }) to propagate signal.reason when the signal aborts. Previously, the abort handlers called cancel() with no reason. That made waiting ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a2dede45637df6b92ddcfe2a557e67d4b5854ae
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63358#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63358
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63358
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63358
Reloadhttps://github.com/nodejs/node/pull/63358
Reloadhttps://github.com/nodejs/node/pull/63358
Please reload this pagehttps://github.com/nodejs/node/pull/63358
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63358
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-abort-signalhttps://github.com/trivikr/node/tree/stream-iter-abort-signal
Conversationhttps://github.com/nodejs/node/pull/63358
Commits8 (8)https://github.com/nodejs/node/pull/63358/commits
Checkshttps://github.com/nodejs/node/pull/63358/checks
Files changedhttps://github.com/nodejs/node/pull/63358/files
stream: propagate abort reason in share and broadcasthttps://github.com/nodejs/node/pull/63358#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-abort-signalhttps://github.com/trivikr/node/tree/stream-iter-abort-signal
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 16, 2026https://github.com/nodejs/node/pull/63358#issue-4457789653
https://stream-iter.jasnell.me/#dictdef-broadcastoptionshttps://stream-iter.jasnell.me/#dictdef-broadcastoptions
https://stream-iter.jasnell.me/#dictdef-shareoptionshttps://stream-iter.jasnell.me/#dictdef-shareoptions
https://stream-iter.jasnell.me/#broadcast-cancelhttps://stream-iter.jasnell.me/#broadcast-cancel
#63357https://github.com/nodejs/node/issues/63357
Please reload this pagehttps://github.com/nodejs/node/pull/63358
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 16, 2026https://github.com/nodejs/node/pull/63358#issuecomment-4464681235
Please reload this pagehttps://github.com/nodejs/node/pull/63358
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
May 16, 2026https://github.com/nodejs/node/pull/63358#event-25597791053
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 16, 2026 https://github.com/nodejs/node/pull/63358#ref-issue-4457655551
stream/iter: abort signal causes broadcast() and share() consumers to resolve EOF instead of rejecting #63357 https://github.com/nodejs/node/issues/63357
https://github.com/trivikr
trivikrhttps://github.com/trivikr
jasnellhttps://github.com/jasnell
May 16, 2026 00:17https://github.com/nodejs/node/pull/63358#event-25597812350
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 16, 2026https://github.com/nodejs/node/pull/63358#event-25597823833
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 16, 2026https://github.com/nodejs/node/pull/63358#issuecomment-4465113806
Please reload this pagehttps://github.com/nodejs/node/pull/63358
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63358?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
2f56cd2https://app.codecov.io/gh/nodejs/node/commit/2f56cd275ec3fded8bb379e4bc979b60495b929b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
4236470https://app.codecov.io/gh/nodejs/node/commit/4236470fc0e595f23457b173eebfa13f553e4f72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63358?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/broadcast.jshttps://app.codecov.io/gh/nodejs/node/pull/63358?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fbroadcast.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9icm9hZGNhc3QuanM=
lib/internal/streams/iter/share.jshttps://app.codecov.io/gh/nodejs/node/pull/63358?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fshare.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9zaGFyZS5qcw==
39 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63358/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63358
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 16, 2026https://github.com/nodejs/node/pull/63358#event-25601743363
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/bf6a9c3f70cdfd84d9230c55aab918b91ec5a1c9..0b2f09f0b1da2e28445de49dfe7ce8462961a70e
bf6a9c3https://github.com/nodejs/node/commit/bf6a9c3f70cdfd84d9230c55aab918b91ec5a1c9
0b2f09fhttps://github.com/nodejs/node/commit/0b2f09f0b1da2e28445de49dfe7ce8462961a70e
Compare https://github.com/nodejs/node/compare/bf6a9c3f70cdfd84d9230c55aab918b91ec5a1c9..0b2f09f0b1da2e28445de49dfe7ce8462961a70e
May 17, 2026 23:37https://github.com/nodejs/node/pull/63358#event-25634870135
https://github.com/aduh95
aduh95https://github.com/aduh95
May 19, 2026 https://github.com/nodejs/node/pull/63358#pullrequestreview-4320581156
View reviewed changes https://github.com/nodejs/node/pull/63358/files
test/parallel/test-stream-iter-broadcast-from.jshttps://github.com/nodejs/node/pull/63358/files#diff-cd00b4f21b2cf1f28ba2987a704dbdbe5ac157b997341e217e06ecd6546c0712
Please reload this pagehttps://github.com/nodejs/node/pull/63358
https://github.com/aduh95
aduh95https://github.com/aduh95
May 19, 2026 https://github.com/nodejs/node/pull/63358#pullrequestreview-4320611598
View reviewed changes https://github.com/nodejs/node/pull/63358/files
test/parallel/test-stream-iter-share-async.jshttps://github.com/nodejs/node/pull/63358/files#diff-3ee1b7bf6ead385cc930b43b2e07ed891f657e9658743171a6504691f1b76c24
Please reload this pagehttps://github.com/nodejs/node/pull/63358
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/0b2f09f0b1da2e28445de49dfe7ce8462961a70e..357819ad9c91300af20ef396c135a3a96beb0b9c
0b2f09fhttps://github.com/nodejs/node/commit/0b2f09f0b1da2e28445de49dfe7ce8462961a70e
357819ahttps://github.com/nodejs/node/commit/357819ad9c91300af20ef396c135a3a96beb0b9c
Compare https://github.com/nodejs/node/compare/0b2f09f0b1da2e28445de49dfe7ce8462961a70e..357819ad9c91300af20ef396c135a3a96beb0b9c
May 19, 2026 21:30https://github.com/nodejs/node/pull/63358#event-25727947815
https://github.com/trivikr
trivikrhttps://github.com/trivikr
aduh95https://github.com/aduh95
May 20, 2026 06:40https://github.com/nodejs/node/pull/63358#event-25742768927
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 21, 2026https://github.com/nodejs/node/pull/63358#event-25783788612
trivikrhttps://github.com/trivikr
May 21, 2026 22:36https://github.com/nodejs/node/pull/63358#commits-pushed-6f07d2c
https://github.com/trivikr
stream: propagate abort reason in share and broadcasthttps://github.com/nodejs/node/pull/63358/commits/6f07d2cfbb76793336a76f069f4585df569ba9f6
6f07d2chttps://github.com/nodejs/node/pull/63358/commits/6f07d2cfbb76793336a76f069f4585df569ba9f6
nodejs#63357https://github.com/nodejs/node/issues/63357
https://github.com/trivikr
test: avoid no-yield generator in stream iter share testhttps://github.com/nodejs/node/pull/63358/commits/c26d689f31440d819a92949e35af72f49a0b1c94
c26d689https://github.com/nodejs/node/pull/63358/commits/c26d689f31440d819a92949e35af72f49a0b1c94
https://github.com/trivikr
chore: remove unrelated changes from test-stream-iter-broadcast-from.jshttps://github.com/nodejs/node/pull/63358/commits/6d8548cf979529ef5cba97722dbf17159880ba98
6d8548chttps://github.com/nodejs/node/pull/63358/commits/6d8548cf979529ef5cba97722dbf17159880ba98
https://github.com/trivikr
test: verify share abort propagates signal reasonhttps://github.com/nodejs/node/pull/63358/commits/56e73b8646d23ea6e4d87b3017dd50e9adf1ad78
56e73b8https://github.com/nodejs/node/pull/63358/commits/56e73b8646d23ea6e4d87b3017dd50e9adf1ad78
https://github.com/trivikr
test: expect AbortError for stream iter broadcast signal aborthttps://github.com/nodejs/node/pull/63358/commits/5ebe6edc61f932c2e2f5a3a603fd1ff62784bded
5ebe6edhttps://github.com/nodejs/node/pull/63358/commits/5ebe6edc61f932c2e2f5a3a603fd1ff62784bded
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/7cd59d9fc867f65db5ceed79f61e50610f4034b7..5ebe6edc61f932c2e2f5a3a603fd1ff62784bded
7cd59d9https://github.com/nodejs/node/commit/7cd59d9fc867f65db5ceed79f61e50610f4034b7
5ebe6edhttps://github.com/nodejs/node/commit/5ebe6edc61f932c2e2f5a3a603fd1ff62784bded
Compare https://github.com/nodejs/node/compare/7cd59d9fc867f65db5ceed79f61e50610f4034b7..5ebe6edc61f932c2e2f5a3a603fd1ff62784bded
May 22, 2026 05:36https://github.com/nodejs/node/pull/63358#event-25836802924
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 22, 2026 https://github.com/nodejs/node/pull/63358#pullrequestreview-4345890277
View reviewed changes https://github.com/nodejs/node/pull/63358/files/5ebe6edc61f932c2e2f5a3a603fd1ff62784bded
lib/internal/streams/iter/broadcast.jshttps://github.com/nodejs/node/pull/63358/files/5ebe6edc61f932c2e2f5a3a603fd1ff62784bded#diff-3c3b3eb3fc844b33761f7d97032a6b2c580497aa5f6069f0e8a659e99c889e1c
Please reload this pagehttps://github.com/nodejs/node/pull/63358
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 22, 2026 https://github.com/nodejs/node/pull/63358#pullrequestreview-4345898094
View reviewed changes https://github.com/nodejs/node/pull/63358/files/5ebe6edc61f932c2e2f5a3a603fd1ff62784bded
lib/internal/streams/iter/share.jshttps://github.com/nodejs/node/pull/63358/files/5ebe6edc61f932c2e2f5a3a603fd1ff62784bded#diff-cbbd247e6f3d7186a7d7d21fa07bac75435e6eceb14eac213e815e45f0669731
Please reload this pagehttps://github.com/nodejs/node/pull/63358
https://github.com/aduh95
aduh95https://github.com/aduh95
May 22, 2026 https://github.com/nodejs/node/pull/63358#pullrequestreview-4346471476
View reviewed changes https://github.com/nodejs/node/pull/63358/files/5ebe6edc61f932c2e2f5a3a603fd1ff62784bded
test/parallel/test-stream-iter-share-async.jshttps://github.com/nodejs/node/pull/63358/files/5ebe6edc61f932c2e2f5a3a603fd1ff62784bded#diff-3ee1b7bf6ead385cc930b43b2e07ed891f657e9658743171a6504691f1b76c24
Please reload this pagehttps://github.com/nodejs/node/pull/63358
https://github.com/aduh95
aduh95https://github.com/aduh95
May 22, 2026 https://github.com/nodejs/node/pull/63358#pullrequestreview-4346543042
View reviewed changes https://github.com/nodejs/node/pull/63358/files/5ebe6edc61f932c2e2f5a3a603fd1ff62784bded
test/parallel/test-stream-iter-share-async.jshttps://github.com/nodejs/node/pull/63358/files/5ebe6edc61f932c2e2f5a3a603fd1ff62784bded#diff-3ee1b7bf6ead385cc930b43b2e07ed891f657e9658743171a6504691f1b76c24
Please reload this pagehttps://github.com/nodejs/node/pull/63358
trivikrhttps://github.com/trivikr
May 22, 2026 08:17https://github.com/nodejs/node/pull/63358#commits-pushed-41905e7
https://github.com/trivikr
streams: lift signal cancellation handlers in iter helpershttps://github.com/nodejs/node/pull/63358/commits/41905e7114e9f109e97bbcff2bc35e41ec5221af
41905e7https://github.com/nodejs/node/pull/63358/commits/41905e7114e9f109e97bbcff2bc35e41ec5221af
https://github.com/trivikr
test: simplify stream iter abort rejection assertionhttps://github.com/nodejs/node/pull/63358/commits/56e310fec182b985948535c5dc6e5d25b6cc8269
56e310fhttps://github.com/nodejs/node/pull/63358/commits/56e310fec182b985948535c5dc6e5d25b6cc8269
https://github.com/trivikr
test: use Promise.withResolvers in stream iter share testhttps://github.com/nodejs/node/pull/63358/commits/4236470fc0e595f23457b173eebfa13f553e4f72
4236470https://github.com/nodejs/node/pull/63358/commits/4236470fc0e595f23457b173eebfa13f553e4f72
https://github.com/trivikr
trivikrhttps://github.com/trivikr
aduh95https://github.com/aduh95
jasnellhttps://github.com/jasnell
May 22, 2026 15:28https://github.com/nodejs/node/pull/63358#event-25857920020
https://github.com/aduh95
aduh95https://github.com/aduh95
May 22, 2026 https://github.com/nodejs/node/pull/63358#pullrequestreview-4346706071
View reviewed changes https://github.com/nodejs/node/pull/63358/files/4236470fc0e595f23457b173eebfa13f553e4f72
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 22, 2026https://github.com/nodejs/node/pull/63358#event-25858012817
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 22, 2026https://github.com/nodejs/node/pull/63358#event-25859331397
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 22, 2026https://github.com/nodejs/node/pull/63358#issuecomment-4520380437
https://ci.nodejs.org/job/node-test-pull-request/73617/https://ci.nodejs.org/job/node-test-pull-request/73617/
Please reload this pagehttps://github.com/nodejs/node/pull/63358
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
May 23, 2026https://github.com/nodejs/node/pull/63358#event-25872997621
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 23, 2026https://github.com/nodejs/node/pull/63358#event-25873556419
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
a7d5446https://github.com/nodejs/node/commit/a7d544697ad037e2d0054309851d1af948bb72e8
May 23, 2026https://github.com/nodejs/node/pull/63358#event-25873599791
Please reload this pagehttps://github.com/nodejs/node/pull/63358
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 23, 2026https://github.com/nodejs/node/pull/63358#issuecomment-4523663031
a7d5446https://github.com/nodejs/node/commit/a7d544697ad037e2d0054309851d1af948bb72e8
Please reload this pagehttps://github.com/nodejs/node/pull/63358
araujoguihttps://github.com/araujogui
May 26, 2026 https://github.com/nodejs/node/pull/63358#ref-commit-51408e7
https://github.com/trivikr
https://github.com/araujogui
stream: propagate abort reason in share and broadcasthttps://github.com/araujogui/node/commit/51408e7feb62f35e107dfccb82c94eca21039db1
51408e7https://github.com/araujogui/node/commit/51408e7feb62f35e107dfccb82c94eca21039db1
nodejs#63357https://github.com/nodejs/node/issues/63357
nodejs#63358https://github.com/nodejs/node/pull/63358
nodejs#63357https://github.com/nodejs/node/issues/63357
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 27, 2026 07:50https://github.com/nodejs/node/pull/63358#event-26004101865
aduh95https://github.com/aduh95
May 27, 2026 https://github.com/nodejs/node/pull/63358#ref-commit-0008d01
https://github.com/trivikr
https://github.com/aduh95
stream: propagate abort reason in share and broadcasthttps://github.com/nodejs/node/commit/0008d01f9c646cb21b7d21cab547fff93b3f0a28
0008d01https://github.com/nodejs/node/commit/0008d01f9c646cb21b7d21cab547fff93b3f0a28
#63357https://github.com/nodejs/node/issues/63357
#63358https://github.com/nodejs/node/pull/63358
#63357https://github.com/nodejs/node/issues/63357
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 30, 2026 https://github.com/nodejs/node/pull/63358#ref-pullrequest-4555076114
2026-06-01, Version 26.3.0 (Current) #63664 https://github.com/nodejs/node/pull/63664
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63358
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/63358/files/4236470fc0e595f23457b173eebfa13f553e4f72
https://github.com/jasnell
jasnell https://github.com/jasnell
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: abort signal causes broadcast() and share() consumers to resolve EOF instead of rejecting https://github.com/nodejs/node/issues/63357
Please reload this pagehttps://github.com/nodejs/node/pull/63358
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.