René's URL Explorer Experiment


Title: stream: fix merge handling for object-like sources by trivikr · Pull Request #63356 · nodejs/node · GitHub

Open Graph Title: stream: fix merge handling for object-like sources by trivikr · Pull Request #63356 · nodejs/node

X Title: stream: fix merge handling for object-like sources by trivikr · Pull Request #63356 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: merge() previously treated any final non-iterable object as an options object, which dropped valid inputs that from() accepts, including ArrayBuffer, ArrayBufferView, and objects implementing Strea...

X Description: merge() previously treated any final non-iterable object as an options object, which dropped valid inputs that from() accepts, including ArrayBuffer, ArrayBufferView, and objects implementing Strea...

Opengraph URL: https://github.com/nodejs/node/pull/63356

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c039cf47-456e-cd62-2ba7-dedc6d285740
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA57C:328A67:2DC660:3D17CC:6A4D8C61
html-safe-noncea3e2f1ec0668591cb28c9bfdf0015a5b5825cdea1c7019e631477125ee2a4396
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTdDOjMyOEE2NzoyREM2NjA6M0QxN0NDOjZBNEQ4QzYxIiwidmlzaXRvcl9pZCI6IjE3NzgyNTAxMjYwMDQ2ODU5MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca9d363ffbe0cc2f997e9d3ec0c7bc0121cf39f005bf09670b5b85bacbbe4d50b
hovercard-subject-tagpull_request:3692450602
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63356/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/077cffe68e58d6371dc7e4470381e46e9b1e304f3fbb188563c1e225d02d8979/nodejs/node/pull/63356
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/077cffe68e58d6371dc7e4470381e46e9b1e304f3fbb188563c1e225d02d8979/nodejs/node/pull/63356
og:image:altmerge() previously treated any final non-iterable object as an options object, which dropped valid inputs that from() accepts, including ArrayBuffer, ArrayBufferView, and objects implementing Strea...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None9f8758a3953dfe943439713a6fa4f90d542a3431f10e861ca03dd7f39009f320
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebffd5484f01713a661b03469b77678f72b6574ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63356#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63356
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63356
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63356
Reloadhttps://github.com/nodejs/node/pull/63356
Reloadhttps://github.com/nodejs/node/pull/63356
Please reload this pagehttps://github.com/nodejs/node/pull/63356
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63356
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-merge-object-likehttps://github.com/trivikr/node/tree/stream-iter-merge-object-like
Conversationhttps://github.com/nodejs/node/pull/63356
Commits2 (2)https://github.com/nodejs/node/pull/63356/commits
Checkshttps://github.com/nodejs/node/pull/63356/checks
Files changedhttps://github.com/nodejs/node/pull/63356/files
stream: fix merge handling for object-like sourceshttps://github.com/nodejs/node/pull/63356#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-merge-object-likehttps://github.com/trivikr/node/tree/stream-iter-merge-object-like
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 15, 2026https://github.com/nodejs/node/pull/63356#issue-4457334611
#63355https://github.com/nodejs/node/issues/63355
Please reload this pagehttps://github.com/nodejs/node/pull/63356
https://github.com/trivikr
stream: fix merge handling for object-like sourceshttps://github.com/nodejs/node/pull/63356/commits/c457f364bc8077b432dc809b375685052eb21b3d
c457f36https://github.com/nodejs/node/pull/63356/commits/c457f364bc8077b432dc809b375685052eb21b3d
nodejs#63355https://github.com/nodejs/node/issues/63355
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 15, 2026https://github.com/nodejs/node/pull/63356#issuecomment-4464246767
Please reload this pagehttps://github.com/nodejs/node/pull/63356
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
May 15, 2026https://github.com/nodejs/node/pull/63356#event-25595371219
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 15, 2026 https://github.com/nodejs/node/pull/63356#pullrequestreview-4301815670
View reviewed changes https://github.com/nodejs/node/pull/63356/files/c457f364bc8077b432dc809b375685052eb21b3d
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
May 15, 2026 https://github.com/nodejs/node/pull/63356#pullrequestreview-4301871578
View reviewed changes https://github.com/nodejs/node/pull/63356/files/c457f364bc8077b432dc809b375685052eb21b3d
lib/internal/streams/iter/consumers.jshttps://github.com/nodejs/node/pull/63356/files/c457f364bc8077b432dc809b375685052eb21b3d#diff-92085d6405796cc8751e9e8ff1700d4e609e4f15f7aeb4c3a9f91684f974bd1c
Please reload this pagehttps://github.com/nodejs/node/pull/63356
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 15, 2026https://github.com/nodejs/node/pull/63356#issuecomment-4464597029
Please reload this pagehttps://github.com/nodejs/node/pull/63356
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63356?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
2d6cbeahttps://app.codecov.io/gh/nodejs/node/commit/2d6cbea73aade6dfd9eda2157af6fb6140355805?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
2502bfehttps://app.codecov.io/gh/nodejs/node/commit/2502bfea228f7199b113a9d4558eb40e1b429a5c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63356?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/consumers.jshttps://app.codecov.io/gh/nodejs/node/pull/63356?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fconsumers.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9jb25zdW1lcnMuanM=
44 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63356/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63356
https://github.com/trivikr
stream: check ArrayBuffer last in iter merge optionshttps://github.com/nodejs/node/pull/63356/commits/2502bfea228f7199b113a9d4558eb40e1b429a5c
2502bfehttps://github.com/nodejs/node/pull/63356/commits/2502bfea228f7199b113a9d4558eb40e1b429a5c
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Renegade334https://github.com/Renegade334
May 16, 2026 00:36https://github.com/nodejs/node/pull/63356#event-25598273882
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 16, 2026https://github.com/nodejs/node/pull/63356#event-25600269691
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 16, 2026https://github.com/nodejs/node/pull/63356#event-25601330571
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
May 16, 2026 https://github.com/nodejs/node/pull/63356#pullrequestreview-4303418031
View reviewed changes https://github.com/nodejs/node/pull/63356/files/2502bfea228f7199b113a9d4558eb40e1b429a5c
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 16, 2026https://github.com/nodejs/node/pull/63356#event-25605919141
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63356
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 16, 2026https://github.com/nodejs/node/pull/63356#issuecomment-4467121510
https://ci.nodejs.org/job/node-test-pull-request/73495/https://ci.nodejs.org/job/node-test-pull-request/73495/
Please reload this pagehttps://github.com/nodejs/node/pull/63356
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
May 16, 2026https://github.com/nodejs/node/pull/63356#event-25609595029
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 17, 2026https://github.com/nodejs/node/pull/63356#event-25634220090
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
bc90667https://github.com/nodejs/node/commit/bc906671a8afce57a41ee981b198ebbc95b25087
May 17, 2026https://github.com/nodejs/node/pull/63356#event-25634243934
Please reload this pagehttps://github.com/nodejs/node/pull/63356
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 17, 2026https://github.com/nodejs/node/pull/63356#issuecomment-4472736629
bc90667https://github.com/nodejs/node/commit/bc906671a8afce57a41ee981b198ebbc95b25087
Please reload this pagehttps://github.com/nodejs/node/pull/63356
aduh95https://github.com/aduh95
May 19, 2026 https://github.com/nodejs/node/pull/63356#ref-commit-09d7720
https://github.com/trivikr
https://github.com/aduh95
stream: fix merge handling for object-like sourceshttps://github.com/nodejs/node/commit/09d7720e60b40f40715e383cb52896c3daabbc62
09d7720https://github.com/nodejs/node/commit/09d7720e60b40f40715e383cb52896c3daabbc62
#63355https://github.com/nodejs/node/issues/63355
#63356https://github.com/nodejs/node/pull/63356
#63355https://github.com/nodejs/node/issues/63355
aduh95https://github.com/aduh95
May 19, 2026 https://github.com/nodejs/node/pull/63356#ref-commit-537455e
https://github.com/trivikr
https://github.com/aduh95
stream: fix merge handling for object-like sourceshttps://github.com/nodejs/node/commit/537455e98d47d9b69606d0d91a146dca6458f0fb
537455ehttps://github.com/nodejs/node/commit/537455e98d47d9b69606d0d91a146dca6458f0fb
#63355https://github.com/nodejs/node/issues/63355
#63356https://github.com/nodejs/node/pull/63356
#63355https://github.com/nodejs/node/issues/63355
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 19, 2026 https://github.com/nodejs/node/pull/63356#ref-pullrequest-4480613646
2026-05-20, Version 26.2.0 (Current) #63440 https://github.com/nodejs/node/pull/63440
panvahttps://github.com/panva
May 23, 2026 https://github.com/nodejs/node/pull/63356#ref-commit-dc9b2d5
https://github.com/trivikr
https://github.com/panva
stream: fix merge handling for object-like sourceshttps://github.com/panva/node/commit/dc9b2d5a79501962fcea89ba275965be37c9b567
dc9b2d5https://github.com/panva/node/commit/dc9b2d5a79501962fcea89ba275965be37c9b567
nodejs#63355https://github.com/nodejs/node/issues/63355
nodejs#63356https://github.com/nodejs/node/pull/63356
nodejs#63355https://github.com/nodejs/node/issues/63355
araujoguihttps://github.com/araujogui
May 26, 2026 https://github.com/nodejs/node/pull/63356#ref-commit-02b0d65
https://github.com/trivikr
https://github.com/araujogui
stream: fix merge handling for object-like sourceshttps://github.com/araujogui/node/commit/02b0d65aee58aee30600971986e945627fca0b4e
02b0d65https://github.com/araujogui/node/commit/02b0d65aee58aee30600971986e945627fca0b4e
nodejs#63355https://github.com/nodejs/node/issues/63355
nodejs#63356https://github.com/nodejs/node/pull/63356
nodejs#63355https://github.com/nodejs/node/issues/63355
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 27, 2026 07:49https://github.com/nodejs/node/pull/63356#event-26004083562
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63356
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/63356/files/c457f364bc8077b432dc809b375685052eb21b3d
https://github.com/Renegade334
Renegade334 https://github.com/Renegade334
https://github.com/nodejs/node/pull/63356/files/2502bfea228f7199b113a9d4558eb40e1b429a5c
https://github.com/trivikr
trivikr https://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: merge() treats valid object-like sources as options https://github.com/nodejs/node/issues/63355
Please reload this pagehttps://github.com/nodejs/node/pull/63356
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/Renegade334
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.