René's URL Explorer Experiment


Title: stream: uncork fromWritable writev on chunk error by trivikr · Pull Request #63295 · nodejs/node · GitHub

Open Graph Title: stream: uncork fromWritable writev on chunk error by trivikr · Pull Request #63295 · nodejs/node

X Title: stream: uncork fromWritable writev on chunk error by trivikr · Pull Request #63295 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes fromWritable().writev() leaving the wrapped classic Writable corked when conversion of a later chunk throws. Previously, writev() called writable.cork() before converting all chunks. If toUin...

X Description: Fixes fromWritable().writev() leaving the wrapped classic Writable corked when conversion of a later chunk throws. Previously, writev() called writable.cork() before converting all chunks. If toUin...

Opengraph URL: https://github.com/nodejs/node/pull/63295

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e9042eb9-fe68-2309-708f-579dbac675f4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD60:282FC3:60C96:7FB8E:6A4D8C98
html-safe-nonce9eed5cc87b56373dfebee9b56e4677bc6743681f37435e77542c090e5c6b15e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDYwOjI4MkZDMzo2MEM5Njo3RkI4RTo2QTREOEM5OCIsInZpc2l0b3JfaWQiOiIzODA2NzI0Njc1NTIzNjc3MzM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb25dbce18c68e9bcd607256241d4f054fa280de49ce36e57a6ec27c27f90196c
hovercard-subject-tagpull_request:3679535427
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63295/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c0a9ad8dc20acb84941d33e0f1dd0c11fd6bef703d95186cadbfb0b99b8688ed/nodejs/node/pull/63295
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c0a9ad8dc20acb84941d33e0f1dd0c11fd6bef703d95186cadbfb0b99b8688ed/nodejs/node/pull/63295
og:image:altFixes fromWritable().writev() leaving the wrapped classic Writable corked when conversion of a later chunk throws. Previously, writev() called writable.cork() before converting all chunks. If toUin...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None9f8758a3953dfe943439713a6fa4f90d542a3431f10e861ca03dd7f39009f320
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebffd5484f01713a661b03469b77678f72b6574ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63295#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63295
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63295
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63295
Reloadhttps://github.com/nodejs/node/pull/63295
Reloadhttps://github.com/nodejs/node/pull/63295
Please reload this pagehttps://github.com/nodejs/node/pull/63295
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63295
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-writable-corkedhttps://github.com/trivikr/node/tree/stream-iter-writable-corked
Conversationhttps://github.com/nodejs/node/pull/63295
Commits2 (2)https://github.com/nodejs/node/pull/63295/commits
Checkshttps://github.com/nodejs/node/pull/63295/checks
Files changedhttps://github.com/nodejs/node/pull/63295/files
stream: uncork fromWritable writev on chunk errorhttps://github.com/nodejs/node/pull/63295#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-writable-corkedhttps://github.com/trivikr/node/tree/stream-iter-writable-corked
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 13, 2026https://github.com/nodejs/node/pull/63295#issue-4441840149
#63294https://github.com/nodejs/node/issues/63294
Please reload this pagehttps://github.com/nodejs/node/pull/63295
https://github.com/trivikr
stream: uncork fromWritable writev on chunk errorhttps://github.com/nodejs/node/pull/63295/commits/6c6a23851cddf113b77de470dd6dab4538d2adb7
6c6a238https://github.com/nodejs/node/pull/63295/commits/6c6a23851cddf113b77de470dd6dab4538d2adb7
nodejs#63294https://github.com/nodejs/node/issues/63294
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 13, 2026https://github.com/nodejs/node/pull/63295#issuecomment-4445965473
Please reload this pagehttps://github.com/nodejs/node/pull/63295
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
May 13, 2026https://github.com/nodejs/node/pull/63295#event-25504934252
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 13, 2026https://github.com/nodejs/node/pull/63295#event-25504936102
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 13, 2026https://github.com/nodejs/node/pull/63295#event-25504949748
https://github.com/trivikr
stream: deduplicate classic writable writev loophttps://github.com/nodejs/node/pull/63295/commits/33ae1248bd523c74a116039992f0d95b8460257b
33ae124https://github.com/nodejs/node/pull/63295/commits/33ae1248bd523c74a116039992f0d95b8460257b
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 14, 2026https://github.com/nodejs/node/pull/63295#issuecomment-4446406134
Please reload this pagehttps://github.com/nodejs/node/pull/63295
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63295?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
c24e552https://app.codecov.io/gh/nodejs/node/commit/c24e552cc9b6aa02517feddbe6a785a04c8ad7f3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
33ae124https://app.codecov.io/gh/nodejs/node/commit/33ae1248bd523c74a116039992f0d95b8460257b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63295?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/classic.jshttps://app.codecov.io/gh/nodejs/node/pull/63295?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fclassic.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9jbGFzc2ljLmpz
2 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63295?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/classic.jshttps://app.codecov.io/gh/nodejs/node/pull/63295?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fclassic.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9jbGFzc2ljLmpz
30 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63295/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63295
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 14, 2026 https://github.com/nodejs/node/pull/63295#pullrequestreview-4286869076
View reviewed changes https://github.com/nodejs/node/pull/63295/files/33ae1248bd523c74a116039992f0d95b8460257b
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 14, 2026https://github.com/nodejs/node/pull/63295#event-25512179650
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63295
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 14, 2026https://github.com/nodejs/node/pull/63295#event-25512292083
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63295
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 14, 2026https://github.com/nodejs/node/pull/63295#issuecomment-4455304277
Please reload this pagehttps://github.com/nodejs/node/pull/63295
https://ci.nodejs.org/job/node-test-pull-request/73454/https://ci.nodejs.org/job/node-test-pull-request/73454/
Please reload this pagehttps://github.com/nodejs/node/pull/63295
https://github.com/Ethan-Arrowood
Ethan-Arrowoodhttps://github.com/Ethan-Arrowood
May 15, 2026 https://github.com/nodejs/node/pull/63295#pullrequestreview-4299563635
View reviewed changes https://github.com/nodejs/node/pull/63295/files/33ae1248bd523c74a116039992f0d95b8460257b
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
May 15, 2026https://github.com/nodejs/node/pull/63295#event-25583434394
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 15, 2026https://github.com/nodejs/node/pull/63295#event-25596739152
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c0327d3https://github.com/nodejs/node/commit/c0327d3cbb982c75cb2233e9f4ed483e39c03c73
May 15, 2026https://github.com/nodejs/node/pull/63295#event-25596781742
Please reload this pagehttps://github.com/nodejs/node/pull/63295
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 15, 2026https://github.com/nodejs/node/pull/63295#issuecomment-4464509766
c0327d3https://github.com/nodejs/node/commit/c0327d3cbb982c75cb2233e9f4ed483e39c03c73
Please reload this pagehttps://github.com/nodejs/node/pull/63295
aduh95https://github.com/aduh95
May 19, 2026 https://github.com/nodejs/node/pull/63295#ref-commit-7bc3477
https://github.com/trivikr
https://github.com/aduh95
stream: uncork fromWritable writev on chunk errorhttps://github.com/nodejs/node/commit/7bc347744eb99075d4282442bfec60fede08df15
7bc3477https://github.com/nodejs/node/commit/7bc347744eb99075d4282442bfec60fede08df15
#63294https://github.com/nodejs/node/issues/63294
#63295https://github.com/nodejs/node/pull/63295
#63294https://github.com/nodejs/node/issues/63294
aduh95https://github.com/aduh95
May 19, 2026 https://github.com/nodejs/node/pull/63295#ref-commit-253f5f4
https://github.com/trivikr
https://github.com/aduh95
stream: uncork fromWritable writev on chunk errorhttps://github.com/nodejs/node/commit/253f5f4ca23a9a1805b398a647563832f073ccaa
253f5f4https://github.com/nodejs/node/commit/253f5f4ca23a9a1805b398a647563832f073ccaa
#63294https://github.com/nodejs/node/issues/63294
#63295https://github.com/nodejs/node/pull/63295
#63294https://github.com/nodejs/node/issues/63294
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 19, 2026 https://github.com/nodejs/node/pull/63295#ref-pullrequest-4480613646
2026-05-20, Version 26.2.0 (Current) #63440 https://github.com/nodejs/node/pull/63440
araujoguihttps://github.com/araujogui
May 26, 2026 https://github.com/nodejs/node/pull/63295#ref-commit-e129372
https://github.com/trivikr
https://github.com/araujogui
stream: uncork fromWritable writev on chunk errorhttps://github.com/araujogui/node/commit/e129372927574b50722b30413a9e56080a2fdc59
e129372https://github.com/araujogui/node/commit/e129372927574b50722b30413a9e56080a2fdc59
nodejs#63294https://github.com/nodejs/node/issues/63294
nodejs#63295https://github.com/nodejs/node/pull/63295
nodejs#63294https://github.com/nodejs/node/issues/63294
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 27, 2026 07:50https://github.com/nodejs/node/pull/63295#event-26004106246
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63295
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/63295/files/33ae1248bd523c74a116039992f0d95b8460257b
https://github.com/Ethan-Arrowood
Ethan-Arrowood https://github.com/Ethan-Arrowood
https://github.com/nodejs/node/pull/63295/files/33ae1248bd523c74a116039992f0d95b8460257b
https://github.com/trivikr
trivikr https://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: fromWritable().writev() leaves Writable corked when chunk validation throws https://github.com/nodejs/node/issues/63294
Please reload this pagehttps://github.com/nodejs/node/pull/63295
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/Ethan-Arrowood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.