René's URL Explorer Experiment


Title: stream: preserve toReadableSync batch after backpressure by trivikr · Pull Request #63276 · nodejs/node · GitHub

Open Graph Title: stream: preserve toReadableSync batch after backpressure by trivikr · Pull Request #63276 · nodejs/node

X Title: stream: preserve toReadableSync batch after backpressure by trivikr · Pull Request #63276 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: toReadableSync() could drop chunks from a batch when classic stream backpressure was applied. When _read() pulled a batch with multiple chunks and push() returned false, the method returned immedia...

X Description: toReadableSync() could drop chunks from a batch when classic stream backpressure was applied. When _read() pulled a batch with multiple chunks and push() returned false, the method returned immedia...

Opengraph URL: https://github.com/nodejs/node/pull/63276

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9aefbe65-95fa-5a17-4242-45afe3052793
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA30E:7F6C6:7044C:962FE:6A4D8C95
html-safe-nonced15cc1760bc8d8b2d5ea36585f1aa3c4e254ffd83e158f563f3028a889a170ac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzBFOjdGNkM2OjcwNDRDOjk2MkZFOjZBNEQ4Qzk1IiwidmlzaXRvcl9pZCI6IjUzMjkzNTYzMDc4NDAyMDgwMjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca634df5bef6e6fd950890f9a5ae3458f34a2bff57935b93b0f3f61e05ca8f39e
hovercard-subject-tagpull_request:3674129827
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63276/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/93cc754d6ec198107ad9dbd15fbcbcc948469c2c0ac67656d6b63681f15e2714/nodejs/node/pull/63276
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/93cc754d6ec198107ad9dbd15fbcbcc948469c2c0ac67656d6b63681f15e2714/nodejs/node/pull/63276
og:image:alttoReadableSync() could drop chunks from a batch when classic stream backpressure was applied. When _read() pulled a batch with multiple chunks and push() returned false, the method returned immedia...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None9f8758a3953dfe943439713a6fa4f90d542a3431f10e861ca03dd7f39009f320
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebffd5484f01713a661b03469b77678f72b6574ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63276#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63276
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63276
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63276
Reloadhttps://github.com/nodejs/node/pull/63276
Reloadhttps://github.com/nodejs/node/pull/63276
Please reload this pagehttps://github.com/nodejs/node/pull/63276
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63276
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-to-readable-stream-backpressurehttps://github.com/trivikr/node/tree/stream-iter-to-readable-stream-backpressure
Conversationhttps://github.com/nodejs/node/pull/63276
Commits1 (1)https://github.com/nodejs/node/pull/63276/commits
Checkshttps://github.com/nodejs/node/pull/63276/checks
Files changedhttps://github.com/nodejs/node/pull/63276/files
stream: preserve toReadableSync batch after backpressurehttps://github.com/nodejs/node/pull/63276#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-to-readable-stream-backpressurehttps://github.com/trivikr/node/tree/stream-iter-to-readable-stream-backpressure
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 13, 2026https://github.com/nodejs/node/pull/63276#issue-4435565379
#63275https://github.com/nodejs/node/issues/63275
Please reload this pagehttps://github.com/nodejs/node/pull/63276
https://github.com/trivikr
stream: preserve toReadableSync batch after backpressurehttps://github.com/nodejs/node/pull/63276/commits/2c7eb4b811dd20509c14c6101e97f8f18f3a4f0d
2c7eb4bhttps://github.com/nodejs/node/pull/63276/commits/2c7eb4b811dd20509c14c6101e97f8f18f3a4f0d
nodejs#63275https://github.com/nodejs/node/issues/63275
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 13, 2026https://github.com/nodejs/node/pull/63276#issuecomment-4438132465
Please reload this pagehttps://github.com/nodejs/node/pull/63276
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
May 13, 2026https://github.com/nodejs/node/pull/63276#event-25468141794
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 13, 2026 https://github.com/nodejs/node/pull/63276#pullrequestreview-4279409389
View reviewed changes https://github.com/nodejs/node/pull/63276/files/2c7eb4b811dd20509c14c6101e97f8f18f3a4f0d
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/63276#pullrequestreview-4279409389
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/63276
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 13, 2026https://github.com/nodejs/node/pull/63276#event-25470479218
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 13, 2026https://github.com/nodejs/node/pull/63276#event-25470524136
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 13, 2026https://github.com/nodejs/node/pull/63276#issuecomment-4438808552
Please reload this pagehttps://github.com/nodejs/node/pull/63276
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63276?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
78bbee3https://app.codecov.io/gh/nodejs/node/commit/78bbee385b04c164bfee8fa90c0c698b3325af6b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
2c7eb4bhttps://app.codecov.io/gh/nodejs/node/commit/2c7eb4b811dd20509c14c6101e97f8f18f3a4f0d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63276?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/classic.jshttps://app.codecov.io/gh/nodejs/node/pull/63276?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fclassic.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9jbGFzc2ljLmpz
39 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63276/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63276
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 13, 2026https://github.com/nodejs/node/pull/63276#event-25471462643
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 13, 2026https://github.com/nodejs/node/pull/63276#issuecomment-4438844710
https://ci.nodejs.org/job/node-test-pull-request/73409/https://ci.nodejs.org/job/node-test-pull-request/73409/
Please reload this pagehttps://github.com/nodejs/node/pull/63276
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 13, 2026https://github.com/nodejs/node/pull/63276#issuecomment-4442501969
https://ci.nodejs.org/job/node-test-pull-request/73426/https://ci.nodejs.org/job/node-test-pull-request/73426/
Please reload this pagehttps://github.com/nodejs/node/pull/63276
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 13, 2026 https://github.com/nodejs/node/pull/63276#pullrequestreview-4283433247
View reviewed changes https://github.com/nodejs/node/pull/63276/files/2c7eb4b811dd20509c14c6101e97f8f18f3a4f0d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 13, 2026https://github.com/nodejs/node/pull/63276#issuecomment-4443396747
https://ci.nodejs.org/job/node-test-pull-request/73428/https://ci.nodejs.org/job/node-test-pull-request/73428/
Please reload this pagehttps://github.com/nodejs/node/pull/63276
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 14, 2026 https://github.com/nodejs/node/pull/63276#pullrequestreview-4286882627
View reviewed changes https://github.com/nodejs/node/pull/63276/files/2c7eb4b811dd20509c14c6101e97f8f18f3a4f0d
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 14, 2026https://github.com/nodejs/node/pull/63276#event-25510880224
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 14, 2026https://github.com/nodejs/node/pull/63276#issuecomment-4452039135
https://ci.nodejs.org/job/node-test-pull-request/73450/https://ci.nodejs.org/job/node-test-pull-request/73450/
Please reload this pagehttps://github.com/nodejs/node/pull/63276
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 15, 2026https://github.com/nodejs/node/pull/63276#event-25563397842
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 15, 2026https://github.com/nodejs/node/pull/63276#event-25563541160
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
6482073https://github.com/nodejs/node/commit/64820738972c21354c6c6abd96144d449054ac7d
May 15, 2026https://github.com/nodejs/node/pull/63276#event-25563806839
Please reload this pagehttps://github.com/nodejs/node/pull/63276
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 15, 2026https://github.com/nodejs/node/pull/63276#issuecomment-4457690335
6482073https://github.com/nodejs/node/commit/64820738972c21354c6c6abd96144d449054ac7d
Please reload this pagehttps://github.com/nodejs/node/pull/63276
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 15, 2026 07:01https://github.com/nodejs/node/pull/63276#event-25563843739
aduh95https://github.com/aduh95
May 19, 2026 https://github.com/nodejs/node/pull/63276#ref-commit-3e9a486
https://github.com/trivikr
https://github.com/aduh95
stream: preserve toReadableSync batch after backpressurehttps://github.com/nodejs/node/commit/3e9a4866594a3f756d108e944e6719274d001da3
3e9a486https://github.com/nodejs/node/commit/3e9a4866594a3f756d108e944e6719274d001da3
#63275https://github.com/nodejs/node/issues/63275
#63276https://github.com/nodejs/node/pull/63276
#63275https://github.com/nodejs/node/issues/63275
aduh95https://github.com/aduh95
May 19, 2026 https://github.com/nodejs/node/pull/63276#ref-commit-b568649
https://github.com/trivikr
https://github.com/aduh95
stream: preserve toReadableSync batch after backpressurehttps://github.com/nodejs/node/commit/b568649f6fa4f34773e81baf1c7dc12a21be5dcf
b568649https://github.com/nodejs/node/commit/b568649f6fa4f34773e81baf1c7dc12a21be5dcf
#63275https://github.com/nodejs/node/issues/63275
#63276https://github.com/nodejs/node/pull/63276
#63275https://github.com/nodejs/node/issues/63275
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 19, 2026 https://github.com/nodejs/node/pull/63276#ref-pullrequest-4480613646
2026-05-20, Version 26.2.0 (Current) #63440 https://github.com/nodejs/node/pull/63440
araujoguihttps://github.com/araujogui
May 26, 2026 https://github.com/nodejs/node/pull/63276#ref-commit-f41e4f8
https://github.com/trivikr
https://github.com/araujogui
stream: preserve toReadableSync batch after backpressurehttps://github.com/araujogui/node/commit/f41e4f85a670820d30898ecd9a20018f19a39e7d
f41e4f8https://github.com/araujogui/node/commit/f41e4f85a670820d30898ecd9a20018f19a39e7d
nodejs#63275https://github.com/nodejs/node/issues/63275
nodejs#63276https://github.com/nodejs/node/pull/63276
nodejs#63275https://github.com/nodejs/node/issues/63275
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63276
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/63276/files/2c7eb4b811dd20509c14c6101e97f8f18f3a4f0d
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/63276/files/2c7eb4b811dd20509c14c6101e97f8f18f3a4f0d
https://github.com/trivikr
trivikr https://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: toReadableSync() drops chunks after backpressure https://github.com/nodejs/node/issues/63275
Please reload this pagehttps://github.com/nodejs/node/pull/63276
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.