Title: [v24.x backport] repl: keep reference count for `process.on('newListener')` by addaleax · Pull Request #63194 · nodejs/node · GitHub
Open Graph Title: [v24.x backport] repl: keep reference count for `process.on('newListener')` by addaleax · Pull Request #63194 · nodejs/node
X Title: [v24.x backport] repl: keep reference count for `process.on('newListener')` by addaleax · Pull Request #63194 · nodejs/node
Description: Had a whitespace-only conflict. When investigating a memory leak in one of our applications, we discovered that this listener holds on to a REPLServer instance and all heap objects transitively kept alive by it by capturing as part of its closure. It's cleaner to declare the listener outside of the REPLServer class and to actually clean it up properly when it is no longer required or meaningful, which is easily achieved through keeping a reference count. PR-URL: #61895 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com
Open Graph Description: Had a whitespace-only conflict. When investigating a memory leak in one of our applications, we discovered that this listener holds on to a REPLServer instance and all heap objects transitively ke...
X Description: Had a whitespace-only conflict. When investigating a memory leak in one of our applications, we discovered that this listener holds on to a REPLServer instance and all heap objects transitively ke...
Opengraph URL: https://github.com/nodejs/node/pull/63194
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0e17b1b0-71c5-b5f7-a810-fe862c91ac7d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E82A:31360B:94BC1A:C9D9FD:6A4C4718 |
| html-safe-nonce | 5613b4a1c7950dd6510a7542ede6df08c5ad2dff1ba818db0d7f0b5b1e4c7842 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODJBOjMxMzYwQjo5NEJDMUE6QzlEOUZEOjZBNEM0NzE4IiwidmlzaXRvcl9pZCI6IjI1OTcxNzYzNjM1ODExOTYwNTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7c87432109c97a689735d07b297a793171914f1b554865021293a321fb9c6924 |
| hovercard-subject-tag | pull_request:3649393368 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/63194/files |
| twitter:image | https://avatars.githubusercontent.com/u/899444?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/899444?s=400&v=4 |
| og:image:alt | Had a whitespace-only conflict. When investigating a memory leak in one of our applications, we discovered that this listener holds on to a REPLServer instance and all heap objects transitively ke... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3996b3b83990e134be6c099ab9a7f48f140ae80f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width