René's URL Explorer Experiment


Title: sqlite: fix crash on db.close() from inside a user function by mceachen · Pull Request #63183 · nodejs/node · GitHub

Open Graph Title: sqlite: fix crash on db.close() from inside a user function by mceachen · Pull Request #63183 · nodejs/node

X Title: sqlite: fix crash on db.close() from inside a user function by mceachen · Pull Request #63183 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Calling db.close() from inside a user-defined function callback while sqlite3_step is on the call stack caused two distinct crashes: DatabaseSync::Close ran sqlite3_finalize on the statement whos...

X Description: Calling db.close() from inside a user-defined function callback while sqlite3_step is on the call stack caused two distinct crashes: DatabaseSync::Close ran sqlite3_finalize on the statement whos...

Opengraph URL: https://github.com/nodejs/node/pull/63183

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:284e9703-6c5f-f8b4-d49f-83629fe33a62
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE864:21A83E:280AB:3459A:6AED0F50
html-safe-nonce030b74847714af5ba89eb1a6ea12904df4f9b42f0560a7683508f64c4bcab8f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODY0OjIxQTgzRToyODBBQjozNDU5QTo2QUVEMEY1MCIsInZpc2l0b3JfaWQiOiI2NTEyNTY1MzkzNTQ3OTIzMjgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc7739f6ac9d30c4086f4d93dad0ffa88f3d12436d53427108acf035296d4102d
hovercard-subject-tagpull_request:3647299019
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63183/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/52814b66909f2e8f1fadd67b13ab0b58acd18582a68853484d11c9a5fa8daee4/nodejs/node/pull/63183
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/52814b66909f2e8f1fadd67b13ab0b58acd18582a68853484d11c9a5fa8daee4/nodejs/node/pull/63183
og:image:altCalling db.close() from inside a user-defined function callback while sqlite3_step is on the call stack caused two distinct crashes: DatabaseSync::Close ran sqlite3_finalize on the statement whos...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemceachen
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63183#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63183
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63183
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63183
Reloadhttps://github.com/nodejs/node/pull/63183
Reloadhttps://github.com/nodejs/node/pull/63183
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
mceachenhttps://github.com/mceachen
nodejs:mainhttps://github.com/nodejs/node/tree/main
mceachen:fix-sqlite-reentrant-close-segvhttps://github.com/mceachen/node/tree/fix-sqlite-reentrant-close-segv
Conversationhttps://github.com/nodejs/node/pull/63183
Commits3 (3)https://github.com/nodejs/node/pull/63183/commits
Checkshttps://github.com/nodejs/node/pull/63183/checks
Files changedhttps://github.com/nodejs/node/pull/63183/files
sqlite: fix crash on db.close() from inside a user functionhttps://github.com/nodejs/node/pull/63183#top
mceachenhttps://github.com/mceachen
nodejs:mainhttps://github.com/nodejs/node/tree/main
mceachen:fix-sqlite-reentrant-close-segvhttps://github.com/mceachen/node/tree/fix-sqlite-reentrant-close-segv
https://github.com/mceachen
mceachenhttps://github.com/mceachen
May 8, 2026https://github.com/nodejs/node/pull/63183#issue-4403779414
#63180https://github.com/nodejs/node/issues/63180
Please reload this pagehttps://github.com/nodejs/node/pull/63183
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 8, 2026https://github.com/nodejs/node/pull/63183#issuecomment-4403348467
Please reload this pagehttps://github.com/nodejs/node/pull/63183
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
sqlite https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asqlite
May 8, 2026https://github.com/nodejs/node/pull/63183#event-25290584499
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 8, 2026https://github.com/nodejs/node/pull/63183#issuecomment-4403792007
Please reload this pagehttps://github.com/nodejs/node/pull/63183
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63183?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
bbf51adhttps://app.codecov.io/gh/nodejs/node/commit/bbf51ad24cbd80d5cf7b5a4df6e2ae1692c33d85?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
c02e2c0https://app.codecov.io/gh/nodejs/node/commit/c02e2c093f8fcd5c8022d2061faba22d324443d2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63183?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_sqlite.cchttps://app.codecov.io/gh/nodejs/node/pull/63183?src=pr&el=tree&filepath=src%2Fnode_sqlite.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmNj
1 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63183?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63183?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_sqlite.hhttps://app.codecov.io/gh/nodejs/node/pull/63183?src=pr&el=tree&filepath=src%2Fnode_sqlite.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmg=
src/node_sqlite.cchttps://app.codecov.io/gh/nodejs/node/pull/63183?src=pr&el=tree&filepath=src%2Fnode_sqlite.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmNj
26 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63183/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63183
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
May 8, 2026https://github.com/nodejs/node/pull/63183#issuecomment-4404916979
Please reload this pagehttps://github.com/nodejs/node/pull/63183
https://github.com/mceachen
sqlite: fix crash on db.close() from inside a user functionhttps://github.com/nodejs/node/pull/63183/commits/14cd548ce26abde544c3f37358b89da8a244b5bc
14cd548https://github.com/nodejs/node/pull/63183/commits/14cd548ce26abde544c3f37358b89da8a244b5bc
nodejs#63180https://github.com/nodejs/node/issues/63180
https://github.com/mceachen
mceachenhttps://github.com/mceachen
force-pushedhttps://github.com/nodejs/node/compare/8adcb3b75ce63dea8150898625f80f6b8a418fd6..c6ce251b2dc517eb02b4545f11ec94a98429d3ce
8adcb3bhttps://github.com/nodejs/node/commit/8adcb3b75ce63dea8150898625f80f6b8a418fd6
c6ce251https://github.com/nodejs/node/commit/c6ce251b2dc517eb02b4545f11ec94a98429d3ce
Compare https://github.com/nodejs/node/compare/8adcb3b75ce63dea8150898625f80f6b8a418fd6..c6ce251b2dc517eb02b4545f11ec94a98429d3ce
May 9, 2026 03:24https://github.com/nodejs/node/pull/63183#event-25331045007
https://github.com/mceachen
sqlite: reject forbidden ops inside user-defined function callbackshttps://github.com/nodejs/node/pull/63183/commits/20d7ffa2eac8256f4dc39f85d4df95685ccb25b1
20d7ffahttps://github.com/nodejs/node/pull/63183/commits/20d7ffa2eac8256f4dc39f85d4df95685ccb25b1
https://github.com/mceachen
mceachenhttps://github.com/mceachen
force-pushedhttps://github.com/nodejs/node/compare/c6ce251b2dc517eb02b4545f11ec94a98429d3ce..20d7ffa2eac8256f4dc39f85d4df95685ccb25b1
c6ce251https://github.com/nodejs/node/commit/c6ce251b2dc517eb02b4545f11ec94a98429d3ce
20d7ffahttps://github.com/nodejs/node/commit/20d7ffa2eac8256f4dc39f85d4df95685ccb25b1
Compare https://github.com/nodejs/node/compare/c6ce251b2dc517eb02b4545f11ec94a98429d3ce..20d7ffa2eac8256f4dc39f85d4df95685ccb25b1
May 9, 2026 03:28https://github.com/nodejs/node/pull/63183#event-25331101285
https://github.com/mceachen
mceachenhttps://github.com/mceachen
May 9, 2026https://github.com/nodejs/node/pull/63183#issuecomment-4411295075
@Renegade334https://github.com/Renegade334
Please reload this pagehttps://github.com/nodejs/node/pull/63183
https://github.com/mceachen
mceachenhttps://github.com/mceachen
May 9, 2026https://github.com/nodejs/node/pull/63183#issuecomment-4411329085
Please reload this pagehttps://github.com/nodejs/node/pull/63183
Please reload this pagehttps://github.com/nodejs/node/pull/63183
https://github.com/mceachen
sqlite: narrow user-callback guard to per-statement reentryhttps://github.com/nodejs/node/pull/63183/commits/c02e2c093f8fcd5c8022d2061faba22d324443d2
c02e2c0https://github.com/nodejs/node/pull/63183/commits/c02e2c093f8fcd5c8022d2061faba22d324443d2
https://github.com/mceachen
mceachenhttps://github.com/mceachen
force-pushedhttps://github.com/nodejs/node/compare/df560ee86b610c99f01dc66e1838d25f9cbeb9ef..c02e2c093f8fcd5c8022d2061faba22d324443d2
df560eehttps://github.com/nodejs/node/commit/df560ee86b610c99f01dc66e1838d25f9cbeb9ef
c02e2c0https://github.com/nodejs/node/commit/c02e2c093f8fcd5c8022d2061faba22d324443d2
Compare https://github.com/nodejs/node/compare/df560ee86b610c99f01dc66e1838d25f9cbeb9ef..c02e2c093f8fcd5c8022d2061faba22d324443d2
May 9, 2026 04:47https://github.com/nodejs/node/pull/63183#event-25332276015
https://github.com/mceachen
mceachenhttps://github.com/mceachen
May 9, 2026 https://github.com/nodejs/node/pull/63183#ref-issue-4411321283
sqlite: authorizer callback can modify invoking connection despite SQLite contract #63207 https://github.com/nodejs/node/issues/63207
https://github.com/mceachen
mceachenhttps://github.com/mceachen
May 21, 2026https://github.com/nodejs/node/pull/63183#issuecomment-4511096590
@Renegade334https://github.com/Renegade334
@geeksilva97https://github.com/geeksilva97
Please reload this pagehttps://github.com/nodejs/node/pull/63183
https://github.com/louwers
louwershttps://github.com/louwers
May 22, 2026 https://github.com/nodejs/node/pull/63183#pullrequestreview-4349089697
View reviewed changes https://github.com/nodejs/node/pull/63183/files/c02e2c093f8fcd5c8022d2061faba22d324443d2
louwershttps://github.com/louwers
https://github.com/nodejs/node/pull/63183#pullrequestreview-4349089697
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/63183
https://github.com/TrevorBurnham
TrevorBurnhamhttps://github.com/TrevorBurnham
Aug 4, 2026 https://github.com/nodejs/node/pull/63183#ref-issue-2917995678
stabilization of node:sqlite module #57445 https://github.com/nodejs/node/issues/57445
https://github.com/TrevorBurnham
TrevorBurnhamhttps://github.com/TrevorBurnham
Aug 5, 2026 https://github.com/nodejs/node/pull/63183#pullrequestreview-4865797670
View reviewed changes https://github.com/nodejs/node/pull/63183/files/c02e2c093f8fcd5c8022d2061faba22d324443d2
src/node_sqlite.cchttps://github.com/nodejs/node/pull/63183/files/c02e2c093f8fcd5c8022d2061faba22d324443d2#diff-dd810db4fe69364c3a67a274e0725f386040c0fd1dcfade7093f23c8514328ae
TrevorBurnhamhttps://github.com/TrevorBurnham
Aug 5, 2026https://github.com/nodejs/node/pull/63183#discussion_r3721667072
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/63183
src/node_sqlite.hhttps://github.com/nodejs/node/pull/63183/files/c02e2c093f8fcd5c8022d2061faba22d324443d2#diff-95cdec6fdad0206569f5fc4d6eca280a76b377e50ab0a594d3938248fba23107
TrevorBurnhamhttps://github.com/TrevorBurnham
Aug 5, 2026https://github.com/nodejs/node/pull/63183#discussion_r3721667086
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/63183
https://github.com/mceachen
mceachenhttps://github.com/mceachen
Aug 7, 2026https://github.com/nodejs/node/pull/63183#issuecomment-5212034243
#64743https://github.com/nodejs/node/pull/64743
Please reload this pagehttps://github.com/nodejs/node/pull/63183
https://github.com/mceachen
mceachenhttps://github.com/mceachen
Aug 7, 2026https://github.com/nodejs/node/pull/63183#event-29097914220
sqlite: reentrancy into a running statement from a user-defined function is unguarded #65102 https://github.com/nodejs/node/issues/65102
sqlite: reject reentry into a running statement #65106 https://github.com/nodejs/node/pull/65106
sqlite: reject connection access from authorizer callbacks #65156 https://github.com/nodejs/node/pull/65156
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Aug 17, 2026 https://github.com/nodejs/node/pull/63183#ref-pullrequest-5171485067
feat: add local MCP task orchestration ApptoAI/deskto#36 https://github.com/ApptoAI/deskto/pull/36
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63183
https://github.com/TrevorBurnham
TrevorBurnham https://github.com/TrevorBurnham
https://github.com/nodejs/node/pull/63183/files/c02e2c093f8fcd5c8022d2061faba22d324443d2
https://github.com/louwers
louwers https://github.com/louwers
https://github.com/nodejs/node/pull/63183/files/c02e2c093f8fcd5c8022d2061faba22d324443d2
Please reload this pagehttps://github.com/nodejs/node/pull/63183
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
sqlite https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asqlite
node:sqlite segfaults when db.close() is called from a user-defined function callback during query execution https://github.com/nodejs/node/issues/63180
Please reload this pagehttps://github.com/nodejs/node/pull/63183
https://github.com/mceachen
https://github.com/nodejs-github-bot
https://github.com/Renegade334
https://github.com/TrevorBurnham
https://github.com/louwers
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.