René's URL Explorer Experiment


Title: crypto: reject invalid raw key imports by panva · Pull Request #63134 · nodejs/node · GitHub

Open Graph Title: crypto: reject invalid raw key imports by panva · Pull Request #63134 · nodejs/node

X Title: crypto: reject invalid raw key imports by panva · Pull Request #63134 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes a couple edge cases related to raw key formats in node:crypto.

X Description: Fixes a couple edge cases related to raw key formats in node:crypto.

Opengraph URL: https://github.com/nodejs/node/pull/63134

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3c7e6ab3-c151-155c-9fc3-d86326f6e1b2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBCA0:410B2:2F68AD:3F8450:6A4D8C90
html-safe-nonce4ec27821614c3807b700d1d426e8c46e3d5e99d266b74a83a24b9d4646ce89ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0EwOjQxMEIyOjJGNjhBRDozRjg0NTA6NkE0RDhDOTAiLCJ2aXNpdG9yX2lkIjoiMjQzNjc4ODkyMzEwNTM4MTUyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc7b970788bf2b6a0ab9cd9f89f74be5d53ce62986b5964c7c584290dc77f05ae
hovercard-subject-tagpull_request:3632357543
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63134/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/14cca8667b49dc3d2c0a076e6853123f318f4ddf272f1211dc0fd9c701003ce7/nodejs/node/pull/63134
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/14cca8667b49dc3d2c0a076e6853123f318f4ddf272f1211dc0fd9c701003ce7/nodejs/node/pull/63134
og:image:altFixes a couple edge cases related to raw key formats in node:crypto.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepanva
hostnamegithub.com
expected-hostnamegithub.com
None9f8758a3953dfe943439713a6fa4f90d542a3431f10e861ca03dd7f39009f320
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebffd5484f01713a661b03469b77678f72b6574ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63134#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63134
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63134
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63134
Reloadhttps://github.com/nodejs/node/pull/63134
Reloadhttps://github.com/nodejs/node/pull/63134
Please reload this pagehttps://github.com/nodejs/node/pull/63134
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63134
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
panva:raw-format-fixeshttps://github.com/panva/node/tree/raw-format-fixes
Conversationhttps://github.com/nodejs/node/pull/63134
Commits1 (1)https://github.com/nodejs/node/pull/63134/commits
Checkshttps://github.com/nodejs/node/pull/63134/checks
Files changedhttps://github.com/nodejs/node/pull/63134/files
crypto: reject invalid raw key importshttps://github.com/nodejs/node/pull/63134#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
panva:raw-format-fixeshttps://github.com/panva/node/tree/raw-format-fixes
https://github.com/panva
panvahttps://github.com/panva
May 5, 2026https://github.com/nodejs/node/pull/63134#issue-4386267837
Please reload this pagehttps://github.com/nodejs/node/pull/63134
https://github.com/panva
crypto: reject invalid raw key importshttps://github.com/nodejs/node/pull/63134/commits/03c121c6e17ab4070e853992da0152160fb2d842
03c121chttps://github.com/nodejs/node/pull/63134/commits/03c121c6e17ab4070e853992da0152160fb2d842
https://github.com/panva
panvahttps://github.com/panva
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
experimental https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental
May 5, 2026https://github.com/nodejs/node/pull/63134#event-25189265466
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 5, 2026https://github.com/nodejs/node/pull/63134#issuecomment-4381947757
Please reload this pagehttps://github.com/nodejs/node/pull/63134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 5, 2026https://github.com/nodejs/node/pull/63134#event-25189271078
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 5, 2026https://github.com/nodejs/node/pull/63134#issuecomment-4382555116
Please reload this pagehttps://github.com/nodejs/node/pull/63134
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63134?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
18f938dhttps://app.codecov.io/gh/nodejs/node/commit/18f938d25481f595128b504d1fa7b439a4aadca9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
03c121chttps://app.codecov.io/gh/nodejs/node/commit/03c121c6e17ab4070e853992da0152160fb2d842?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63134?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/crypto/crypto_keys.cchttps://app.codecov.io/gh/nodejs/node/pull/63134?src=pr&el=tree&filepath=src%2Fcrypto%2Fcrypto_keys.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2NyeXB0by9jcnlwdG9fa2V5cy5jYw==
2 Missing and 19 partials ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63134?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/crypto/keys.jshttps://app.codecov.io/gh/nodejs/node/pull/63134?src=pr&el=tree&filepath=lib%2Finternal%2Fcrypto%2Fkeys.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2NyeXB0by9rZXlzLmpz
lib/internal/crypto/ml_kem.jshttps://app.codecov.io/gh/nodejs/node/pull/63134?src=pr&el=tree&filepath=lib%2Finternal%2Fcrypto%2Fml_kem.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2NyeXB0by9tbF9rZW0uanM=
src/crypto/crypto_pqc.cchttps://app.codecov.io/gh/nodejs/node/pull/63134?src=pr&el=tree&filepath=src%2Fcrypto%2Fcrypto_pqc.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2NyeXB0by9jcnlwdG9fcHFjLmNj
src/crypto/crypto_keys.cchttps://app.codecov.io/gh/nodejs/node/pull/63134?src=pr&el=tree&filepath=src%2Fcrypto%2Fcrypto_keys.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2NyeXB0by9jcnlwdG9fa2V5cy5jYw==
48 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63134/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63134
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 5, 2026 https://github.com/nodejs/node/pull/63134#pullrequestreview-4231832539
View reviewed changes https://github.com/nodejs/node/pull/63134/files/03c121c6e17ab4070e853992da0152160fb2d842
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 5, 2026https://github.com/nodejs/node/pull/63134#event-25195467559
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 5, 2026https://github.com/nodejs/node/pull/63134#event-25195866704
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 6, 2026https://github.com/nodejs/node/pull/63134#issuecomment-4385124951
https://ci.nodejs.org/job/node-test-pull-request/73191/https://ci.nodejs.org/job/node-test-pull-request/73191/
Please reload this pagehttps://github.com/nodejs/node/pull/63134
https://github.com/aymen94
aymen94https://github.com/aymen94
May 6, 2026 https://github.com/nodejs/node/pull/63134#pullrequestreview-4236196044
View reviewed changes https://github.com/nodejs/node/pull/63134/files/03c121c6e17ab4070e853992da0152160fb2d842
https://github.com/anonrig
anonrighttps://github.com/anonrig
May 6, 2026 https://github.com/nodejs/node/pull/63134#pullrequestreview-4236208760
View reviewed changes https://github.com/nodejs/node/pull/63134/files/03c121c6e17ab4070e853992da0152160fb2d842
https://github.com/panva
panvahttps://github.com/panva
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 6, 2026https://github.com/nodejs/node/pull/63134#event-25218950649
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 6, 2026 https://github.com/nodejs/node/pull/63134#pullrequestreview-4237588245
View reviewed changes https://github.com/nodejs/node/pull/63134/files/03c121c6e17ab4070e853992da0152160fb2d842
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 7, 2026https://github.com/nodejs/node/pull/63134#event-25275739329
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
1fd4949https://github.com/nodejs/node/commit/1fd494962864ce545cb0a2fb961a3056210273ab
May 7, 2026https://github.com/nodejs/node/pull/63134#event-25275861272
Please reload this pagehttps://github.com/nodejs/node/pull/63134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 7, 2026https://github.com/nodejs/node/pull/63134#issuecomment-4400209660
1fd4949https://github.com/nodejs/node/commit/1fd494962864ce545cb0a2fb961a3056210273ab
Please reload this pagehttps://github.com/nodejs/node/pull/63134
https://github.com/panva
panvahttps://github.com/panva
May 7, 2026 19:02https://github.com/nodejs/node/pull/63134#event-25275864773
aduh95https://github.com/aduh95
May 19, 2026 https://github.com/nodejs/node/pull/63134#ref-commit-732d682
https://github.com/panva
https://github.com/aduh95
crypto: reject invalid raw key importshttps://github.com/nodejs/node/commit/732d68240d904db10afc8f348809064381c2fdb1
732d682https://github.com/nodejs/node/commit/732d68240d904db10afc8f348809064381c2fdb1
#63134https://github.com/nodejs/node/pull/63134
aduh95https://github.com/aduh95
May 19, 2026 https://github.com/nodejs/node/pull/63134#ref-commit-729274e
https://github.com/panva
https://github.com/aduh95
crypto: reject invalid raw key importshttps://github.com/nodejs/node/commit/729274e046e5ede4ad725f21d06a3b47666d3026
729274ehttps://github.com/nodejs/node/commit/729274e046e5ede4ad725f21d06a3b47666d3026
#63134https://github.com/nodejs/node/pull/63134
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 19, 2026 https://github.com/nodejs/node/pull/63134#ref-pullrequest-4480613646
2026-05-20, Version 26.2.0 (Current) #63440 https://github.com/nodejs/node/pull/63440
https://github.com/panva
panvahttps://github.com/panva
lts-watch-v24.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v24.x
May 21, 2026https://github.com/nodejs/node/pull/63134#event-25796206931
araujoguihttps://github.com/araujogui
May 26, 2026 https://github.com/nodejs/node/pull/63134#ref-commit-65ae591
https://github.com/panva
https://github.com/araujogui
crypto: reject invalid raw key importshttps://github.com/araujogui/node/commit/65ae5919c92aa1307ceb90e8cbfe83fd162dd0be
65ae591https://github.com/araujogui/node/commit/65ae5919c92aa1307ceb90e8cbfe83fd162dd0be
nodejs#63134https://github.com/nodejs/node/pull/63134
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63134
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/63134/files/03c121c6e17ab4070e853992da0152160fb2d842
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/63134/files/03c121c6e17ab4070e853992da0152160fb2d842
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/63134/files/03c121c6e17ab4070e853992da0152160fb2d842
https://github.com/aymen94
aymen94 https://github.com/aymen94
https://github.com/nodejs/node/pull/63134/files/03c121c6e17ab4070e853992da0152160fb2d842
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
experimental https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
lts-watch-v24.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v24.x
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/63134
https://github.com/panva
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/addaleax
https://github.com/anonrig
https://github.com/aymen94
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.