Title: test: relax min assertion in test-performance-eventloopdelay by marcopiraccini · Pull Request #63100 · nodejs/node · GitHub
Open Graph Title: test: relax min assertion in test-performance-eventloopdelay by marcopiraccini · Pull Request #63100 · nodejs/node
X Title: test: relax min assertion in test-performance-eventloopdelay by marcopiraccini · Pull Request #63100 · nodejs/node
Description: Fixes this flacky test issue: #41286 I think the test is wrong and it should check min >= 0. monitorEventLoopDelay configures the histogram with lowest_discernible_value = 1000 ns. hdr_min() returns the lower bound of the bucket the smallest sample landed in, and for that config the first bucket is [0, 512) ns — lower bound 0. So min === 0 just means the smallest sample fell into the first bucket. In other words, seems to me that the assert is wrong, and min === 0 is legit This PR fixes the assert.
Open Graph Description: Fixes this flacky test issue: #41286 I think the test is wrong and it should check min >= 0. monitorEventLoopDelay configures the histogram with lowest_discernible_value = 1000 ns. hdr_min() ret...
X Description: Fixes this flacky test issue: #41286 I think the test is wrong and it should check min >= 0. monitorEventLoopDelay configures the histogram with lowest_discernible_value = 1000 ns. hdr_min()...
Opengraph URL: https://github.com/nodejs/node/pull/63100
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files/:range(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:65318748-dc6b-be36-78ea-d8885cbf63ac |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 987E:1BFF5B:60E2C6C:640E313:6A655A73 |
| html-safe-nonce | 0cd37576c7c44df5c92cb6609b88cef153167aa07fde7d72158082cd73e487da |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODdFOjFCRkY1Qjo2MEUyQzZDOjY0MEUzMTM6NkE2NTVBNzMiLCJ2aXNpdG9yX2lkIjoiNjE4Nzk2NjcxOTI2ODg0OTc5IiwicmVnaW9uX2VkZ2UiOiJzZWEiLCJyZWdpb25fcmVuZGVyIjoic2VhIn0= |
| visitor-hmac | b01f6f35dfb777621ea62e2512f2b0aa3126c966ba660fc2aa890bc55f03da12 |
| hovercard-subject-tag | pull_request:3620159027 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/63100/files/612b5554abb1300d6f42b2d7d4a03e356444ee12 |
| twitter:image | https://avatars.githubusercontent.com/u/668050?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/668050?s=400&v=4 |
| og:image:alt | Fixes this flacky test issue: #41286 I think the test is wrong and it should check min >= 0. monitorEventLoopDelay configures the histogram with lowest_discernible_value = 1000 ns. hdr_min() ret... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 309153364422b3c499922d1a2a6404910a58ed8e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width