Title: build: add rust target for macOS cross compiles by richardlau · Pull Request #63015 · nodejs/node · GitHub
Open Graph Title: build: add rust target for macOS cross compiles by richardlau · Pull Request #63015 · nodejs/node
X Title: build: add rust target for macOS cross compiles by richardlau · Pull Request #63015 · nodejs/node
Description: When we build the macOS pkg, we build Node.js twice (on arm64): Once for arm64 (native) Once for x64, using a combination of Rosetta 2 and compiler flags before combining both into a universal binary. For the x64 case, pass target flag to rustc so that the binary is built for the correct target architecture. This is a "blind" attempt to address pkg build failures in the Node.js release CI -- I'm not a macOS user, nor do I have access to a macOS environment outside of the Node.js CI, so opening as a draft to test out. It's quite possible that even if this is the "correct" fix, we'll need x64 rustc libraries installed on the release macOS VMs (CI run will indicate).
Open Graph Description: When we build the macOS pkg, we build Node.js twice (on arm64): Once for arm64 (native) Once for x64, using a combination of Rosetta 2 and compiler flags before combining both into a universal bi...
X Description: When we build the macOS pkg, we build Node.js twice (on arm64): Once for arm64 (native) Once for x64, using a combination of Rosetta 2 and compiler flags before combining both into a universal bi...
Opengraph URL: https://github.com/nodejs/node/pull/63015
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:33a7b662-c7ce-5eac-5670-35ac929397f6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 91A0:316D26:1F4DF10:2D2A186:6A4D028F |
| html-safe-nonce | 40886fd7f8b4d0d23314be13830d1f6ee1947f07dcb8dd254c2e962012e45fb6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUEwOjMxNkQyNjoxRjRERjEwOjJEMkExODY6NkE0RDAyOEYiLCJ2aXNpdG9yX2lkIjoiNzYwNjUwMDYxNTAzNTk1MTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2dcce5c0c52e306e8f390b72be599da52f2bc2c8f30e3e44103366ca5315445b |
| hovercard-subject-tag | pull_request:3597704820 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/63015/files |
| twitter:image | https://avatars.githubusercontent.com/u/5445507?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5445507?s=400&v=4 |
| og:image:alt | When we build the macOS pkg, we build Node.js twice (on arm64): Once for arm64 (native) Once for x64, using a combination of Rosetta 2 and compiler flags before combining both into a universal bi... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 31e4db13a9e20081f2fac78f441659a6576e582bbb15e153f9c7fb6473aa29f5 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fb70bd3c4b2bec429781b65419e912c66e2d5581 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width