René's URL Explorer Experiment


Title: stream: fix Writable.toWeb() desiredSize for non-object-mode by mcollina · Pull Request #62986 · nodejs/node · GitHub

Open Graph Title: stream: fix Writable.toWeb() desiredSize for non-object-mode by mcollina · Pull Request #62986 · nodejs/node

X Title: stream: fix Writable.toWeb() desiredSize for non-object-mode by mcollina · Pull Request #62986 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Writable.toWeb() used a plain { highWaterMark } as the queuing strategy for non-object-mode streams, which meant no size function was provided. The WritableStream defaulted to counting each chunk a...

X Description: Writable.toWeb() used a plain { highWaterMark } as the queuing strategy for non-object-mode streams, which meant no size function was provided. The WritableStream defaulted to counting each chunk a...

Opengraph URL: https://github.com/nodejs/node/pull/62986

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1b54f785-79d1-0788-d766-5ad85cec8945
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCB54:237528:62CA54:856DF6:6A4C7D29
html-safe-nonce6446cc886f1505d252c1e162a384b5d959d3f81d2fe62bd3e2ec7bb00aa75ade
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjU0OjIzNzUyODo2MkNBNTQ6ODU2REY2OjZBNEM3RDI5IiwidmlzaXRvcl9pZCI6Ijg4NjMwMTU4MDQyMzgzMzExNzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca957bf82b6c5b976b1512a5bc0081751947659a5979a2e8df881a8ede46679b1
hovercard-subject-tagpull_request:3589014252
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/62986/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/31ff5f309635833647440cf1bcf26f79054301f7c09459a4be1a57eb835ce2cf/nodejs/node/pull/62986
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/31ff5f309635833647440cf1bcf26f79054301f7c09459a4be1a57eb835ce2cf/nodejs/node/pull/62986
og:image:altWritable.toWeb() used a plain { highWaterMark } as the queuing strategy for non-object-mode streams, which meant no size function was provided. The WritableStream defaulted to counting each chunk a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemcollina
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecd470457e909b9d062f8002cf438ba870e6acff6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/62986#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62986
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62986
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/62986
Reloadhttps://github.com/nodejs/node/pull/62986
Reloadhttps://github.com/nodejs/node/pull/62986
Please reload this pagehttps://github.com/nodejs/node/pull/62986
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/62986
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
mcollina:fix-writable-toweb-desiredsizehttps://github.com/mcollina/node/tree/fix-writable-toweb-desiredsize
Conversationhttps://github.com/nodejs/node/pull/62986
Commits1 (1)https://github.com/nodejs/node/pull/62986/commits
Checkshttps://github.com/nodejs/node/pull/62986/checks
Files changedhttps://github.com/nodejs/node/pull/62986/files
stream: fix Writable.toWeb() desiredSize for non-object-modehttps://github.com/nodejs/node/pull/62986#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
mcollina:fix-writable-toweb-desiredsizehttps://github.com/mcollina/node/tree/fix-writable-toweb-desiredsize
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Apr 27, 2026https://github.com/nodejs/node/pull/62986#issue-4335007423
#56269https://github.com/nodejs/node/issues/56269
Please reload this pagehttps://github.com/nodejs/node/pull/62986
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
web streams https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22web%20streams%22
Apr 27, 2026https://github.com/nodejs/node/pull/62986#event-24901195998
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Apr 27, 2026https://github.com/nodejs/node/pull/62986#issuecomment-4326791074
Please reload this pagehttps://github.com/nodejs/node/pull/62986
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/62986?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
74ccf38https://app.codecov.io/gh/nodejs/node/commit/74ccf384a9bd1cd1aba5e95fd829dca9356a2083?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
088b5e2https://app.codecov.io/gh/nodejs/node/commit/088b5e2c6863d3821f606217333100bf2dd68cf3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/62986?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/webstreams/adapters.jshttps://app.codecov.io/gh/nodejs/node/pull/62986?src=pr&el=tree&filepath=lib%2Finternal%2Fwebstreams%2Fadapters.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3dlYnN0cmVhbXMvYWRhcHRlcnMuanM=
35 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/62986/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/62986
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Apr 27, 2026https://github.com/nodejs/node/pull/62986#issuecomment-4327770754
Please reload this pagehttps://github.com/nodejs/node/pull/62986
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Apr 27, 2026 https://github.com/nodejs/node/pull/62986#pullrequestreview-4181707951
View reviewed changes https://github.com/nodejs/node/pull/62986/files/088b5e2c6863d3821f606217333100bf2dd68cf3
https://github.com/mcollina
stream: fix Writable.toWeb() desiredSize for non-object-modehttps://github.com/nodejs/node/pull/62986/commits/088b5e2c6863d3821f606217333100bf2dd68cf3
088b5e2https://github.com/nodejs/node/pull/62986/commits/088b5e2c6863d3821f606217333100bf2dd68cf3
nodejs#56269https://github.com/nodejs/node/issues/56269
https://github.com/mcollina
mcollinahttps://github.com/mcollina
force-pushedhttps://github.com/nodejs/node/compare/33b3fe0c586eeadc9d95fb87558c8a9365a809b5..088b5e2c6863d3821f606217333100bf2dd68cf3
33b3fe0https://github.com/nodejs/node/commit/33b3fe0c586eeadc9d95fb87558c8a9365a809b5
088b5e2https://github.com/nodejs/node/commit/088b5e2c6863d3821f606217333100bf2dd68cf3
Compare https://github.com/nodejs/node/compare/33b3fe0c586eeadc9d95fb87558c8a9365a809b5..088b5e2c6863d3821f606217333100bf2dd68cf3
May 24, 2026 12:45https://github.com/nodejs/node/pull/62986#event-25898804979
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 28, 2026https://github.com/nodejs/node/pull/62986#event-26047576668
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 28, 2026https://github.com/nodejs/node/pull/62986#event-26049012889
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62986
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 21, 2026https://github.com/nodejs/node/pull/62986#issuecomment-4762976478
https://ci.nodejs.org/job/node-test-pull-request/74338/https://ci.nodejs.org/job/node-test-pull-request/74338/
Please reload this pagehttps://github.com/nodejs/node/pull/62986
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 21, 2026https://github.com/nodejs/node/pull/62986#event-27015372699
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jun 21, 2026 https://github.com/nodejs/node/pull/62986#pullrequestreview-4540254912
View reviewed changes https://github.com/nodejs/node/pull/62986/files/088b5e2c6863d3821f606217333100bf2dd68cf3
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 21, 2026https://github.com/nodejs/node/pull/62986#event-27015899202
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 21, 2026https://github.com/nodejs/node/pull/62986#event-27016309153
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
ca406b2https://github.com/nodejs/node/commit/ca406b2b9a2f15fb5c013ca2ac4342878dacbe64
Jun 21, 2026https://github.com/nodejs/node/pull/62986#event-27016338960
Please reload this pagehttps://github.com/nodejs/node/pull/62986
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 21, 2026https://github.com/nodejs/node/pull/62986#issuecomment-4763408883
ca406b2https://github.com/nodejs/node/commit/ca406b2b9a2f15fb5c013ca2ac4342878dacbe64
Please reload this pagehttps://github.com/nodejs/node/pull/62986
aduh95https://github.com/aduh95
Jun 22, 2026 https://github.com/nodejs/node/pull/62986#ref-commit-cc29696
https://github.com/mcollina
https://github.com/aduh95
stream: fix Writable.toWeb() desiredSize for non-object-modehttps://github.com/nodejs/node/commit/cc29696acfee5968fa4e948a21ab153707c537e7
cc29696https://github.com/nodejs/node/commit/cc29696acfee5968fa4e948a21ab153707c537e7
#56269https://github.com/nodejs/node/issues/56269
#62986https://github.com/nodejs/node/pull/62986
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 22, 2026 https://github.com/nodejs/node/pull/62986#ref-pullrequest-4714405542
2026-06-23, Version 26.4.0 (Current) #64058 https://github.com/nodejs/node/pull/64058
luanmunizhttps://github.com/luanmuniz
Jun 25, 2026 https://github.com/nodejs/node/pull/62986#ref-commit-01491b0
https://github.com/mcollina
https://github.com/luanmuniz
stream: fix Writable.toWeb() desiredSize for non-object-modehttps://github.com/luanmuniz/node/commit/01491b09710b473be689bc79426f2a1843b9057e
01491b0https://github.com/luanmuniz/node/commit/01491b09710b473be689bc79426f2a1843b9057e
nodejs#56269https://github.com/nodejs/node/issues/56269
nodejs#62986https://github.com/nodejs/node/pull/62986
aduh95https://github.com/aduh95
Jun 25, 2026 https://github.com/nodejs/node/pull/62986#ref-commit-8276033
https://github.com/mcollina
https://github.com/aduh95
stream: fix Writable.toWeb() desiredSize for non-object-modehttps://github.com/nodejs/node/commit/82760330ed69bce1ab1b2742ffe9bbe5ea76c9d2
8276033https://github.com/nodejs/node/commit/82760330ed69bce1ab1b2742ffe9bbe5ea76c9d2
#56269https://github.com/nodejs/node/issues/56269
#62986https://github.com/nodejs/node/pull/62986
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62986
https://github.com/Renegade334
Renegade334 https://github.com/Renegade334
https://github.com/nodejs/node/pull/62986/files/088b5e2c6863d3821f606217333100bf2dd68cf3
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/62986/files/088b5e2c6863d3821f606217333100bf2dd68cf3
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
web streams https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22web%20streams%22
The desiredSize of Writable.toWeb() is incorrect https://github.com/nodejs/node/issues/56269
Please reload this pagehttps://github.com/nodejs/node/pull/62986
https://github.com/mcollina
https://github.com/Renegade334
https://github.com/nodejs-github-bot
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.