René's URL Explorer Experiment


Title: crypto: evict getCiphers/getHashes cache on setFips/setEngine by srikanth-karthi · Pull Request #62985 · nodejs/node · GitHub

Open Graph Title: crypto: evict getCiphers/getHashes cache on setFips/setEngine by srikanth-karthi · Pull Request #62985 · nodejs/node

X Title: crypto: evict getCiphers/getHashes cache on setFips/setEngine by srikanth-karthi · Pull Request #62985 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #62982 Summary getCiphers() and getHashes() used cachedResult() which memoizes on first call and never clears. Two operations mutate the OpenSSL algorithm set but did not invalidate the cach...

X Description: Fixes: #62982 Summary getCiphers() and getHashes() used cachedResult() which memoizes on first call and never clears. Two operations mutate the OpenSSL algorithm set but did not invalidate the cach...

Opengraph URL: https://github.com/nodejs/node/pull/62985

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0f1ba0d0-689b-4734-b5e3-3757ea3235b0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8708:10B16D:8EBE94:BDE596:6AED2C68
html-safe-nonce0b400aa79568c305e37163e41f4efd3669fea224353689fd6a13a1ecaa1d93f5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzA4OjEwQjE2RDo4RUJFOTQ6QkRFNTk2OjZBRUQyQzY4IiwidmlzaXRvcl9pZCI6IjQ1MDYyMzUxNjYwOTE2MjM0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace230bd3a7a421c8e6cfbc33b5e835681620d9f041f99fae571ac688314171b7d
hovercard-subject-tagpull_request:3588808858
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/62985/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6dbc51f3a4d86c6452e740397cf90ee3407f9fa9d4aa0830cdf186b3f915da48/nodejs/node/pull/62985
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6dbc51f3a4d86c6452e740397cf90ee3407f9fa9d4aa0830cdf186b3f915da48/nodejs/node/pull/62985
og:image:altFixes: #62982 Summary getCiphers() and getHashes() used cachedResult() which memoizes on first call and never clears. Two operations mutate the OpenSSL algorithm set but did not invalidate the cach...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesrikanth-karthi
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/62985#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62985
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62985
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/62985
Reloadhttps://github.com/nodejs/node/pull/62985
Reloadhttps://github.com/nodejs/node/pull/62985
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
srikanth-karthihttps://github.com/srikanth-karthi
nodejs:mainhttps://github.com/nodejs/node/tree/main
srikanth-karthi:fix-cipher-hash-cache-evictionhttps://github.com/srikanth-karthi/node/tree/fix-cipher-hash-cache-eviction
Conversationhttps://github.com/nodejs/node/pull/62985
Commits4 (4)https://github.com/nodejs/node/pull/62985/commits
Checkshttps://github.com/nodejs/node/pull/62985/checks
Files changedhttps://github.com/nodejs/node/pull/62985/files
crypto: evict getCiphers/getHashes cache on setFips/setEnginehttps://github.com/nodejs/node/pull/62985#top
srikanth-karthihttps://github.com/srikanth-karthi
nodejs:mainhttps://github.com/nodejs/node/tree/main
srikanth-karthi:fix-cipher-hash-cache-evictionhttps://github.com/srikanth-karthi/node/tree/fix-cipher-hash-cache-eviction
https://github.com/srikanth-karthi
srikanth-karthihttps://github.com/srikanth-karthi
Apr 27, 2026https://github.com/nodejs/node/pull/62985#issue-4334766637
Please reload this pagehttps://github.com/nodejs/node/pull/62985
#62982https://github.com/nodejs/node/issues/62982
Please reload this pagehttps://github.com/nodejs/node/pull/62985
https://github.com/srikanth-karthi
crypto: evict getCiphers/getHashes cache on setFips/setEnginehttps://github.com/nodejs/node/pull/62985/commits/1fd83ac251c6c7646f9b4dd5c1ddbed144cffb59
1fd83achttps://github.com/nodejs/node/pull/62985/commits/1fd83ac251c6c7646f9b4dd5c1ddbed144cffb59
nodejs#62982https://github.com/nodejs/node/issues/62982
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 27, 2026https://github.com/nodejs/node/pull/62985#issuecomment-4325921002
Please reload this pagehttps://github.com/nodejs/node/pull/62985
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Apr 27, 2026https://github.com/nodejs/node/pull/62985#event-24899855751
https://github.com/panva
panvahttps://github.com/panva
Apr 27, 2026https://github.com/nodejs/node/pull/62985#issuecomment-4325936056
Please reload this pagehttps://github.com/nodejs/node/pull/62985
@srikanth-karthihttps://github.com/srikanth-karthi
Please reload this pagehttps://github.com/nodejs/node/pull/62985
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Apr 27, 2026https://github.com/nodejs/node/pull/62985#issuecomment-4326141292
Please reload this pagehttps://github.com/nodejs/node/pull/62985
#62982https://github.com/nodejs/node/issues/62982
node/lib/internal/crypto/util.jshttps://github.com/nodejs/node/blob/bb85d2388656fa6910b5104a189432ede4a00d23/lib/internal/crypto/util.js#L405-L410
bb85d23https://github.com/nodejs/node/commit/bb85d2388656fa6910b5104a189432ede4a00d23
Please reload this pagehttps://github.com/nodejs/node/pull/62985
https://github.com/panva
panvahttps://github.com/panva
Apr 27, 2026https://github.com/nodejs/node/pull/62985#issuecomment-4326158496
Please reload this pagehttps://github.com/nodejs/node/pull/62985
Please reload this pagehttps://github.com/nodejs/node/pull/62985
https://github.com/srikanth-karthi
srikanth-karthihttps://github.com/srikanth-karthi
Apr 27, 2026https://github.com/nodejs/node/pull/62985#issuecomment-4326223226
Please reload this pagehttps://github.com/nodejs/node/pull/62985
https://github.com/panva
panvahttps://github.com/panva
Apr 27, 2026 https://github.com/nodejs/node/pull/62985#pullrequestreview-4180144331
View reviewed changes https://github.com/nodejs/node/pull/62985/files
test/parallel/test-crypto-ciphers-hashes-fips-cache.jshttps://github.com/nodejs/node/pull/62985/files#diff-65f1d0eb22af02e17d715506b14dfd78affdeaf8920baef7d1de2f7021a7b234
Please reload this pagehttps://github.com/nodejs/node/pull/62985
https://github.com/panva
panvahttps://github.com/panva
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Apr 27, 2026https://github.com/nodejs/node/pull/62985#event-24901552760
https://github.com/panva
panvahttps://github.com/panva
Apr 27, 2026 https://github.com/nodejs/node/pull/62985#pullrequestreview-4180173922
View reviewed changes https://github.com/nodejs/node/pull/62985/files
test/parallel/test-crypto-ciphers-hashes-fips-cache.jshttps://github.com/nodejs/node/pull/62985/files#diff-65f1d0eb22af02e17d715506b14dfd78affdeaf8920baef7d1de2f7021a7b234
Please reload this pagehttps://github.com/nodejs/node/pull/62985
https://github.com/panva
panvahttps://github.com/panva
Apr 27, 2026https://github.com/nodejs/node/pull/62985#issuecomment-4326362810
@ChALkeRhttps://github.com/ChALkeR
Please reload this pagehttps://github.com/nodejs/node/pull/62985
srikanth-karthihttps://github.com/srikanth-karthi
April 27, 2026 16:26https://github.com/nodejs/node/pull/62985#commits-pushed-7ffbd6d
https://github.com/srikanth-karthi
test: verify getCiphers/getHashes cache evicts on setFipshttps://github.com/nodejs/node/pull/62985/commits/7ffbd6d955da716a3e50777b0d166c7a7460b13e
7ffbd6dhttps://github.com/nodejs/node/pull/62985/commits/7ffbd6d955da716a3e50777b0d166c7a7460b13e
nodejs#62982https://github.com/nodejs/node/issues/62982
https://github.com/srikanth-karthi
test: handle FIPS-on-by-default in cipher/hash cache testhttps://github.com/nodejs/node/pull/62985/commits/cdb03a057c58475a7f5a3d6ffba459325c072bd4
cdb03a0https://github.com/nodejs/node/pull/62985/commits/cdb03a057c58475a7f5a3d6ffba459325c072bd4
https://github.com/srikanth-karthi
test: drop FIPS state restore at end of cipher/hash cache testhttps://github.com/nodejs/node/pull/62985/commits/76e61cbf855017cd3268be9988470c993d47f76a
76e61cbhttps://github.com/nodejs/node/pull/62985/commits/76e61cbf855017cd3268be9988470c993d47f76a
https://github.com/srikanth-karthi
srikanth-karthihttps://github.com/srikanth-karthi
force-pushedhttps://github.com/nodejs/node/compare/967e31fabd87451215b890b29e64f333a2bdff97..76e61cbf855017cd3268be9988470c993d47f76a
967e31fhttps://github.com/nodejs/node/commit/967e31fabd87451215b890b29e64f333a2bdff97
76e61cbhttps://github.com/nodejs/node/commit/76e61cbf855017cd3268be9988470c993d47f76a
Compare https://github.com/nodejs/node/compare/967e31fabd87451215b890b29e64f333a2bdff97..76e61cbf855017cd3268be9988470c993d47f76a
April 27, 2026 10:57https://github.com/nodejs/node/pull/62985#event-24902054194
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Apr 27, 2026https://github.com/nodejs/node/pull/62985#issuecomment-4327256485
Please reload this pagehttps://github.com/nodejs/node/pull/62985
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/62985?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
85ae4cdhttps://app.codecov.io/gh/nodejs/node/commit/85ae4cd8f54cc435ee766ee3123d2a2030a9dbea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
76e61cbhttps://app.codecov.io/gh/nodejs/node/commit/76e61cbf855017cd3268be9988470c993d47f76a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/62985?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/crypto.jshttps://app.codecov.io/gh/nodejs/node/pull/62985?src=pr&el=tree&filepath=lib%2Fcrypto.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2NyeXB0by5qcw==
lib/internal/crypto/util.jshttps://app.codecov.io/gh/nodejs/node/pull/62985?src=pr&el=tree&filepath=lib%2Finternal%2Fcrypto%2Futil.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2NyeXB0by91dGlsLmpz
28 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/62985/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/62985
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 6, 2026https://github.com/nodejs/node/pull/62985#issuecomment-5199414153
Please reload this pagehttps://github.com/nodejs/node/pull/62985
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astale
Aug 6, 2026https://github.com/nodejs/node/pull/62985#event-29042644123
https://github.com/panva
panvahttps://github.com/panva
Aug 23, 2026https://github.com/nodejs/node/pull/62985#issuecomment-5385972477
#65484https://github.com/nodejs/node/pull/65484
#63966https://github.com/nodejs/node/pull/63966
#64777 (comment)https://github.com/nodejs/node/pull/64777#issuecomment-5385490242
Please reload this pagehttps://github.com/nodejs/node/pull/62985
https://github.com/panva
panvahttps://github.com/panva
Aug 23, 2026https://github.com/nodejs/node/pull/62985#event-29871101029
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62985
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/62985/files/1c7d4f74c20954ba670ce62c6a4292637bd0fdca
Please reload this pagehttps://github.com/nodejs/node/pull/62985
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stale https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astale
setFips() / setEngine do not evict ciphers cache https://github.com/nodejs/node/issues/62982
Please reload this pagehttps://github.com/nodejs/node/pull/62985
https://github.com/srikanth-karthi
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/ChALkeR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.