René's URL Explorer Experiment


Title: crypto: validate inputEncoding in Cipher/Decipher update by maruthang · Pull Request #62954 · nodejs/node · GitHub

Open Graph Title: crypto: validate inputEncoding in Cipher/Decipher update by maruthang · Pull Request #62954 · nodejs/node

X Title: crypto: validate inputEncoding in Cipher/Decipher update by maruthang · Pull Request #62954 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Cipher.update(string, badEncoding, ...) and Decipher.update with the same shape silently produced incorrect output: the binding skipped the unrecognized encoding and fell back to a default, giving ...

X Description: Cipher.update(string, badEncoding, ...) and Decipher.update with the same shape silently produced incorrect output: the binding skipped the unrecognized encoding and fell back to a default, giving ...

Opengraph URL: https://github.com/nodejs/node/pull/62954

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:89c277ed-116f-562b-61c3-581ddd435b60
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB48:35D054:4FDBED:678967:6AED25E5
html-safe-nonce4e3eec4bbf51bd57078a7502cd83e9b9f0d386a4c0c3e95b18407b20cc382205
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjQ4OjM1RDA1NDo0RkRCRUQ6Njc4OTY3OjZBRUQyNUU1IiwidmlzaXRvcl9pZCI6Ijg3NTQ0NTE2NzEwOTQ3MzIyNjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc813324df18602cea561c75ffbb84631e7f849a215ace5e66c64e726862c4602
hovercard-subject-tagpull_request:3583376965
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/62954/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/878dee0487771a7f077b4caa8b33982995bfa8116a655e6304818605116a7eb4/nodejs/node/pull/62954
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/878dee0487771a7f077b4caa8b33982995bfa8116a655e6304818605116a7eb4/nodejs/node/pull/62954
og:image:altCipher.update(string, badEncoding, ...) and Decipher.update with the same shape silently produced incorrect output: the binding skipped the unrecognized encoding and fell back to a default, giving ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemaruthang
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/62954#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62954
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62954
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/62954
Reloadhttps://github.com/nodejs/node/pull/62954
Reloadhttps://github.com/nodejs/node/pull/62954
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
maruthanghttps://github.com/maruthang
nodejs:mainhttps://github.com/nodejs/node/tree/main
maruthang:fix-45189-cipher-encoding-validationhttps://github.com/maruthang/node/tree/fix-45189-cipher-encoding-validation
Conversationhttps://github.com/nodejs/node/pull/62954
Commits1 (1)https://github.com/nodejs/node/pull/62954/commits
Checkshttps://github.com/nodejs/node/pull/62954/checks
Files changedhttps://github.com/nodejs/node/pull/62954/files
crypto: validate inputEncoding in Cipher/Decipher updatehttps://github.com/nodejs/node/pull/62954#top
maruthanghttps://github.com/maruthang
nodejs:mainhttps://github.com/nodejs/node/tree/main
maruthang:fix-45189-cipher-encoding-validationhttps://github.com/maruthang/node/tree/fix-45189-cipher-encoding-validation
https://github.com/maruthang
maruthanghttps://github.com/maruthang
Apr 25, 2026https://github.com/nodejs/node/pull/62954#issue-4327968814
#45189https://github.com/nodejs/node/issues/45189
#45990https://github.com/nodejs/node/pull/45990
#45189https://github.com/nodejs/node/issues/45189
#45990https://github.com/nodejs/node/pull/45990
Please reload this pagehttps://github.com/nodejs/node/pull/62954
https://github.com/maruthang
crypto: validate inputEncoding in Cipher/Decipher updatehttps://github.com/nodejs/node/pull/62954/commits/87edd604c0046fbf50743bbbca4a42a65e01502a
87edd60https://github.com/nodejs/node/pull/62954/commits/87edd604c0046fbf50743bbbca4a42a65e01502a
nodejs#45189https://github.com/nodejs/node/issues/45189
nodejs#45990https://github.com/nodejs/node/pull/45990
nodejs#45189https://github.com/nodejs/node/issues/45189
nodejs#45990https://github.com/nodejs/node/pull/45990
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 25, 2026https://github.com/nodejs/node/pull/62954#issuecomment-4319513041
Please reload this pagehttps://github.com/nodejs/node/pull/62954
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Apr 25, 2026https://github.com/nodejs/node/pull/62954#event-24865409414
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Apr 25, 2026https://github.com/nodejs/node/pull/62954#issuecomment-4319700995
Please reload this pagehttps://github.com/nodejs/node/pull/62954
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/62954?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
21436f0https://app.codecov.io/gh/nodejs/node/commit/21436f04057b62b4ad7b3704dad73898c681cd1e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
87edd60https://app.codecov.io/gh/nodejs/node/commit/87edd604c0046fbf50743bbbca4a42a65e01502a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/62954?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/crypto/cipher.jshttps://app.codecov.io/gh/nodejs/node/pull/62954?src=pr&el=tree&filepath=lib%2Finternal%2Fcrypto%2Fcipher.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2NyeXB0by9jaXBoZXIuanM=
518 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/62954/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/62954
https://github.com/panva
panvahttps://github.com/panva
needs-citgm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-citgm
Apr 25, 2026https://github.com/nodejs/node/pull/62954#event-24872325517
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 28, 2026https://github.com/nodejs/node/pull/62954#issuecomment-5098307882
Please reload this pagehttps://github.com/nodejs/node/pull/62954
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astale
Jul 28, 2026https://github.com/nodejs/node/pull/62954#event-28569317454
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 27, 2026https://github.com/nodejs/node/pull/62954#issuecomment-5433683546
Please reload this pagehttps://github.com/nodejs/node/pull/62954
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 27, 2026https://github.com/nodejs/node/pull/62954#event-30079299162
https://github.com/panva
panvahttps://github.com/panva
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Sep 23, 2026https://github.com/nodejs/node/pull/62954#event-31693170764
https://github.com/panva
panvahttps://github.com/panva
Sep 23, 2026https://github.com/nodejs/node/pull/62954#event-31693172610
https://github.com/panva
panvahttps://github.com/panva
Sep 23, 2026https://github.com/nodejs/node/pull/62954#issuecomment-5799179594
#66247https://github.com/nodejs/node/pull/66247
Please reload this pagehttps://github.com/nodejs/node/pull/62954
https://github.com/panva
panvahttps://github.com/panva
Sep 23, 2026https://github.com/nodejs/node/pull/62954#event-31694282176
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62954
Please reload this pagehttps://github.com/nodejs/node/pull/62954
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
needs-citgm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-citgm
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stale https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astale
crypto Cipher/Decipher validation issues https://github.com/nodejs/node/issues/45189
Please reload this pagehttps://github.com/nodejs/node/pull/62954
https://github.com/maruthang
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.