René's URL Explorer Experiment


Title: fs: fix glob early return skipping sibling entries by semimikoh · Pull Request #62901 · nodejs/node · GitHub

Open Graph Title: fs: fix glob early return skipping sibling entries by semimikoh · Pull Request #62901 · nodejs/node

X Title: fs: fix glob early return skipping sibling entries by semimikoh · Pull Request #62901 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Summary Remove cache.seen check from children iteration loop in #addSubpatterns (sync) and #iterateSubpatterns (async) The return inside the loop exits the entire method, skipping all remaining si...

X Description: Summary Remove cache.seen check from children iteration loop in #addSubpatterns (sync) and #iterateSubpatterns (async) The return inside the loop exits the entire method, skipping all remaining si...

Opengraph URL: https://github.com/nodejs/node/pull/62901

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8018e439-77aa-517c-a8bd-c8ab2ca6c19f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id850A:3159C:154B64:1C166B:6AED153A
html-safe-noncec16420b423f37f6fa39e847409f18ba5947f6339dec9c283d9b193b443a3d867
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTBBOjMxNTlDOjE1NEI2NDoxQzE2NkI6NkFFRDE1M0EiLCJ2aXNpdG9yX2lkIjoiNjUyMzQwOTM3NzQ4MTkwNTIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd18ace2d5e14b329dcc1e0df7c670cd0fb05d56245040d6e9604a47e8d90d687
hovercard-subject-tagpull_request:3570111755
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/62901/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b9c0c3cffb9fdb86048f7b568beeba1d3217cd95fea5be9cb3463b9a98eb27e8/nodejs/node/pull/62901
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b9c0c3cffb9fdb86048f7b568beeba1d3217cd95fea5be9cb3463b9a98eb27e8/nodejs/node/pull/62901
og:image:altSummary Remove cache.seen check from children iteration loop in #addSubpatterns (sync) and #iterateSubpatterns (async) The return inside the loop exits the entire method, skipping all remaining si...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesemimikoh
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/62901#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62901
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62901
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/62901
Reloadhttps://github.com/nodejs/node/pull/62901
Reloadhttps://github.com/nodejs/node/pull/62901
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
semimikohhttps://github.com/semimikoh
nodejs:mainhttps://github.com/nodejs/node/tree/main
semimikoh:fix-glob-seen-returnhttps://github.com/semimikoh/node/tree/fix-glob-seen-return
Conversationhttps://github.com/nodejs/node/pull/62901
Commits1 (1)https://github.com/nodejs/node/pull/62901/commits
Checkshttps://github.com/nodejs/node/pull/62901/checks
Files changedhttps://github.com/nodejs/node/pull/62901/files
fs: fix glob early return skipping sibling entrieshttps://github.com/nodejs/node/pull/62901#top
semimikohhttps://github.com/semimikoh
nodejs:mainhttps://github.com/nodejs/node/tree/main
semimikoh:fix-glob-seen-returnhttps://github.com/semimikoh/node/tree/fix-glob-seen-return
https://github.com/semimikoh
semimikohhttps://github.com/semimikoh
Apr 22, 2026https://github.com/nodejs/node/pull/62901#issue-4312428601
#62897https://github.com/nodejs/node/issues/62897
Please reload this pagehttps://github.com/nodejs/node/pull/62901
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Apr 22, 2026https://github.com/nodejs/node/pull/62901#event-24775406172
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Apr 23, 2026https://github.com/nodejs/node/pull/62901#issuecomment-4301014482
Please reload this pagehttps://github.com/nodejs/node/pull/62901
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/62901?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
d080801https://app.codecov.io/gh/nodejs/node/commit/d080801b01cf50713d7268fac1583a2d7fb398c9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
4f3a919https://app.codecov.io/gh/nodejs/node/commit/4f3a9199587545a80d275e37ccfde79e6dd05530?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/62901?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/fs/glob.jshttps://app.codecov.io/gh/nodejs/node/pull/62901?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fglob.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL2dsb2IuanM=
496 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/62901/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/62901
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Apr 23, 2026 https://github.com/nodejs/node/pull/62901#pullrequestreview-4160595809
View reviewed changes https://github.com/nodejs/node/pull/62901/files/4f3a9199587545a80d275e37ccfde79e6dd05530
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Apr 23, 2026https://github.com/nodejs/node/pull/62901#event-24786752111
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Apr 23, 2026https://github.com/nodejs/node/pull/62901#event-24787273576
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 23, 2026https://github.com/nodejs/node/pull/62901#issuecomment-4302767614
https://ci.nodejs.org/job/node-test-pull-request/72881/https://ci.nodejs.org/job/node-test-pull-request/72881/
Please reload this pagehttps://github.com/nodejs/node/pull/62901
https://github.com/bartlomieju
bartlomiejuhttps://github.com/bartlomieju
Apr 23, 2026 https://github.com/nodejs/node/pull/62901#ref-issue-4311486665
fs.glob: return in cache-seen check aborts sibling processing, makes test-fs-glob.mjs flaky #62897 https://github.com/nodejs/node/issues/62897
https://github.com/semimikoh
semimikohhttps://github.com/semimikoh
force-pushedhttps://github.com/nodejs/node/compare/cde04e422ce149dca4900c144df435501d45a73d..91565af6e02f6493c77c0ea04c28b0352306daa3
cde04e4https://github.com/nodejs/node/commit/cde04e422ce149dca4900c144df435501d45a73d
91565afhttps://github.com/nodejs/node/commit/91565af6e02f6493c77c0ea04c28b0352306daa3
Compare https://github.com/nodejs/node/compare/cde04e422ce149dca4900c144df435501d45a73d..91565af6e02f6493c77c0ea04c28b0352306daa3
April 30, 2026 18:04https://github.com/nodejs/node/pull/62901#event-25046370002
https://github.com/semimikoh
fs: fix glob early return skipping sibling entrieshttps://github.com/nodejs/node/pull/62901/commits/4f3a9199587545a80d275e37ccfde79e6dd05530
4f3a919https://github.com/nodejs/node/pull/62901/commits/4f3a9199587545a80d275e37ccfde79e6dd05530
https://github.com/semimikoh
semimikohhttps://github.com/semimikoh
force-pushedhttps://github.com/nodejs/node/compare/91565af6e02f6493c77c0ea04c28b0352306daa3..4f3a9199587545a80d275e37ccfde79e6dd05530
91565afhttps://github.com/nodejs/node/commit/91565af6e02f6493c77c0ea04c28b0352306daa3
4f3a919https://github.com/nodejs/node/commit/4f3a9199587545a80d275e37ccfde79e6dd05530
Compare https://github.com/nodejs/node/compare/91565af6e02f6493c77c0ea04c28b0352306daa3..4f3a9199587545a80d275e37ccfde79e6dd05530
April 30, 2026 18:35https://github.com/nodejs/node/pull/62901#event-25047699135
https://github.com/semimikoh
semimikohhttps://github.com/semimikoh
Jun 5, 2026https://github.com/nodejs/node/pull/62901#issuecomment-4627019542
@ZYSzyshttps://github.com/ZYSzys
Please reload this pagehttps://github.com/nodejs/node/pull/62901
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 9, 2026https://github.com/nodejs/node/pull/62901#event-26503604261
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 9, 2026https://github.com/nodejs/node/pull/62901#event-26505411424
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 9, 2026https://github.com/nodejs/node/pull/62901#issuecomment-4656287248
https://github.com/nodejs/node/actions/runs/27184867612https://github.com/nodejs/node/actions/runs/27184867612
Please reload this pagehttps://github.com/nodejs/node/pull/62901
https://github.com/semimikoh
semimikohhttps://github.com/semimikoh
Jul 9, 2026https://github.com/nodejs/node/pull/62901#issuecomment-4920587256
Please reload this pagehttps://github.com/nodejs/node/pull/62901
@ZYSzyshttps://github.com/ZYSzys
Please reload this pagehttps://github.com/nodejs/node/pull/62901
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
Jul 9, 2026https://github.com/nodejs/node/pull/62901#event-27748724453
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 9, 2026https://github.com/nodejs/node/pull/62901#event-27749416353
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 9, 2026https://github.com/nodejs/node/pull/62901#issuecomment-4921961386
https://github.com/nodejs/node/actions/runs/28997064065https://github.com/nodejs/node/actions/runs/28997064065
Please reload this pagehttps://github.com/nodejs/node/pull/62901
https://github.com/webdevelopersrinu
webdevelopersrinuhttps://github.com/webdevelopersrinu
Jul 11, 2026https://github.com/nodejs/node/pull/62901#issuecomment-4947917553
@semimikohhttps://github.com/semimikoh
Please reload this pagehttps://github.com/nodejs/node/pull/62901
https://github.com/semimikoh
semimikohhttps://github.com/semimikoh
Jul 11, 2026https://github.com/nodejs/node/pull/62901#issuecomment-4947945037
@trivikrhttps://github.com/trivikr
Please reload this pagehttps://github.com/nodejs/node/pull/62901
https://github.com/webdevelopersrinu
webdevelopersrinuhttps://github.com/webdevelopersrinu
Jul 11, 2026https://github.com/nodejs/node/pull/62901#issuecomment-4948016186
@semimikohhttps://github.com/semimikoh
@webdevelopersrinuhttps://github.com/webdevelopersrinu
Please reload this pagehttps://github.com/nodejs/node/pull/62901
https://github.com/webdevelopersrinu
webdevelopersrinuhttps://github.com/webdevelopersrinu
Aug 1, 2026 https://github.com/nodejs/node/pull/62901#ref-pullrequest-5035278877
fs: fix glob early return skipping sibling entries #64895 https://github.com/nodejs/node/pull/64895
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 22, 2026https://github.com/nodejs/node/pull/62901#issuecomment-5382951417
#64895https://github.com/nodejs/node/pull/64895
Please reload this pagehttps://github.com/nodejs/node/pull/62901
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 22, 2026https://github.com/nodejs/node/pull/62901#event-29858661600
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62901
https://github.com/ZYSzys
ZYSzys https://github.com/ZYSzys
https://github.com/nodejs/node/pull/62901/files/4f3a9199587545a80d275e37ccfde79e6dd05530
Please reload this pagehttps://github.com/nodejs/node/pull/62901
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
fs.glob: return in cache-seen check aborts sibling processing, makes test-fs-glob.mjs flaky https://github.com/nodejs/node/issues/62897
Please reload this pagehttps://github.com/nodejs/node/pull/62901
https://github.com/semimikoh
https://github.com/nodejs-github-bot
https://github.com/webdevelopersrinu
https://github.com/trivikr
https://github.com/ZYSzys
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.