Title: stream: reject duplicate nested transferables by daeyeon · Pull Request #62831 · nodejs/node · GitHub
Open Graph Title: stream: reject duplicate nested transferables by daeyeon · Pull Request #62831 · nodejs/node
X Title: stream: reject duplicate nested transferables by daeyeon · Pull Request #62831 · nodejs/node
Description: This fixes structuredClone() transfer-list validation for nested transfer conflicts. // This should fail, matching browser and other JavaScript runtime behavior. const t = new TransformStream(); structuredClone([t, t.readable],{ transfer: [t, t.readable] }); We already reject direct duplicate transfer entries, but validation could depend on transfer-list order when transferring a TransformStream together with one of its members. This could be handled in two ways: reject it when nested transferables create duplicates let serialization fail later with a lock error Nested transferables are currently expanded during validation, so this patch uses option 1. Option 2 would require broader changes to the current transfer design than this fix warrants.
Open Graph Description: This fixes structuredClone() transfer-list validation for nested transfer conflicts. // This should fail, matching browser and other JavaScript runtime behavior. const t = new TransformStream(); st...
X Description: This fixes structuredClone() transfer-list validation for nested transfer conflicts. // This should fail, matching browser and other JavaScript runtime behavior. const t = new TransformStream(); st...
Opengraph URL: https://github.com/nodejs/node/pull/62831
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9ea2f1e7-a559-3b32-8a8a-bef44b019e8d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C874:C2F0E:1663EB0:2083121:6A4CE62E |
| html-safe-nonce | f8a9d24b780637351337bb40d90ef8b81e1b6b96e7640fd4624a286cd912d10d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODc0OkMyRjBFOjE2NjNFQjA6MjA4MzEyMTo2QTRDRTYyRSIsInZpc2l0b3JfaWQiOiI3ODQwNjk3OTQ1Nzk1OTEzMjYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 24d1904a42193e442f5a018cea4ac44ef6887ec8f2213539755ed0e89d16d74a |
| hovercard-subject-tag | pull_request:3551803960 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/62831/files |
| twitter:image | https://avatars.githubusercontent.com/u/6630703?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/6630703?s=400&v=4 |
| og:image:alt | This fixes structuredClone() transfer-list validation for nested transfer conflicts. // This should fail, matching browser and other JavaScript runtime behavior. const t = new TransformStream(); st... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 299b43bca6e02ad35197ffeba30d2466846d5fb02ab96fbced5b5e6cec589fb8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c5a57f04eeb310f57c73fd6d751d957e2ca27ed2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width