Title: test: wait for ok before initial break after restart by inoway46 · Pull Request #62807 · nodejs/node · GitHub
Open Graph Title: test: wait for ok before initial break after restart by inoway46 · Pull Request #62807 · nodejs/node
X Title: test: wait for ok before initial break after restart by inoway46 · Pull Request #62807 · nodejs/node
Description: Follow-up to: #62471 Waiting for Debugger attached. before waitForInitialBreak() reduced one race, but it still was not a strong enough sync point. During reconnect, debug> can be re-displayed before the CLI finishes run()/restart(), and the output can still look like: Debugger attached. debug> ok debug> This change waits for ok before waitForInitialBreak(), so the test only starts waiting for the initial break after the CLI has completed reconnecting. CI logs https://github.com/nodejs/node/actions/runs/24588065778 https://github.com/nodejs/node/actions/runs/24600780762 Testing UNUSUAL="$HOME/dir with \$unusual\"chars?'åß∂ƒ©∆¬…\`" mkdir -p "$UNUSUAL" ln -sfn "$PWD" "$UNUSUAL/node" cd "$UNUSUAL/node" ./tools/test.py -p actions -j1 --repeat 50 parallel/test-debugger-run-after-quit-restart Refs: #61762
Open Graph Description: Follow-up to: #62471 Waiting for Debugger attached. before waitForInitialBreak() reduced one race, but it still was not a strong enough sync point. During reconnect, debug> can be re-displayed b...
X Description: Follow-up to: #62471 Waiting for Debugger attached. before waitForInitialBreak() reduced one race, but it still was not a strong enough sync point. During reconnect, debug> can be re-display...
Opengraph URL: https://github.com/nodejs/node/pull/62807
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c95268bb-06c5-68cb-4dc4-ff348822eb7d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B4F8:150C3:5691E8:75456C:6A4C78F5 |
| html-safe-nonce | fd6ccb9d540c589b6bc83e6d879970096e5d2df740097f97b5aad108748473bd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEY4OjE1MEMzOjU2OTFFODo3NTQ1NkM6NkE0Qzc4RjUiLCJ2aXNpdG9yX2lkIjoiODI5NjYyNzEyODIwMTE0ODY2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 82d3a45168d1ecab09e6ee8a09f5504d931c0ace6fb3adb032ceac640f29a4bc |
| hovercard-subject-tag | pull_request:3550323047 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/62807/files |
| twitter:image | https://avatars.githubusercontent.com/u/65857152?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/65857152?s=400&v=4 |
| og:image:alt | Follow-up to: #62471 Waiting for Debugger attached. before waitForInitialBreak() reduced one race, but it still was not a strong enough sync point. During reconnect, debug> can be re-displayed b... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 56ac743bebb13694b888673bb7257f4b97a4b7fd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width