Title: lib: use js-only implementation of `isDataView()` by Renegade334 · Pull Request #62780 · nodejs/node · GitHub
Open Graph Title: lib: use js-only implementation of `isDataView()` by Renegade334 · Pull Request #62780 · nodejs/node
X Title: lib: use js-only implementation of `isDataView()` by Renegade334 · Pull Request #62780 · nodejs/node
Description: We already implement the TypedArray type check methods in the JS layer, as it's more performant to do it this way than to call into the embedder. We can do the same with DataView – even though it potentially requires two JS calls, it's still more performant than using the V8 API, even when invoking the fast callback in a benchmarking scenario. confidence improvement accuracy (*) (**) (***) util/type-check.js n=1000000 argument='false-object' version='js' type='DataView' *** 22.32 % ±9.54% ±12.72% ±16.63% util/type-check.js n=1000000 argument='false-primitive' version='js' type='DataView' *** 64.16 % ±11.84% ±15.79% ±20.64% util/type-check.js n=1000000 argument='true' version='js' type='DataView' *** 26.70 % ±8.24% ±10.99% ±14.34%
Open Graph Description: We already implement the TypedArray type check methods in the JS layer, as it's more performant to do it this way than to call into the embedder. We can do the same with DataView – even though ...
X Description: We already implement the TypedArray type check methods in the JS layer, as it's more performant to do it this way than to call into the embedder. We can do the same with DataView – even tho...
Opengraph URL: https://github.com/nodejs/node/pull/62780
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:824f0adc-3b2c-c309-0e1a-d6b3961deac0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EC04:2B6FF6:546C0:72937:6A4C6BE1 |
| html-safe-nonce | b7da87fc891ba455f00e46d9cbaaa13997cda442335e58130a51ce735fd02a82 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzA0OjJCNkZGNjo1NDZDMDo3MjkzNzo2QTRDNkJFMSIsInZpc2l0b3JfaWQiOiI2MTc3MDY0MTkwNzE0MDgwMjI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9832956d6450c8659dd587747c0e897f94ef880600e54b4dda6dde4bab1b0cfe |
| hovercard-subject-tag | pull_request:3541476017 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/62780/files |
| twitter:image | https://avatars.githubusercontent.com/u/9092381?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/9092381?s=400&v=4 |
| og:image:alt | We already implement the TypedArray type check methods in the JS layer, as it's more performant to do it this way than to call into the embedder. We can do the same with DataView – even though ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 14099438da5379150f15a2892474c7c7e6c0e55e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width