René's URL Explorer Experiment


Title: fs: validate position argument before length === 0 early return by geeksilva97 · Pull Request #62674 · nodejs/node · GitHub

Open Graph Title: fs: validate position argument before length === 0 early return by geeksilva97 · Pull Request #62674 · nodejs/node

X Title: fs: validate position argument before length === 0 early return by geeksilva97 · Pull Request #62674 · nodejs/node

Description: Move position validation upwards to match documented behavior. Fixes #62638

Open Graph Description: Move position validation upwards to match documented behavior. Fixes #62638

X Description: Move position validation upwards to match documented behavior. Fixes #62638

Opengraph URL: https://github.com/nodejs/node/pull/62674

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7862c470-9791-3538-9f03-7528d67f67a8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85E2:DFFE4:711235:9C9380:6A4C902D
html-safe-nonce5aa8bd4b71601448ac6dbedaffc150bbd54fd756f097018f7bbc462b0b32e496
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUUyOkRGRkU0OjcxMTIzNTo5QzkzODA6NkE0QzkwMkQiLCJ2aXNpdG9yX2lkIjoiNzA5MzI1NDIxOTAyMTE5MzI2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac757a89e066295626e442739e5fa4883af35b20b5e26384884386f124d68cd197
hovercard-subject-tagpull_request:3515050127
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/62674/files
twitter:imagehttps://avatars.githubusercontent.com/u/15680379?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15680379?s=400&v=4
og:image:altMove position validation upwards to match documented behavior. Fixes #62638
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a2dede45637df6b92ddcfe2a557e67d4b5854ae
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/62674/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62674%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62674%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/62674/files
Reloadhttps://github.com/nodejs/node/pull/62674/files
Reloadhttps://github.com/nodejs/node/pull/62674/files
Please reload this pagehttps://github.com/nodejs/node/pull/62674/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/62674/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
geeksilva97:fix-fs-read-synchttps://github.com/geeksilva97/node/tree/fix-fs-read-sync
Conversation 7 https://github.com/nodejs/node/pull/62674
Commits 1 https://github.com/nodejs/node/pull/62674/commits
Checks 63 https://github.com/nodejs/node/pull/62674/checks
Files changed https://github.com/nodejs/node/pull/62674/files
Please reload this pagehttps://github.com/nodejs/node/pull/62674/files
fs: validate position argument before length === 0 early return https://github.com/nodejs/node/pull/62674/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/62674/files
de1c243 fs: validate position argument before length === 0 early return geeksilva97 Apr 10, 2026 https://github.com/nodejs/node/pull/62674/commits/de1c2438a9770572d9ace0251e220fd6155a29a2
Clear filters https://github.com/nodejs/node/pull/62674/files
Please reload this pagehttps://github.com/nodejs/node/pull/62674/files
Please reload this pagehttps://github.com/nodejs/node/pull/62674/files
fs.js https://github.com/nodejs/node/pull/62674/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
promises.js https://github.com/nodejs/node/pull/62674/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
test-fs-read-position-validation.mjs https://github.com/nodejs/node/pull/62674/files#diff-7c2d7519718309779fad8b11c1f7643986a787ecf95c2d1d230d60c6b36c78a0
test-fs-read-promises-position-validation.mjs https://github.com/nodejs/node/pull/62674/files#diff-ea2d57f684d57bb938005a359b6755e0415ef006f07fb2a8b8a6b32ee8362a3f
test-fs-readSync-position-validation.mjs https://github.com/nodejs/node/pull/62674/files#diff-6532889934c7cdbe33f504d2939d74f9105e9797b6183b6e4cd3db4a133d9ce0
lib/fs.jshttps://github.com/nodejs/node/pull/62674/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
View file https://github.com/geeksilva97/node/blob/de1c2438a9770572d9ace0251e220fd6155a29a2/lib/fs.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/62674/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/62674/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
https://github.com/nodejs/node/pull/62674/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
https://github.com/nodejs/node/pull/62674/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
https://github.com/nodejs/node/pull/62674/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
https://github.com/nodejs/node/pull/62674/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
https://github.com/nodejs/node/pull/62674/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
lib/internal/fs/promises.jshttps://github.com/nodejs/node/pull/62674/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
View file https://github.com/geeksilva97/node/blob/de1c2438a9770572d9ace0251e220fd6155a29a2/lib/internal/fs/promises.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/62674/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/62674/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
https://github.com/nodejs/node/pull/62674/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
https://github.com/nodejs/node/pull/62674/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
test/parallel/test-fs-read-position-validation.mjshttps://github.com/nodejs/node/pull/62674/files#diff-7c2d7519718309779fad8b11c1f7643986a787ecf95c2d1d230d60c6b36c78a0
View file https://github.com/geeksilva97/node/blob/de1c2438a9770572d9ace0251e220fd6155a29a2/test/parallel/test-fs-read-position-validation.mjs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/62674/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/62674/files#diff-7c2d7519718309779fad8b11c1f7643986a787ecf95c2d1d230d60c6b36c78a0
test/parallel/test-fs-read-promises-position-validation.mjshttps://github.com/nodejs/node/pull/62674/files#diff-ea2d57f684d57bb938005a359b6755e0415ef006f07fb2a8b8a6b32ee8362a3f
View file https://github.com/geeksilva97/node/blob/de1c2438a9770572d9ace0251e220fd6155a29a2/test/parallel/test-fs-read-promises-position-validation.mjs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/62674/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/62674/files#diff-ea2d57f684d57bb938005a359b6755e0415ef006f07fb2a8b8a6b32ee8362a3f
test/parallel/test-fs-readSync-position-validation.mjshttps://github.com/nodejs/node/pull/62674/files#diff-6532889934c7cdbe33f504d2939d74f9105e9797b6183b6e4cd3db4a133d9ce0
View file https://github.com/geeksilva97/node/blob/de1c2438a9770572d9ace0251e220fd6155a29a2/test/parallel/test-fs-readSync-position-validation.mjs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/62674/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/62674/files#diff-6532889934c7cdbe33f504d2939d74f9105e9797b6183b6e4cd3db4a133d9ce0
Please reload this pagehttps://github.com/nodejs/node/pull/62674/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.