René's URL Explorer Experiment


Title: sqlite: keep source database alive during backup by mcollina · Pull Request #62673 · nodejs/node · GitHub

Open Graph Title: sqlite: keep source database alive during backup by mcollina · Pull Request #62673 · nodejs/node

X Title: sqlite: keep source database alive during backup by mcollina · Pull Request #62673 · nodejs/node

Description: BackupJob held a raw DatabaseSync* to the source. If the source lost its last JS reference during an in-flight backup(), GC could destroy it while the job was still pending, and Finalize() would later dereference a dangling pointer via source_->RemoveBackup(this). Switch BackupJob::source_ to BaseObjectPtr so the source stays alive for the lifetime of the job, and delete the job at its terminal states (previously leaked).

Open Graph Description: BackupJob held a raw DatabaseSync* to the source. If the source lost its last JS reference during an in-flight backup(), GC could destroy it while the job was still pending, and Finalize() would la...

X Description: BackupJob held a raw DatabaseSync* to the source. If the source lost its last JS reference during an in-flight backup(), GC could destroy it while the job was still pending, and Finalize() would la...

Opengraph URL: https://github.com/nodejs/node/pull/62673

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0ed9cfb8-d96a-4a1e-661a-b7040b850ec6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD434:223EF0:C3DA4D:11AD7EE:6A4CC2C5
html-safe-noncefd670578b3f7481e59797c0cee6d16da53fb2a8ae73a073d83f6056090a30d2d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDM0OjIyM0VGMDpDM0RBNEQ6MTFBRDdFRTo2QTRDQzJDNSIsInZpc2l0b3JfaWQiOiIzNDQzNTg3MzU5NjA1MzEwMTQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccb36bb05bbafbdad889c1519eb17fa45d181e439a849f824597aecb5f96cc175
hovercard-subject-tagpull_request:3515019548
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/62673/files
twitter:imagehttps://avatars.githubusercontent.com/u/52195?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/52195?s=400&v=4
og:image:altBackupJob held a raw DatabaseSync* to the source. If the source lost its last JS reference during an in-flight backup(), GC could destroy it while the job was still pending, and Finalize() would la...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec03e7e569190bc89b638cdd4acb4b6c6b38a170a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/62673/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62673%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62673%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/62673/files
Reloadhttps://github.com/nodejs/node/pull/62673/files
Reloadhttps://github.com/nodejs/node/pull/62673/files
Please reload this pagehttps://github.com/nodejs/node/pull/62673/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/62673/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
mcollina:fix-sqlite-backup-uafhttps://github.com/mcollina/node/tree/fix-sqlite-backup-uaf
Conversation 15 https://github.com/nodejs/node/pull/62673
Commits 1 https://github.com/nodejs/node/pull/62673/commits
Checks 40 https://github.com/nodejs/node/pull/62673/checks
Files changed 2 https://github.com/nodejs/node/pull/62673/files
sqlite: keep source database alive during backup https://github.com/nodejs/node/pull/62673/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/62673/files
4c42f91 sqlite: keep source database alive during backup mcollina Apr 10, 2026 https://github.com/nodejs/node/pull/62673/commits/4c42f9186414f3697bbc1a069e6b702f6c9c56a1
Clear filters https://github.com/nodejs/node/pull/62673/files
Please reload this pagehttps://github.com/nodejs/node/pull/62673/files
Please reload this pagehttps://github.com/nodejs/node/pull/62673/files
node_sqlite.cc https://github.com/nodejs/node/pull/62673/files#diff-dd810db4fe69364c3a67a274e0725f386040c0fd1dcfade7093f23c8514328ae
test-sqlite-backup.mjs https://github.com/nodejs/node/pull/62673/files#diff-650497aa77b77060ce01fdcae439e50d897d5cdb8fffd97ed71b6c5121c45372
src/node_sqlite.cchttps://github.com/nodejs/node/pull/62673/files#diff-dd810db4fe69364c3a67a274e0725f386040c0fd1dcfade7093f23c8514328ae
View file https://github.com/mcollina/node/blob/4c42f9186414f3697bbc1a069e6b702f6c9c56a1/src/node_sqlite.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/62673/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/62673/files#diff-dd810db4fe69364c3a67a274e0725f386040c0fd1dcfade7093f23c8514328ae
https://github.com/nodejs/node/pull/62673/files#diff-dd810db4fe69364c3a67a274e0725f386040c0fd1dcfade7093f23c8514328ae
https://github.com/nodejs/node/pull/62673/files#diff-dd810db4fe69364c3a67a274e0725f386040c0fd1dcfade7093f23c8514328ae
https://github.com/nodejs/node/pull/62673/files#diff-dd810db4fe69364c3a67a274e0725f386040c0fd1dcfade7093f23c8514328ae
test/parallel/test-sqlite-backup.mjshttps://github.com/nodejs/node/pull/62673/files#diff-650497aa77b77060ce01fdcae439e50d897d5cdb8fffd97ed71b6c5121c45372
View file https://github.com/mcollina/node/blob/4c42f9186414f3697bbc1a069e6b702f6c9c56a1/test/parallel/test-sqlite-backup.mjs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/62673/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/62673/files#diff-650497aa77b77060ce01fdcae439e50d897d5cdb8fffd97ed71b6c5121c45372
https://github.com/nodejs/node/pull/62673/files#diff-650497aa77b77060ce01fdcae439e50d897d5cdb8fffd97ed71b6c5121c45372
Please reload this pagehttps://github.com/nodejs/node/pull/62673/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.