René's URL Explorer Experiment


Title: fs: fix always return promise from `fs.openAsBlob` by mattskel · Pull Request #62655 · nodejs/node · GitHub

Open Graph Title: fs: fix always return promise from `fs.openAsBlob` by mattskel · Pull Request #62655 · nodejs/node

X Title: fs: fix always return promise from `fs.openAsBlob` by mattskel · Pull Request #62655 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Summary: Ensure fs.openAsBlob always returns a Promise by converting synchronous validation/creation errors into Promise rejections so error handling is consistent. Motivation: The issue reported t...

X Description: Summary: Ensure fs.openAsBlob always returns a Promise by converting synchronous validation/creation errors into Promise rejections so error handling is consistent. Motivation: The issue reported t...

Opengraph URL: https://github.com/nodejs/node/pull/62655

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7c7c11e8-8cf7-e313-3336-9ac649dccdd0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA01C:2973C7:6606B2:8450B0:6AED2C7C
html-safe-nonce787ee667a9328a792c6ea68dfd304c4c56cb54a68aa49e8af5f43f24a063da25
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDFDOjI5NzNDNzo2NjA2QjI6ODQ1MEIwOjZBRUQyQzdDIiwidmlzaXRvcl9pZCI6Ijc2MTE5MDI3ODMwOTA2NjY2MjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca552bb8f17a7f846d6de92a2767ca5683ff3f8d7d6733b007753eb37c7e2a26c
hovercard-subject-tagpull_request:3509721822
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/62655/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b81ab7c96ff90e224d27e660f09177b3d52a76cd469a7cc1f957670df2be9666/nodejs/node/pull/62655
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b81ab7c96ff90e224d27e660f09177b3d52a76cd469a7cc1f957670df2be9666/nodejs/node/pull/62655
og:image:altSummary: Ensure fs.openAsBlob always returns a Promise by converting synchronous validation/creation errors into Promise rejections so error handling is consistent. Motivation: The issue reported t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemattskel
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/62655#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62655
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62655
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/62655
Reloadhttps://github.com/nodejs/node/pull/62655
Reloadhttps://github.com/nodejs/node/pull/62655
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
mattskelhttps://github.com/mattskel
nodejs:mainhttps://github.com/nodejs/node/tree/main
mattskel:fix-fs-api-promise-based-contracthttps://github.com/mattskel/node/tree/fix-fs-api-promise-based-contract
Conversationhttps://github.com/nodejs/node/pull/62655
Commits3 (3)https://github.com/nodejs/node/pull/62655/commits
Checkshttps://github.com/nodejs/node/pull/62655/checks
Files changedhttps://github.com/nodejs/node/pull/62655/files
fs: fix always return promise from fs.openAsBlobhttps://github.com/nodejs/node/pull/62655#top
mattskelhttps://github.com/mattskel
nodejs:mainhttps://github.com/nodejs/node/tree/main
mattskel:fix-fs-api-promise-based-contracthttps://github.com/mattskel/node/tree/fix-fs-api-promise-based-contract
https://github.com/mattskel
mattskelhttps://github.com/mattskel
Apr 9, 2026https://github.com/nodejs/node/pull/62655#issue-4233656868
#62418https://github.com/nodejs/node/issues/62418
Please reload this pagehttps://github.com/nodejs/node/pull/62655
https://github.com/mattskel
fs: always return promise from openAsBlob()https://github.com/nodejs/node/pull/62655/commits/6a4c236a49f21e9e3d218a24965996a2734ffaa6
6a4c236https://github.com/nodejs/node/pull/62655/commits/6a4c236a49f21e9e3d218a24965996a2734ffaa6
nodejs#62418https://github.com/nodejs/node/issues/62418
https://github.com/mattskel
mattskelhttps://github.com/mattskel
April 9, 2026 16:39https://github.com/nodejs/node/pull/62655#event-24344015235
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Apr 9, 2026https://github.com/nodejs/node/pull/62655#event-24344017094
https://github.com/Slayer95
Slayer95https://github.com/Slayer95
Apr 17, 2026 https://github.com/nodejs/node/pull/62655#pullrequestreview-4132774645
View reviewed changes https://github.com/nodejs/node/pull/62655/files/6a4c236a49f21e9e3d218a24965996a2734ffaa6
lib/fs.jshttps://github.com/nodejs/node/pull/62655/files/6a4c236a49f21e9e3d218a24965996a2734ffaa6#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
Slayer95https://github.com/Slayer95
Apr 17, 2026https://github.com/nodejs/node/pull/62655#discussion_r3103873370
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/62655
mattskelhttps://github.com/mattskel
Apr 20, 2026https://github.com/nodejs/node/pull/62655#discussion_r3111320159
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Slayer95https://github.com/Slayer95
Please reload this pagehttps://github.com/nodejs/node/pull/62655
Slayer95https://github.com/Slayer95
Apr 20, 2026https://github.com/nodejs/node/pull/62655#discussion_r3112238114
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
function coloring ruleshttps://journal.stuffwithstuff.com/2015/02/01/what-color-is-your-function/
Please reload this pagehttps://github.com/nodejs/node/pull/62655
mattskelhttps://github.com/mattskel
Apr 21, 2026https://github.com/nodejs/node/pull/62655#discussion_r3116467281
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/62655
mattskelhttps://github.com/mattskel
April 20, 2026 21:58https://github.com/nodejs/node/pull/62655#commits-pushed-d42280d
https://github.com/mattskel
fs: always return promise form openAsBlob()https://github.com/nodejs/node/pull/62655/commits/d42280de03acb93c2abe7796885fd4a7310f555a
d42280dhttps://github.com/nodejs/node/pull/62655/commits/d42280de03acb93c2abe7796885fd4a7310f555a
https://github.com/mattskel
fs: return promise when error throwshttps://github.com/nodejs/node/pull/62655/commits/08c326a13ff76fd4a8899bf8526e42eedcb4f62d
08c326ahttps://github.com/nodejs/node/pull/62655/commits/08c326a13ff76fd4a8899bf8526e42eedcb4f62d
nodejs#62655 (comment)https://github.com/nodejs/node/pull/62655#discussion_r3112238114
https://github.com/mattskel
mattskelhttps://github.com/mattskel
April 21, 2026 09:35https://github.com/nodejs/node/pull/62655#event-24712008811
https://github.com/mattskel
mattskelhttps://github.com/mattskel
Slayer95https://github.com/Slayer95
April 21, 2026 11:50https://github.com/nodejs/node/pull/62655#event-24716107874
https://github.com/Slayer95
Slayer95https://github.com/Slayer95
Apr 21, 2026https://github.com/nodejs/node/pull/62655#issuecomment-4290078631
Please reload this pagehttps://github.com/nodejs/node/pull/62655
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 28, 2026https://github.com/nodejs/node/pull/62655#issuecomment-5098312191
Please reload this pagehttps://github.com/nodejs/node/pull/62655
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astale
Jul 28, 2026https://github.com/nodejs/node/pull/62655#event-28569338478
https://github.com/jimmywarting
jimmywartinghttps://github.com/jimmywarting
Aug 23, 2026 https://github.com/nodejs/node/pull/62655#pullrequestreview-5002227131
View reviewed changes https://github.com/nodejs/node/pull/62655/files/08c326a13ff76fd4a8899bf8526e42eedcb4f62d
lib/fs.jshttps://github.com/nodejs/node/pull/62655/files/08c326a13ff76fd4a8899bf8526e42eedcb4f62d#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
jimmywartinghttps://github.com/jimmywarting
Aug 23, 2026https://github.com/nodejs/node/pull/62655#discussion_r3838332428
Please reload this pagehttps://github.com/nodejs/node/pull/62655
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/62655
https://github.com/gildas-lormeau
gildas-lormeauhttps://github.com/gildas-lormeau
Aug 24, 2026 https://github.com/nodejs/node/pull/62655#ref-issue-5234804837
fs.openAsBlob reports a missing file as ERR_INVALID_ARG_VALUE, discarding the ENOENT #65514 https://github.com/nodejs/node/issues/65514
https://github.com/bitpshr
bitpshrhttps://github.com/bitpshr
Aug 24, 2026 https://github.com/nodejs/node/pull/62655#ref-pullrequest-5236136052
src: report libuv error when openAsBlob cannot stat #65517 https://github.com/nodejs/node/pull/65517
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 2, 2026https://github.com/nodejs/node/pull/62655#issuecomment-5943932802
Please reload this pagehttps://github.com/nodejs/node/pull/62655
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 2, 2026https://github.com/nodejs/node/pull/62655#event-32301980706
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62655
https://github.com/Slayer95
Slayer95 https://github.com/Slayer95
https://github.com/jimmywarting
jimmywarting https://github.com/jimmywarting
https://github.com/nodejs/node/pull/62655/files/08c326a13ff76fd4a8899bf8526e42eedcb4f62d
Please reload this pagehttps://github.com/nodejs/node/pull/62655
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stale https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astale
openAsBlob fails synchronously https://github.com/nodejs/node/issues/62418
Please reload this pagehttps://github.com/nodejs/node/pull/62655
https://github.com/mattskel
https://github.com/Slayer95
https://github.com/jimmywarting
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.