| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:21b9ea1f-0b88-b430-a605-84b5bcfc2429 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A0A8:B5089:15A27F0:1DEDEB0:6A4EA13B |
| html-safe-nonce | 493e24948bf8e94a58152cd55d36dbd611c5cca56b328e1d66b98ab2568af65f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEE4OkI1MDg5OjE1QTI3RjA6MURFREVCMDo2QTRFQTEzQiIsInZpc2l0b3JfaWQiOiI2MDU1NjgxNjc2MTI1NTc3NTMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 36827b22846b03aaae1eb59fecba2c0f46dc7635154a88a7cac0d374ad55dd53 |
| hovercard-subject-tag | pull_request:3509425781 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/62649/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2bd8fb94ee77d3fd34930331fb2ad737bb0e50ffc1d3e6f480a0433a32b85b2e/nodejs/node/pull/62649 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2bd8fb94ee77d3fd34930331fb2ad737bb0e50ffc1d3e6f480a0433a32b85b2e/nodejs/node/pull/62649 |
| og:image:alt | This is a POC for initial feedback. If we can get alignment within Node.js I could try to contribute the v8 changes upstream.
Summary
Adds the ability to tag sampling heap profiler allocations with... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rudolf |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/62649#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62649 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62649 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/62649 |
| Reload | https://github.com/nodejs/node/pull/62649 |
| Reload | https://github.com/nodejs/node/pull/62649 |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
963
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| rudolf | https://github.com/rudolf |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| rudolf:poc-allocation-profiler-tags-v2 | https://github.com/rudolf/node/tree/poc-allocation-profiler-tags-v2 |
| Conversation | https://github.com/nodejs/node/pull/62649 |
| Commits13 (13) | https://github.com/nodejs/node/pull/62649/commits |
| Checks | https://github.com/nodejs/node/pull/62649/checks |
| Files changed | https://github.com/nodejs/node/pull/62649/files |
| POC: Memory profiler allocation labels | https://github.com/nodejs/node/pull/62649#top |
| rudolf | https://github.com/rudolf |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| rudolf:poc-allocation-profiler-tags-v2 | https://github.com/rudolf/node/tree/poc-allocation-profiler-tags-v2 |
|
| https://github.com/rudolf |
| rudolf | https://github.com/rudolf |
| Apr 9, 2026 | https://github.com/nodejs/node/pull/62649#issue-4233302036 |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| v8-dev | https://www.mail-archive.com/v8-dev@googlegroups.com/msg162591.html |
| #62273 | https://github.com/nodejs/node/pull/62273 |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 9, 2026 | https://github.com/nodejs/node/pull/62649#issuecomment-4215437807 |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Apr 9, 2026 | https://github.com/nodejs/node/pull/62649#event-24341797685 |
| https://github.com/Qard |
| Qard | https://github.com/Qard |
|
Apr 9, 2026
| https://github.com/nodejs/node/pull/62649#pullrequestreview-4084120133 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/62649/files |
| src/node_v8.cc | https://github.com/nodejs/node/pull/62649/files#diff-b31178bc5d9c07672e946e9dc0b52d163fa8e24220f6f4d2157eac2578c7041b |
| Qard | https://github.com/Qard |
| Apr 9, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3059495181 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| https://github.com/rudolf |
| rudolf | https://github.com/rudolf |
| force-pushed | https://github.com/nodejs/node/compare/8743634672f5865fef1e949ba7ab9aa7ec7eaad2..302bebe49e01fca18e53b530179d75ccf2d85a58 |
| 8743634 | https://github.com/nodejs/node/commit/8743634672f5865fef1e949ba7ab9aa7ec7eaad2 |
| 302bebe | https://github.com/nodejs/node/commit/302bebe49e01fca18e53b530179d75ccf2d85a58 |
|
Compare
| https://github.com/nodejs/node/compare/8743634672f5865fef1e949ba7ab9aa7ec7eaad2..302bebe49e01fca18e53b530179d75ccf2d85a58 |
| April 10, 2026 09:22 | https://github.com/nodejs/node/pull/62649#event-24374557063 |
| https://github.com/szegedi |
| szegedi | https://github.com/szegedi |
|
Apr 14, 2026
| https://github.com/nodejs/node/pull/62649#pullrequestreview-4105872271 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/62649/files |
| szegedi | https://github.com/szegedi |
| https://github.com/nodejs/node/pull/62649#pullrequestreview-4105872271 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| deps/v8/src/profiler/sampling-heap-profiler.cc | https://github.com/nodejs/node/pull/62649/files#diff-04546f9aa76742cd21fbd65253774bc4ebb6b31ad054c8a5ff440915a8aa63c2 |
| szegedi | https://github.com/szegedi |
| Apr 14, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3079426513 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| rudolf | https://github.com/rudolf |
| Apr 14, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3080400784 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| src/api/environment.cc | https://github.com/nodejs/node/pull/62649/files#diff-5f2fc380364ef43210af4a28c08f9a0c7ec5f85e3ec1f5c1df5e0204eb9dc721 |
| szegedi | https://github.com/szegedi |
| Apr 14, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3079770395 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| rudolf | https://github.com/rudolf |
| Apr 14, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3080431203 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| deps/v8/include/v8-profiler.h | https://github.com/nodejs/node/pull/62649/files#diff-ca4916d82556914cc3968e968fbfd280f7af9107eb66b589602a38edd956ee6d |
| szegedi | https://github.com/szegedi |
| Apr 14, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3079821880 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| rudolf | https://github.com/rudolf |
| Apr 14, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3080442058 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| https://github.com/rudolf |
| rudolf | https://github.com/rudolf |
|
Apr 14, 2026
| https://github.com/nodejs/node/pull/62649#pullrequestreview-4106962300 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/62649/files |
| rudolf | https://github.com/rudolf |
| https://github.com/nodejs/node/pull/62649#pullrequestreview-4106962300 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @szegedi | https://github.com/szegedi |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| deps/v8/src/profiler/sampling-heap-profiler.cc | https://github.com/nodejs/node/pull/62649/files#diff-04546f9aa76742cd21fbd65253774bc4ebb6b31ad054c8a5ff440915a8aa63c2 |
| rudolf | https://github.com/rudolf |
| Apr 14, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3080400784 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| src/api/environment.cc | https://github.com/nodejs/node/pull/62649/files#diff-5f2fc380364ef43210af4a28c08f9a0c7ec5f85e3ec1f5c1df5e0204eb9dc721 |
| rudolf | https://github.com/rudolf |
| Apr 14, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3080431203 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| deps/v8/include/v8-profiler.h | https://github.com/nodejs/node/pull/62649/files#diff-ca4916d82556914cc3968e968fbfd280f7af9107eb66b589602a38edd956ee6d |
| rudolf | https://github.com/rudolf |
| Apr 14, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3080442058 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| rudolf | https://github.com/rudolf |
| April 15, 2026 16:15 | https://github.com/nodejs/node/pull/62649#commits-pushed-2febdb4 |
|
| https://github.com/rudolf |
| deps: add heap profile sample labels to V8 profiler | https://github.com/nodejs/node/pull/62649/commits/2febdb40d6c8c250115649e359d972b34f399eda |
| 2febdb4 | https://github.com/nodejs/node/pull/62649/commits/2febdb40d6c8c250115649e359d972b34f399eda |
|
| https://github.com/rudolf |
| src: add heap profile labels bindings | https://github.com/nodejs/node/pull/62649/commits/a393276ad934e1bfc79683b1bb4e88c4ddf5d63a |
| a393276 | https://github.com/nodejs/node/pull/62649/commits/a393276ad934e1bfc79683b1bb4e88c4ddf5d63a |
|
| https://github.com/rudolf |
| lib: add heap profile labels API to v8 module | https://github.com/nodejs/node/pull/62649/commits/a8ac88ee7a4293a44a7efa56dd71df2e33656392 |
| a8ac88e | https://github.com/nodejs/node/pull/62649/commits/a8ac88ee7a4293a44a7efa56dd71df2e33656392 |
|
| https://github.com/rudolf |
| test: add heap profile labels tests | https://github.com/nodejs/node/pull/62649/commits/c1934a563c98b7114b1f5f4a031d80cf8708491e |
| c1934a5 | https://github.com/nodejs/node/pull/62649/commits/c1934a563c98b7114b1f5f4a031d80cf8708491e |
|
| https://github.com/rudolf |
| doc: add heap profiler labels API documentation | https://github.com/nodejs/node/pull/62649/commits/0e7004b0720f7c2dfaaeea37cd42cda4b08bfebf |
| 0e7004b | https://github.com/nodejs/node/pull/62649/commits/0e7004b0720f7c2dfaaeea37cd42cda4b08bfebf |
|
| https://github.com/rudolf |
| benchmark: add heap profiler labels overhead benchmarks | https://github.com/nodejs/node/pull/62649/commits/18a6b9093cd1cc6573de2aeee95d7eef1b089749 |
| 18a6b90 | https://github.com/nodejs/node/pull/62649/commits/18a6b9093cd1cc6573de2aeee95d7eef1b089749 |
|
| https://github.com/rudolf |
| deps: add LookupAlsValue to V8 heap profiler | https://github.com/nodejs/node/pull/62649/commits/37180c76d8d244d47f49c37892c8743f02bae9d0 |
| 37180c7 | https://github.com/nodejs/node/pull/62649/commits/37180c76d8d244d47f49c37892c8743f02bae9d0 |
|
| https://github.com/rudolf |
| src: add ProfilingArrayBufferAllocator for external memory tracking | https://github.com/nodejs/node/pull/62649/commits/3e447511df1f8749dddacf1de8d1151ddfa16f31 |
| 3e44751 | https://github.com/nodejs/node/pull/62649/commits/3e447511df1f8749dddacf1de8d1151ddfa16f31 |
|
| https://github.com/rudolf |
| test: add external memory tracking tests | https://github.com/nodejs/node/pull/62649/commits/d5fa37d00e6f2dc16cff7a24d25298d3ec8bd0a7 |
| d5fa37d | https://github.com/nodejs/node/pull/62649/commits/d5fa37d00e6f2dc16cff7a24d25298d3ec8bd0a7 |
|
| https://github.com/rudolf |
| doc: add externalBytes to heap profiler documentation | https://github.com/nodejs/node/pull/62649/commits/da6af2885d48a5ab1d59f4d3ecc52824f332d462 |
| da6af28 | https://github.com/nodejs/node/pull/62649/commits/da6af2885d48a5ab1d59f4d3ecc52824f332d462 |
| https://github.com/rudolf |
| rudolf | https://github.com/rudolf |
| force-pushed | https://github.com/nodejs/node/compare/302bebe49e01fca18e53b530179d75ccf2d85a58..da6af2885d48a5ab1d59f4d3ecc52824f332d462 |
| 302bebe | https://github.com/nodejs/node/commit/302bebe49e01fca18e53b530179d75ccf2d85a58 |
| da6af28 | https://github.com/nodejs/node/commit/da6af2885d48a5ab1d59f4d3ecc52824f332d462 |
|
Compare
| https://github.com/nodejs/node/compare/302bebe49e01fca18e53b530179d75ccf2d85a58..da6af2885d48a5ab1d59f4d3ecc52824f332d462 |
| April 17, 2026 20:12 | https://github.com/nodejs/node/pull/62649#event-24622230358 |
| https://github.com/IlyasShabi |
| IlyasShabi | https://github.com/IlyasShabi |
|
Apr 20, 2026
| https://github.com/nodejs/node/pull/62649#pullrequestreview-4139971083 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/62649/files/da6af2885d48a5ab1d59f4d3ecc52824f332d462 |
| deps/v8/src/profiler/sampling-heap-profiler.h | https://github.com/nodejs/node/pull/62649/files/da6af2885d48a5ab1d59f4d3ecc52824f332d462#diff-65876d398f163f17881039cda58dc9abd4c0d3171bc97b80caca96e18769bbda |
| IlyasShabi | https://github.com/IlyasShabi |
| Apr 20, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3110646647 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| rudolf | https://github.com/rudolf |
| Apr 21, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3117269666 |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| IlyasShabi | https://github.com/IlyasShabi |
| Apr 21, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3117291201 |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| rudolf | https://github.com/rudolf |
| Apr 23, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3132806254 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @IlyasShabi | https://github.com/IlyasShabi |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| rudolf | https://github.com/rudolf |
| Apr 23, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3133654491 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| https://github.com/IlyasShabi |
| IlyasShabi | https://github.com/IlyasShabi |
|
Apr 20, 2026
| https://github.com/nodejs/node/pull/62649#pullrequestreview-4140004428 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/62649/files/da6af2885d48a5ab1d59f4d3ecc52824f332d462 |
| lib/v8.js | https://github.com/nodejs/node/pull/62649/files/da6af2885d48a5ab1d59f4d3ecc52824f332d462#diff-51492e7c14e4e509508448c9a83da28992db583c633fd3be6ba933bbdd7a22c1 |
| IlyasShabi | https://github.com/IlyasShabi |
| Apr 20, 2026 | https://github.com/nodejs/node/pull/62649#discussion_r3110672336 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| https://github.com/szegedi |
| szegedi | https://github.com/szegedi |
| Apr 21, 2026 | https://github.com/nodejs/node/pull/62649#issuecomment-4288268322 |
| @szegedi | https://github.com/szegedi |
| like this | https://github.com/DataDog/pprof-nodejs/blob/main/bindings/profilers/wall.cc#L1261-L1278 |
| reimplementation | https://github.com/DataDog/pprof-nodejs/blob/main/bindings/map-get.cc |
| v8::CpuProfiler::GetSampleTimestamp | https://v8docs.nodesource.com/node-22.4/db/d79/classv8_1_1_cpu_profile.html#aa1a567a411216e7030ac3e96064398ba |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| rudolf | https://github.com/rudolf |
| April 23, 2026 22:15 | https://github.com/nodejs/node/pull/62649#commits-pushed-b24f8d9 |
|
| https://github.com/rudolf |
| benchmark: add getAllocationProfile label resolution benchmark | https://github.com/nodejs/node/pull/62649/commits/b24f8d9d7cb907715e7d01b5dc6a29e32fc476eb |
| b24f8d9 | https://github.com/nodejs/node/pull/62649/commits/b24f8d9d7cb907715e7d01b5dc6a29e32fc476eb |
|
| https://github.com/rudolf |
| src: fix heap profile labels init order and build | https://github.com/nodejs/node/pull/62649/commits/6fb8f121b3bbcbc18a2cff8a1c3d426dab5cae5c |
| 6fb8f12 | https://github.com/nodejs/node/pull/62649/commits/6fb8f121b3bbcbc18a2cff8a1c3d426dab5cae5c |
|
| https://github.com/rudolf |
| deps: cache label resolution in GetAllocationProfile | https://github.com/nodejs/node/pull/62649/commits/a6391ec1e2bb226c3a585e1b5deb52f179ccad6f |
| a6391ec | https://github.com/nodejs/node/pull/62649/commits/a6391ec1e2bb226c3a585e1b5deb52f179ccad6f |
| nodejs#62649 (comment) | https://github.com/nodejs/node/pull/62649#discussion_r3110646647 |
| https://github.com/Qard |
| Qard | https://github.com/Qard |
| Apr 25, 2026 | https://github.com/nodejs/node/pull/62649#issuecomment-4317524531 |
| like this | https://github.com/DataDog/pprof-nodejs/blob/main/bindings/profilers/wall.cc#L1261-L1278 |
| reimplementation | https://github.com/DataDog/pprof-nodejs/blob/main/bindings/map-get.cc |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| https://github.com/szegedi |
| szegedi | https://github.com/szegedi |
| Apr 29, 2026 | https://github.com/nodejs/node/pull/62649#issuecomment-4343533993 |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62649 |
|
| https://github.com/Qard |
|
Qard
| https://github.com/Qard |
|
| https://github.com/nodejs/node/pull/62649/files/8743634672f5865fef1e949ba7ab9aa7ec7eaad2 |
|
| https://github.com/IlyasShabi |
|
IlyasShabi
| https://github.com/IlyasShabi |
|
| https://github.com/nodejs/node/pull/62649/files/da6af2885d48a5ab1d59f4d3ecc52824f332d462 |
|
| https://github.com/szegedi |
|
szegedi
| https://github.com/szegedi |
|
| https://github.com/nodejs/node/pull/62649/files/302bebe49e01fca18e53b530179d75ccf2d85a58 |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/62649 |
|
| https://github.com/rudolf |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/szegedi |
|
| https://github.com/Qard |
|
| https://github.com/IlyasShabi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |