René's URL Explorer Experiment


Title: src: coerce `spawnSync` args to string once by aduh95 · Pull Request #62633 · nodejs/node · GitHub

Open Graph Title: src: coerce `spawnSync` args to string once by aduh95 · Pull Request #62633 · nodejs/node

X Title: src: coerce `spawnSync` args to string once by aduh95 · Pull Request #62633 · nodejs/node

Description: This also fixes a TOCTOU race condition for objects with non-constant toString returned value.

Open Graph Description: This also fixes a TOCTOU race condition for objects with non-constant toString returned value.

X Description: This also fixes a TOCTOU race condition for objects with non-constant toString returned value.

Opengraph URL: https://github.com/nodejs/node/pull/62633

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:71cba1b9-8959-fbab-2598-b0ff3a78bb82
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDB0:348CFA:15E3F5C:1F94E37:6A4CE68B
html-safe-nonce76d448a6eaaded87792b74b8b960ce5ce5b36d0570e4c158b439e85b2730051a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREIwOjM0OENGQToxNUUzRjVDOjFGOTRFMzc6NkE0Q0U2OEIiLCJ2aXNpdG9yX2lkIjoiMzU2OTEzODUzOTM4NjY5MzI1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7e7030c9d7078abe9d22260f61f2172da7f206af21fbccce10ea34c294fccc06
hovercard-subject-tagpull_request:3502509266
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/62633/files
twitter:imagehttps://avatars.githubusercontent.com/u/14309773?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/14309773?s=400&v=4
og:image:altThis also fixes a TOCTOU race condition for objects with non-constant toString returned value.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None299b43bca6e02ad35197ffeba30d2466846d5fb02ab96fbced5b5e6cec589fb8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec5a57f04eeb310f57c73fd6d751d957e2ca27ed2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/62633/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62633%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62633%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/62633/files
Reloadhttps://github.com/nodejs/node/pull/62633/files
Reloadhttps://github.com/nodejs/node/pull/62633/files
Please reload this pagehttps://github.com/nodejs/node/pull/62633/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/62633/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 961 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:spawn-sync-args-tostringhttps://github.com/aduh95/node/tree/spawn-sync-args-tostring
Conversation 4 https://github.com/nodejs/node/pull/62633
Commits 5 https://github.com/nodejs/node/pull/62633/commits
Checks 34 https://github.com/nodejs/node/pull/62633/checks
Files changed https://github.com/nodejs/node/pull/62633/files
Please reload this pagehttps://github.com/nodejs/node/pull/62633/files
src: coerce spawnSync args to string once https://github.com/nodejs/node/pull/62633/files#top
Show all changes 5 commits https://github.com/nodejs/node/pull/62633/files
0025e48 src: coerce `spawnSync` args to string once aduh95 Apr 8, 2026 https://github.com/nodejs/node/pull/62633/commits/0025e48324b6f7db6566ecfb533b70ec8b42ed14
5de7a87 fixup! src: coerce `spawnSync` args to string once aduh95 Apr 8, 2026 https://github.com/nodejs/node/pull/62633/commits/5de7a8778f1d03d57068fd927334b1e5b98a68da
1c93a56 fixup! src: coerce `spawnSync` args to string once aduh95 Apr 8, 2026 https://github.com/nodejs/node/pull/62633/commits/1c93a56750a970c0d672593b63332b9145425160
3b101ad fixup! src: coerce `spawnSync` args to string once aduh95 Apr 8, 2026 https://github.com/nodejs/node/pull/62633/commits/3b101ad9daf06b461f425f000690da51e07af7b6
e3aa3a3 fixup! fixup! src: coerce `spawnSync` args to string once aduh95 Apr 8, 2026 https://github.com/nodejs/node/pull/62633/commits/e3aa3a3e986abf09f5e87af59cf2f5e49f1d3242
Clear filters https://github.com/nodejs/node/pull/62633/files
Please reload this pagehttps://github.com/nodejs/node/pull/62633/files
Please reload this pagehttps://github.com/nodejs/node/pull/62633/files
spawn_sync.cc https://github.com/nodejs/node/pull/62633/files#diff-f774c89c36e3b418d01b3f9c2ef90f798f6360dda69811cf7472c3c6bbca36c7
test-child-process-spawnsync-non-string-args.js https://github.com/nodejs/node/pull/62633/files#diff-00aa0b86a97d664a40163d7015f1a61430f15846f375e9d23d321e22e8355c0b
src/spawn_sync.cchttps://github.com/nodejs/node/pull/62633/files#diff-f774c89c36e3b418d01b3f9c2ef90f798f6360dda69811cf7472c3c6bbca36c7
View file https://github.com/aduh95/node/blob/e3aa3a3e986abf09f5e87af59cf2f5e49f1d3242/src/spawn_sync.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/62633/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/62633/files#diff-f774c89c36e3b418d01b3f9c2ef90f798f6360dda69811cf7472c3c6bbca36c7
https://github.com/nodejs/node/pull/62633/files#diff-f774c89c36e3b418d01b3f9c2ef90f798f6360dda69811cf7472c3c6bbca36c7
https://github.com/nodejs/node/pull/62633/files#diff-f774c89c36e3b418d01b3f9c2ef90f798f6360dda69811cf7472c3c6bbca36c7
https://github.com/nodejs/node/pull/62633/files#diff-f774c89c36e3b418d01b3f9c2ef90f798f6360dda69811cf7472c3c6bbca36c7
https://github.com/nodejs/node/pull/62633/files#diff-f774c89c36e3b418d01b3f9c2ef90f798f6360dda69811cf7472c3c6bbca36c7
https://github.com/nodejs/node/pull/62633/files#diff-f774c89c36e3b418d01b3f9c2ef90f798f6360dda69811cf7472c3c6bbca36c7
test/parallel/test-child-process-spawnsync-non-string-args.jshttps://github.com/nodejs/node/pull/62633/files#diff-00aa0b86a97d664a40163d7015f1a61430f15846f375e9d23d321e22e8355c0b
View file https://github.com/aduh95/node/blob/e3aa3a3e986abf09f5e87af59cf2f5e49f1d3242/test/parallel/test-child-process-spawnsync-non-string-args.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/62633/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodejs/node/pull/62633/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.