René's URL Explorer Experiment


Title: stream: align Readable.toWeb termination with eos by ikeyan · Pull Request #62394 · nodejs/node · GitHub

Open Graph Title: stream: align Readable.toWeb termination with eos by ikeyan · Pull Request #62394 · nodejs/node

X Title: stream: align Readable.toWeb termination with eos by ikeyan · Pull Request #62394 · nodejs/node

Description: This aligns Readable.toWeb(stream) termination handling with eos(stream, { writable: false }). Changes: add regression tests for half-open duplex termination add regression coverage for adapter creation before and after end(), destroy(), and destroy(error) preserve terminated Readable adapter state, including closed/error state and byte stream type, regardless of when the adapter is created let Readable.toWeb() reuse eos() immediate completion handling for already-terminated streams add regression coverage for the synchronous internal EOS callback path, including listener cleanup and BYOB termination Tests: make lint ./configure && make -j4 test

Open Graph Description: This aligns Readable.toWeb(stream) termination handling with eos(stream, { writable: false }). Changes: add regression tests for half-open duplex termination add regression coverage for adapter cr...

X Description: This aligns Readable.toWeb(stream) termination handling with eos(stream, { writable: false }). Changes: add regression tests for half-open duplex termination add regression coverage for adapter cr...

Opengraph URL: https://github.com/nodejs/node/pull/62394

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:b2b05033-f3bf-b59b-a2f3-34076744d3d8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9692:3133FE:633AAA7:665B4DD:6A655A48
html-safe-nonceb83d14f7eff7b2c204f22498d6cc97e943f6004e76c31a15fe6285548891e373
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjkyOjMxMzNGRTo2MzNBQUE3OjY2NUI0REQ6NkE2NTVBNDgiLCJ2aXNpdG9yX2lkIjoiMTg5MDExMzI5MjI1OTkwODE2OCIsInJlZ2lvbl9lZGdlIjoic2VhIiwicmVnaW9uX3JlbmRlciI6InNlYSJ9
visitor-hmac7163c33313149c34101193578451453a04085061a9704044f630770083d8ac97
hovercard-subject-tagpull_request:3430898400
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48
twitter:imagehttps://avatars.githubusercontent.com/u/8082735?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8082735?s=400&v=4
og:image:altThis aligns Readable.toWeb(stream) termination handling with eos(stream, { writable: false }). Changes: add regression tests for half-open duplex termination add regression coverage for adapter cr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release309153364422b3c499922d1a2a6404910a58ed8e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62394%2Fcommits%2Fcacf709e3de0cb4266989b0f167515885d0edc48
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62394%2Fcommits%2Fcacf709e3de0cb4266989b0f167515885d0edc48
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48
Reloadhttps://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48
Reloadhttps://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48
Please reload this pagehttps://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 1.1k https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
aduh95https://github.com/aduh95
nodejs:mainhttps://github.com/nodejs/node/tree/main
ikeyan:fix-stream-readable-to-webhttps://github.com/ikeyan/node/tree/fix-stream-readable-to-web
Conversation 8 https://github.com/nodejs/node/pull/62394
Commits 12 https://github.com/nodejs/node/pull/62394/commits
Checks 42 https://github.com/nodejs/node/pull/62394/checks
Files changed https://github.com/nodejs/node/pull/62394/files
Please reload this pagehttps://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48
stream: align Readable.toWeb termination with eos https://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48#top
Show all changes 12 commits https://github.com/nodejs/node/pull/62394/files
01c0fe8 stream: end Readable.toWeb on half-open duplex ikeyan Mar 20, 2026 https://github.com/nodejs/node/pull/62394/commits/01c0fe8da0f475ec8f4c66cdbf4da394f6a56a79
9cff872 stream: preserve terminated Readable adapter state ikeyan Mar 21, 2026 https://github.com/nodejs/node/pull/62394/commits/9cff8721824b32f4f7da4f64e5199170b527ce96
7c9c069 stream: align Readable adapter termination with eos ikeyan Mar 22, 2026 https://github.com/nodejs/node/pull/62394/commits/7c9c069df84b3ecf54adf0faebfab6facbe57f2d
3d5bfbb stream: let Readable.toWeb reuse eos immediate path ikeyan Mar 23, 2026 https://github.com/nodejs/node/pull/62394/commits/3d5bfbbd508b722f51d4ee73ee0004ad3cfd86b1
6434eb7 stream: cover synchronous Readable.toWeb eos path ikeyan Mar 23, 2026 https://github.com/nodejs/node/pull/62394/commits/6434eb7ebeeb5e67c43b952d6ebf3932f270ee8d
cacf709 test: cover BYOB Readable.toWeb termination ikeyan Mar 23, 2026 https://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48
e01de1c stream: simplify eos immediate completion path ikeyan Mar 23, 2026 https://github.com/nodejs/node/pull/62394/commits/e01de1ca86ad800f532e7df16058c7b5f3f68ffb
cbe1987 test: cover finished on aborted request-like stream ikeyan Mar 23, 2026 https://github.com/nodejs/node/pull/62394/commits/cbe1987556431eb2e211093c0094c9c669b964ec
bd8ee4b stream: fix typo ikeyan Mar 24, 2026 https://github.com/nodejs/node/pull/62394/commits/bd8ee4bc4b3d49b6d963790628cc5c23742bddee
a0fd4b7 test: cover finished on pre-aborted signal ikeyan Mar 24, 2026 https://github.com/nodejs/node/pull/62394/commits/a0fd4b7788eef378ba0db597ab86f53801c5dc23
4609cb7 test: use client response for realistic test case ikeyan Mar 24, 2026 https://github.com/nodejs/node/pull/62394/commits/4609cb783b225dc9626876e3a2b09113c680ddb6
4922bc4 test: cover synchronous finished pre-aborted signal and initial cleanup ikeyan Mar 24, 2026 https://github.com/nodejs/node/pull/62394/commits/4922bc4af21a75bff8bc4bcb24cf45d2b236f107
Clear filters https://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48
Please reload this pagehttps://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48
Please reload this pagehttps://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48
Prev https://github.com/nodejs/node/pull/62394/commits/6434eb7ebeeb5e67c43b952d6ebf3932f270ee8d
Next https://github.com/nodejs/node/pull/62394/commits/e01de1ca86ad800f532e7df16058c7b5f3f68ffb
Please reload this pagehttps://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48
https://github.com/ikeyan
ikeyanhttps://github.com/nodejs/node/commits?author=ikeyan
test/parallel/test-whatwg-webstreams-adapters-to-readablestream.jshttps://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48#diff-8dbd4804fbf8e127fae979004ee2a9d39ca6b1312399d7ce15e699e341a62683
View file https://github.com/ikeyan/node/blob/cacf709e3de0cb4266989b0f167515885d0edc48/test/parallel/test-whatwg-webstreams-adapters-to-readablestream.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/62394/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48#diff-8dbd4804fbf8e127fae979004ee2a9d39ca6b1312399d7ce15e699e341a62683
https://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48#diff-8dbd4804fbf8e127fae979004ee2a9d39ca6b1312399d7ce15e699e341a62683
Please reload this pagehttps://github.com/nodejs/node/pull/62394/commits/cacf709e3de0cb4266989b0f167515885d0edc48
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.