Title: quic: get back to addressing some long standing quic updates by jasnell · Pull Request #62387 · nodejs/node · GitHub
Open Graph Title: quic: get back to addressing some long standing quic updates by jasnell · Pull Request #62387 · nodejs/node
X Title: quic: get back to addressing some long standing quic updates by jasnell · Pull Request #62387 · nodejs/node
Description: This is a large batch of improvements to the QUIC implementation covering bug fixes, security hardening, stream data flow, HTTP/3 completeness, and dead code cleanup. Stream data flow: Add streaming outbound support (InitStreaming, Write, EndWrite) on Stream using non-idempotent DataQueue inside Outbound Write returns total buffered bytes for JS-side backpressure Add inbound read wakeup via Blob::Reader setWakeup/NotifyPull to replace busy-polling on STATUS_BLOCK Fix connection-level flow control: EntryRead now extends both per-stream and per-connection offsets Track fin_sent state via new fin parameter on Stream::Commit Track bytes_sent and max_offset_received stats Remove unused PAUSED state field (pull model makes it unnecessary) Add max_data_left() check in DefaultApplication::GetStreamData HTTP/3: Implement on_read_data_callback (critical: enables HTTP/3 body transmission via Bob protocol pull from Stream into nghttp3_vec) Implement SetStreamPriority override for server-side priority Implement OnShutdown (GOAWAY) with graceful session close Security and TLS: Fix use-after-release in TLS session ticket resumption by adding OSSLContext::set_session_ticket() method Fix null UB in get_selected_alpn when no ALPN negotiated Implement client cert verification with reject_unauthorized option (default true: reject during handshake; false: defer to JS) Fix and re-enable server session ticket generation (root cause was invalid cast in GetAppDataSource: TLSSession* to AppData::Source*) Implement early data / 0-RTT rejection handling Add enable_early_data server option (default true) Re-enable ngtcp2_crypto_ossl_init() (moved from static init to CreatePerContextProperties with std::call_once) Bug fixes: Fix AF_INET used instead of AF_INET6 in SelectPreferredAddress Fix acked_at stat recorded in Commit instead of Acknowledge Fix double destroyed_at timestamp in Endpoint::Destroy Fix ShouldSetFin is_empty logic (return i == 0, not i > 0) Fix token expiration clamping (std::min -> std::clamp with max) Fix DCHECK_IMPLIES using = instead of == in token validation Fix CID hash truncated to uint8_t (move mixing outside std::hash) Fix PreferredAddress::AddressInfo string_view dangling pointer Fix Endpoint::Send() stats counted after send failure Fix Endpoint::OnReceive buffer leak on UV_UDP_PARTIAL and errors Fix memcmp -> CRYPTO_memcmp for constant-time token comparison Fix RegularToken memory info macros referencing RetryToken Fix LogStream variable shadowing (EmitAlloc gets wrong size) Fix [[unlikely]] annotation on common success path in Receive New features: Add on_receive_new_token handling: emits token + remote address to JS for storage and future reconnection Add token field to Session::Options for client reconnection Make 0-RTT retry conditional on validate_address option Cleanup: Remove dead declarations (Release, FastMarkBusy, FastRef) Remove ShouldSetFin pure virtual (never called, FIN set directly) Remove StreamData::remaining (write-only field) Remove UnscheduleStream/Unschedule (ListNode dtor handles it) Add static_assert for ngtcp2_vec/nghttp3_vec layout compatibility Fix comment bugs (bidi->uni, retry->regular in RegularToken docs) Make DebugIndentScope::indent_ thread_local Clear server_state_ in Endpoint::Destroy Add CreateEntryFromBuffer utility (detach-or-copy for ArrayBuffers)
Open Graph Description: This is a large batch of improvements to the QUIC implementation covering bug fixes, security hardening, stream data flow, HTTP/3 completeness, and dead code cleanup. Stream data flow: Add streami...
X Description: This is a large batch of improvements to the QUIC implementation covering bug fixes, security hardening, stream data flow, HTTP/3 completeness, and dead code cleanup. Stream data flow: Add streami...
Opengraph URL: https://github.com/nodejs/node/pull/62387
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7d2798a8-14a0-4e10-2d77-aac8ceba5206 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 87F6:9CFB1:142566B:1B43E41:6A4C7867 |
| html-safe-nonce | f27ac94bbc9414cc1f9b385bacbb86eb6c159e7d6a03e8190d032e33594411bc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0Y2OjlDRkIxOjE0MjU2NkI6MUI0M0U0MTo2QTRDNzg2NyIsInZpc2l0b3JfaWQiOiI3OTE0MzU0NDk2MDI4NTcxNzUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ee186ed7454e03a72860fb16a251707b88ceca21006de5a6ec1882b3f59e20ad |
| hovercard-subject-tag | pull_request:3429987710 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/62387/files |
| twitter:image | https://avatars.githubusercontent.com/u/439929?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/439929?s=400&v=4 |
| og:image:alt | This is a large batch of improvements to the QUIC implementation covering bug fixes, security hardening, stream data flow, HTTP/3 completeness, and dead code cleanup. Stream data flow: Add streami... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 56ac743bebb13694b888673bb7257f4b97a4b7fd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width