René's URL Explorer Experiment


Title: path: fix inconsistent basename suffix stripping with trailing slashes by murataslan1 · Pull Request #62378 · nodejs/node · GitHub

Open Graph Title: path: fix inconsistent basename suffix stripping with trailing slashes by murataslan1 · Pull Request #62378 · nodejs/node

X Title: path: fix inconsistent basename suffix stripping with trailing slashes by murataslan1 · Pull Request #62378 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #21358 Summary path.basename() produced inconsistent results when stripping a suffix from paths with trailing slashes or leading path components. For example: path.posix.basename('a'...

X Description: Fixes: #21358 Summary path.basename() produced inconsistent results when stripping a suffix from paths with trailing slashes or leading path components. For example: path.posix.basename('a&...

Opengraph URL: https://github.com/nodejs/node/pull/62378

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bf78d2d5-e9ea-cad2-e0a8-29a937ff294e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE6C:1EB0:115CC4D:191C792:6A4E4C03
html-safe-nonce856555ce1037ad9592a14ef5b37de2a08927cf96c41ff0473cf0b0a221521860
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTZDOjFFQjA6MTE1Q0M0RDoxOTFDNzkyOjZBNEU0QzAzIiwidmlzaXRvcl9pZCI6IjUxMDgzOTcxMzY4NjIzOTk0OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8d6661290818fa1f05085cbfcc3837b7e68a4355623f93dad049b06a7616cc75
hovercard-subject-tagpull_request:3429759024
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/62378/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/35112e3dedc04dfcb8e9960c4aba5cf0ef060bbad586b81faba4124cd41d5dca/nodejs/node/pull/62378
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/35112e3dedc04dfcb8e9960c4aba5cf0ef060bbad586b81faba4124cd41d5dca/nodejs/node/pull/62378
og:image:altFixes: #21358 Summary path.basename() produced inconsistent results when stripping a suffix from paths with trailing slashes or leading path components. For example: path.posix.basename('a'...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemurataslan1
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee8506f6d0538364886e3f0153c154c410965e70d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/62378#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62378
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62378
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/62378
Reloadhttps://github.com/nodejs/node/pull/62378
Reloadhttps://github.com/nodejs/node/pull/62378
Please reload this pagehttps://github.com/nodejs/node/pull/62378
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/62378
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
murataslan1https://github.com/murataslan1
nodejs:mainhttps://github.com/nodejs/node/tree/main
murataslan1:fix/path-basename-ext-inconsistencyhttps://github.com/murataslan1/node/tree/fix/path-basename-ext-inconsistency
Conversationhttps://github.com/nodejs/node/pull/62378
Commits2 (2)https://github.com/nodejs/node/pull/62378/commits
Checkshttps://github.com/nodejs/node/pull/62378/checks
Files changedhttps://github.com/nodejs/node/pull/62378/files
path: fix inconsistent basename suffix stripping with trailing slasheshttps://github.com/nodejs/node/pull/62378#top
murataslan1https://github.com/murataslan1
nodejs:mainhttps://github.com/nodejs/node/tree/main
murataslan1:fix/path-basename-ext-inconsistencyhttps://github.com/murataslan1/node/tree/fix/path-basename-ext-inconsistency
https://github.com/murataslan1
murataslan1https://github.com/murataslan1
Mar 21, 2026https://github.com/nodejs/node/pull/62378#issue-4114226207
#21358https://github.com/nodejs/node/issues/21358
#5123https://github.com/nodejs/node/pull/5123
#5123https://github.com/nodejs/node/pull/5123
Please reload this pagehttps://github.com/nodejs/node/pull/62378
murataslan1https://github.com/murataslan1
March 22, 2026 02:33https://github.com/nodejs/node/pull/62378#commits-pushed-e1746a9
https://github.com/murataslan1
test_runner: avoid reading process state directly in run()https://github.com/nodejs/node/pull/62378/commits/e1746a9e19f5c02d6d40ddad5e290a9c4e2950cb
e1746a9https://github.com/nodejs/node/pull/62378/commits/e1746a9e19f5c02d6d40ddad5e290a9c4e2950cb
nodejs#53867https://github.com/nodejs/node/issues/53867
https://github.com/murataslan1
path: fix inconsistent basename suffix stripping with trailing slasheshttps://github.com/nodejs/node/pull/62378/commits/4f0bff1362330ccb29f3dc0cdbb1ff24741981ce
4f0bff1https://github.com/nodejs/node/pull/62378/commits/4f0bff1362330ccb29f3dc0cdbb1ff24741981ce
nodejs#5123https://github.com/nodejs/node/pull/5123
nodejs#21358https://github.com/nodejs/node/issues/21358
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
March 21, 2026 23:51https://github.com/nodejs/node/pull/62378#event-23784681370
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 21, 2026https://github.com/nodejs/node/pull/62378#issuecomment-4104924519
Please reload this pagehttps://github.com/nodejs/node/pull/62378
https://github.com/murataslan1
murataslan1https://github.com/murataslan1
Mar 21, 2026 https://github.com/nodejs/node/pull/62378#ref-issue-332901634
Inconsistent behavior of path.basename(path, ext) #21358 https://github.com/nodejs/node/issues/21358
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
path https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apath
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Mar 21, 2026https://github.com/nodejs/node/pull/62378#event-23784684209
started reviewinghttps://github.com/nodejs/node/sessions/e7642983-a7c6-4cc0-b69d-b221bad6f77a
murataslan1https://github.com/murataslan1
March 21, 2026 23:52https://github.com/nodejs/node/pull/62378#event-23784692281
View session https://github.com/nodejs/node/sessions/e7642983-a7c6-4cc0-b69d-b221bad6f77a
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Mar 21, 2026https://github.com/nodejs/node/pull/62378#event-23784717115
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
Mar 21, 2026 https://github.com/nodejs/node/pull/62378#pullrequestreview-3987170406
View reviewed changes https://github.com/nodejs/node/pull/62378/files/4f0bff1362330ccb29f3dc0cdbb1ff24741981ce
test/parallel/test-path-basename.jshttps://github.com/nodejs/node/pull/62378/files/4f0bff1362330ccb29f3dc0cdbb1ff24741981ce#diff-fc8d28db9b74a1963fa916604a0f23072f31862d460aa92bf832beedb3c35fc8
avivkellerhttps://github.com/avivkeller
Mar 21, 2026https://github.com/nodejs/node/pull/62378#discussion_r2970566686
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/62378
atlowChemihttps://github.com/atlowChemi
Mar 22, 2026https://github.com/nodejs/node/pull/62378#discussion_r2971173714
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/62378
murataslan1https://github.com/murataslan1
Mar 22, 2026https://github.com/nodejs/node/pull/62378#discussion_r2971228807
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ChALkeRhttps://github.com/ChALkeR
Please reload this pagehttps://github.com/nodejs/node/pull/62378
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Mar 21, 2026 https://github.com/nodejs/node/pull/62378#pullrequestreview-3987172200
View reviewed changes https://github.com/nodejs/node/pull/62378/files/4f0bff1362330ccb29f3dc0cdbb1ff24741981ce
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/nodejs/node/pull/62378#pullrequestreview-3987172200
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#21358https://github.com/nodejs/node/issues/21358
Add Copilot custom instructionshttps://github.com/nodejs/node/new/main?filename=.github/instructions/*.instructions.md
Learn how to get startedhttps://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot
Please reload this pagehttps://github.com/nodejs/node/pull/62378
lib/internal/test_runner/runner.jshttps://github.com/nodejs/node/pull/62378/files/4f0bff1362330ccb29f3dc0cdbb1ff24741981ce#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Mar 21, 2026https://github.com/nodejs/node/pull/62378#discussion_r2970568480
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/62378
Copilothttps://docs.github.com/copilot/responsible-use-of-github-copilot-features/responsible-use-of-github-copilot-code-review
lib/internal/test_runner/runner.jshttps://github.com/nodejs/node/pull/62378/files/4f0bff1362330ccb29f3dc0cdbb1ff24741981ce#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Mar 21, 2026https://github.com/nodejs/node/pull/62378#discussion_r2970568492
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/62378
Copilothttps://docs.github.com/copilot/responsible-use-of-github-copilot-features/responsible-use-of-github-copilot-code-review
lib/internal/main/test_runner.jshttps://github.com/nodejs/node/pull/62378/files/4f0bff1362330ccb29f3dc0cdbb1ff24741981ce#diff-1a8f92c415a79f46491ffbb54474b19b628bf4e4754187ada3dfd4cf48b973ef
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Mar 21, 2026https://github.com/nodejs/node/pull/62378#discussion_r2970568497
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/62378
Copilothttps://docs.github.com/copilot/responsible-use-of-github-copilot-features/responsible-use-of-github-copilot-code-review
https://github.com/murataslan1
murataslan1https://github.com/murataslan1
Mar 22, 2026https://github.com/nodejs/node/pull/62378#issuecomment-4105768330
Please reload this pagehttps://github.com/nodejs/node/pull/62378
https://github.com/murataslan1
murataslan1https://github.com/murataslan1
Mar 22, 2026https://github.com/nodejs/node/pull/62378#event-23788915166
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62378
https://github.com/atlowChemi
atlowChemi https://github.com/atlowChemi
https://github.com/nodejs/node/pull/62378/files/4f0bff1362330ccb29f3dc0cdbb1ff24741981ce
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
https://github.com/nodejs/node/pull/62378/files/4f0bff1362330ccb29f3dc0cdbb1ff24741981ce
https://github.com/avivkeller
avivkeller https://github.com/avivkeller
https://github.com/nodejs/node/pull/62378/files/4f0bff1362330ccb29f3dc0cdbb1ff24741981ce
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
path https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apath
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Inconsistent behavior of path.basename(path, ext) https://github.com/nodejs/node/issues/21358
Please reload this pagehttps://github.com/nodejs/node/pull/62378
https://github.com/murataslan1
https://github.com/nodejs-github-bot
https://github.com/avivkeller
https://github.com/atlowChemi
https://github.com/apps/copilot-pull-request-reviewer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.