René's URL Explorer Experiment

Title: module: fix coverage of mocked CJS modules imported from ESM by marcopiraccini · Pull Request #62133 · nodejs/node · GitHub

Open Graph Title: module: fix coverage of mocked CJS modules imported from ESM by marcopiraccini · Pull Request #62133 · nodejs/node

X Title: module: fix coverage of mocked CJS modules imported from ESM by marcopiraccini · Pull Request #62133 · nodejs/node

Description: When a CommonJS module is mocked via mock.module() and imported from an ESM module, the mocked module incorrectly appears in the coverage report with partial coverage, even though the original source was never executed. The root cause is in loadCJSModule. It passes filename to compileFunctionForCJSLoader as the V8 resource name. When the mock loader resolves a mocked module, it appends a ?node-test-mock search param to the URL. However, urlToFilename() strips this param. The coverage filter in shouldSkipFileCoverage then fails to recognize it as a mocked module. The fix passes the full url (which preserves the ?node-test-mock search param) to compileFunctionForCJSLoader instead of the stripped filename. For non-mocked CJS modules loaded via ESM, the url is file:///path/to/file.cjs which produces the same V8 behavior as passing the bare path Fixes: #61709

Open Graph Description: When a CommonJS module is mocked via mock.module() and imported from an ESM module, the mocked module incorrectly appears in the coverage report with partial coverage, even though the original sour...

X Description: When a CommonJS module is mocked via mock.module() and imported from an ESM module, the mocked module incorrectly appears in the coverage report with partial coverage, even though the original sour...

Opengraph URL: https://github.com/nodejs/node/pull/62133

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width