René's URL Explorer Experiment


Title: process: fix incorrect usage of assert.fail() by Trott · Pull Request #6211 · nodejs/node · GitHub

Open Graph Title: process: fix incorrect usage of assert.fail() by Trott · Pull Request #6211 · nodejs/node

X Title: process: fix incorrect usage of assert.fail() by Trott · Pull Request #6211 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist tests and code linting passes the commit message follows commit guidelines Affected core subsystem(s) process, promises Description of change The message argument for assert.fail()...

X Description: Checklist tests and code linting passes the commit message follows commit guidelines Affected core subsystem(s) process, promises Description of change The message argument for assert.fail()...

Opengraph URL: https://github.com/nodejs/node/pull/6211

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7490a2a4-e50b-9d99-167c-7d2555582d0b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB0B8:20C9D0:E9C561:145B4C8:6A4DEF53
html-safe-nonced4508e80529a58bfdcd5245e5a9dd5c9b2bb24be13b04151604bf1904573f4e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEI4OjIwQzlEMDpFOUM1NjE6MTQ1QjRDODo2QTRERUY1MyIsInZpc2l0b3JfaWQiOiIyMDc4NTQ3MDgzOTI1NTE2MTE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3ab7984ad278e6045538f112cce01bcc7f354f1868e0242c548c5fe64b00d451
hovercard-subject-tagpull_request:66587116
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/6211/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/47cb972bc9e6cf3851d9af57291c50f1209ffe596bcff2c323d8bc6d8bdc83a4/nodejs/node/pull/6211
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/47cb972bc9e6cf3851d9af57291c50f1209ffe596bcff2c323d8bc6d8bdc83a4/nodejs/node/pull/6211
og:image:altChecklist tests and code linting passes the commit message follows commit guidelines Affected core subsystem(s) process, promises Description of change The message argument for assert.fail()...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef4bb89367ca678f057d79b1abc45d6675b1bd5b2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/6211#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6211
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6211
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/6211
Reloadhttps://github.com/nodejs/node/pull/6211
Reloadhttps://github.com/nodejs/node/pull/6211
Please reload this pagehttps://github.com/nodejs/node/pull/6211
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/6211
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:deephttps://github.com/Trott/io.js/tree/deep
Conversationhttps://github.com/nodejs/node/pull/6211
Commits1 (1)https://github.com/nodejs/node/pull/6211/commits
Checkshttps://github.com/nodejs/node/pull/6211/checks
Files changedhttps://github.com/nodejs/node/pull/6211/files
process: fix incorrect usage of assert.fail()https://github.com/nodejs/node/pull/6211#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:deephttps://github.com/Trott/io.js/tree/deep
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 15, 2016https://github.com/nodejs/node/pull/6211#issue-148548165
Please reload this pagehttps://github.com/nodejs/node/pull/6211
https://github.com/Trott
process: fix incorrect usage of assert.fail()https://github.com/nodejs/node/pull/6211/commits/c60a3f08d92dbf7e0332e48cc08b9b8d17f992bd
c60a3f0https://github.com/nodejs/node/pull/6211/commits/c60a3f08d92dbf7e0332e48cc08b9b8d17f992bd
https://github.com/Trott
Trotthttps://github.com/Trott
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
Apr 15, 2016https://github.com/nodejs/node/pull/6211#event-628356302
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 15, 2016https://github.com/nodejs/node/pull/6211#issuecomment-210274619
https://ci.nodejs.org/job/node-test-pull-request/2269/https://ci.nodejs.org/job/node-test-pull-request/2269/
Please reload this pagehttps://github.com/nodejs/node/pull/6211
mscdexhttps://github.com/mscdex
Apr 15, 2016 https://github.com/nodejs/node/pull/6211#discussion-diff-59827324
View reviewed changes https://github.com/nodejs/node/pull/6211/files/c60a3f08d92dbf7e0332e48cc08b9b8d17f992bd#diff-04f0a68c4bc76396de863bbe0982c85d70a5b71432bdc26bc503e3ac317c6f82
lib/internal/process/promises.jshttps://github.com/nodejs/node/pull/6211/files#diff-04f0a68c4bc76396de863bbe0982c85d70a5b71432bdc26bc503e3ac317c6f82
mscdexhttps://github.com/mscdex
Apr 15, 2016https://github.com/nodejs/node/pull/6211#discussion_r59827324
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/6211
bnoordhuishttps://github.com/bnoordhuis
Apr 15, 2016https://github.com/nodejs/node/pull/6211#discussion_r59836612
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/6211
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Apr 15, 2016https://github.com/nodejs/node/pull/6211#issuecomment-210294090
Please reload this pagehttps://github.com/nodejs/node/pull/6211
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 15, 2016https://github.com/nodejs/node/pull/6211#issuecomment-210333341
Please reload this pagehttps://github.com/nodejs/node/pull/6211
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 15, 2016https://github.com/nodejs/node/pull/6211#issuecomment-210343761
Please reload this pagehttps://github.com/nodejs/node/pull/6211
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Apr 18, 2016https://github.com/nodejs/node/pull/6211#issuecomment-211349014
Please reload this pagehttps://github.com/nodejs/node/pull/6211
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Apr 18, 2016https://github.com/nodejs/node/pull/6211#issuecomment-211360676
Please reload this pagehttps://github.com/nodejs/node/pull/6211
jasnellhttps://github.com/jasnell
Apr 18, 2016 https://github.com/nodejs/node/pull/6211#ref-commit-b7f4b1b
https://github.com/Trott
https://github.com/jasnell
process: fix incorrect usage of assert.fail()https://github.com/nodejs/node/commit/b7f4b1ba4cca320cf576aa73fae15902fd801190
b7f4b1bhttps://github.com/nodejs/node/commit/b7f4b1ba4cca320cf576aa73fae15902fd801190
#6211https://github.com/nodejs/node/pull/6211
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 18, 2016https://github.com/nodejs/node/pull/6211#issuecomment-211472620
b7f4b1bhttps://github.com/nodejs/node/commit/b7f4b1ba4cca320cf576aa73fae15902fd801190
Please reload this pagehttps://github.com/nodejs/node/pull/6211
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 18, 2016https://github.com/nodejs/node/pull/6211#event-631618597
https://github.com/jasnell
jasnellhttps://github.com/jasnell
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Apr 18, 2016https://github.com/nodejs/node/pull/6211#event-631618715
MylesBorinshttps://github.com/MylesBorins
Apr 19, 2016 https://github.com/nodejs/node/pull/6211#ref-commit-8af53a8
https://github.com/Trott
process: fix incorrect usage of assert.fail()https://github.com/nodejs/node/commit/8af53a8b92db6240e660aa4872814839dda297c4
8af53a8https://github.com/nodejs/node/commit/8af53a8b92db6240e660aa4872814839dda297c4
#6211https://github.com/nodejs/node/pull/6211
MylesBorinshttps://github.com/MylesBorins
Apr 20, 2016 https://github.com/nodejs/node/pull/6211#ref-commit-4503098
https://github.com/Trott
process: fix incorrect usage of assert.fail()https://github.com/nodejs/node/commit/4503098cee9ef4aec91fc4851909c5a2796271d9
4503098https://github.com/nodejs/node/commit/4503098cee9ef4aec91fc4851909c5a2796271d9
#6211https://github.com/nodejs/node/pull/6211
MylesBorinshttps://github.com/MylesBorins
Apr 20, 2016 https://github.com/nodejs/node/pull/6211#ref-commit-a31610e
https://github.com/Trott
process: fix incorrect usage of assert.fail()https://github.com/nodejs/node/commit/a31610e6bcdee2b98a356b393df69295107aac69
a31610ehttps://github.com/nodejs/node/commit/a31610e6bcdee2b98a356b393df69295107aac69
#6211https://github.com/nodejs/node/pull/6211
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 20, 2016 https://github.com/nodejs/node/pull/6211#ref-pullrequest-149848634
V5.10.2 proposal #6311 https://github.com/nodejs/node/pull/6311
MylesBorinshttps://github.com/MylesBorins
Apr 20, 2016 https://github.com/nodejs/node/pull/6211#ref-commit-1d40809
https://github.com/Trott
process: fix incorrect usage of assert.fail()https://github.com/nodejs/node/commit/1d408099b7cf8541a31e96d4ec444b24cbeef038
1d40809https://github.com/nodejs/node/commit/1d408099b7cf8541a31e96d4ec444b24cbeef038
#6211https://github.com/nodejs/node/pull/6211
V5.11.0 proposal #6321 https://github.com/nodejs/node/pull/6321
V5.11.0 proposal #6322 https://github.com/nodejs/node/pull/6322
MylesBorinshttps://github.com/MylesBorins
Apr 21, 2016 https://github.com/nodejs/node/pull/6211#ref-commit-fbb0a06
https://github.com/Trott
https://github.com/MylesBorins
process: fix incorrect usage of assert.fail()https://github.com/nodejs/node/commit/fbb0a06080810ed7e0f744a6cd867c0b2621cba1
fbb0a06https://github.com/nodejs/node/commit/fbb0a06080810ed7e0f744a6cd867c0b2621cba1
#6211https://github.com/nodejs/node/pull/6211
joelostrowskihttps://github.com/joelostrowski
Apr 25, 2016 https://github.com/nodejs/node/pull/6211#ref-commit-6517d27
https://github.com/Trott
https://github.com/joelostrowski
process: fix incorrect usage of assert.fail()https://github.com/joelostrowski/node/commit/6517d273372b44b05bb93dad2958f38c58249cf8
6517d27https://github.com/joelostrowski/node/commit/6517d273372b44b05bb93dad2958f38c58249cf8
nodejs#6211https://github.com/nodejs/node/pull/6211
jasnellhttps://github.com/jasnell
Apr 26, 2016 https://github.com/nodejs/node/pull/6211#ref-commit-7fd98af
https://github.com/Trott
https://github.com/jasnell
process: fix incorrect usage of assert.fail()https://github.com/nodejs/node/commit/7fd98af95d66245873385f545fcf45e2aea277eb
7fd98afhttps://github.com/nodejs/node/commit/7fd98af95d66245873385f545fcf45e2aea277eb
#6211https://github.com/nodejs/node/pull/6211
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
May 17, 2016https://github.com/nodejs/node/pull/6211#event-663741383
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 17, 2016https://github.com/nodejs/node/pull/6211#issuecomment-219884951
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/6211
https://github.com/Trott
Trotthttps://github.com/Trott
May 18, 2016https://github.com/nodejs/node/pull/6211#issuecomment-219915578
@thealphanerdhttps://github.com/thealphanerd
Please reload this pagehttps://github.com/nodejs/node/pull/6211
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:43https://github.com/nodejs/node/pull/6211#event-5890936633
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6211
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
Please reload this pagehttps://github.com/nodejs/node/pull/6211
https://github.com/Trott
https://github.com/mscdex
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/evanlucas
https://github.com/cjihrig
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.