Title: stream: replace bind with arrow function for onwrite callback by thisalihassan · Pull Request #62087 · nodejs/node · GitHub
Open Graph Title: stream: replace bind with arrow function for onwrite callback by thisalihassan · Pull Request #62087 · nodejs/node
X Title: stream: replace bind with arrow function for onwrite callback by thisalihassan · Pull Request #62087 · nodejs/node
Description: Replace onwrite.bind(undefined, stream) with an arrow function. Writable creation +29.92% Duplex creation +19.91% streams/creation.js kind='duplex' n=50000000 *** 19.91 % ±0.92% ±1.23% ±1.60% streams/creation.js kind='readable' n=50000000 -0.53 % ±1.14% ±1.53% ±2.01% streams/creation.js kind='transform' n=50000000 *** 5.06 % ±1.03% ±1.37% ±1.79% streams/creation.js kind='writable' n=50000000 *** 29.92 % ±1.16% ±1.55% ±2.01% streams/pipe-object-mode.js n=5000000 0.12 % ±1.16% ±1.55% ±2.04% streams/pipe.js n=5000000 -0.12 % ±0.80% ±1.07% ±1.39% streams/writable-manywrites.js len=1024 callback='no' writev='no' sync='no' n=100000 1.82 % ±2.31% ±3.10% ±4.10% streams/writable-manywrites.js len=1024 callback='no' writev='no' sync='yes' n=100000 -0.77 % ±1.88% ±2.50% ±3.26% streams/writable-manywrites.js len=1024 callback='no' writev='yes' sync='no' n=100000 0.33 % ±1.24% ±1.66% ±2.17% streams/writable-manywrites.js len=1024 callback='no' writev='yes' sync='yes' n=100000 0.48 % ±1.48% ±1.97% ±2.56% streams/writable-manywrites.js len=1024 callback='yes' writev='no' sync='no' n=100000 0.08 % ±0.73% ±0.97% ±1.26% streams/writable-manywrites.js len=1024 callback='yes' writev='no' sync='yes' n=100000 -2.24 % ±4.73% ±6.36% ±8.42% streams/writable-manywrites.js len=1024 callback='yes' writev='yes' sync='no' n=100000 -1.10 % ±1.66% ±2.20% ±2.87% streams/writable-manywrites.js len=1024 callback='yes' writev='yes' sync='yes' n=100000 -0.78 % ±1.58% ±2.11% ±2.75% streams/writable-manywrites.js len=32768 callback='no' writev='no' sync='no' n=100000 -0.12 % ±0.83% ±1.11% ±1.45% streams/writable-manywrites.js len=32768 callback='no' writev='no' sync='yes' n=100000 -0.61 % ±1.88% ±2.51% ±3.26% streams/writable-manywrites.js len=32768 callback='no' writev='yes' sync='no' n=100000 -0.12 % ±0.68% ±0.91% ±1.18% streams/writable-manywrites.js len=32768 callback='no' writev='yes' sync='yes' n=100000 -1.37 % ±4.54% ±6.10% ±8.04% streams/writable-manywrites.js len=32768 callback='yes' writev='no' sync='no' n=100000 3.08 % ±4.28% ±5.76% ±7.63% streams/writable-manywrites.js len=32768 callback='yes' writev='no' sync='yes' n=100000 0.18 % ±1.71% ±2.28% ±2.97% streams/writable-manywrites.js len=32768 callback='yes' writev='yes' sync='no' n=100000 1.83 % ±3.21% ±4.32% ±5.72% streams/writable-manywrites.js len=32768 callback='yes' writev='yes' sync='yes' n=100000 0.00 % ±1.64% ±2.19% ±2.86% Be aware that when doing many comparisons the risk of a false-positive result increases. In this case, there are 22 comparisons, you can thus expect the following amount of false-positive results: 1.10 false positives, when considering a 5% risk acceptance (*, **, *), 0.22 false positives, when considering a 1% risk acceptance (, ), 0.02 false positives, when considering a 0.1% risk acceptance ()
Open Graph Description: Replace onwrite.bind(undefined, stream) with an arrow function. Writable creation +29.92% Duplex creation +19.91% streams/creation.js kind='duplex' n=50000000 ...
X Description: Replace onwrite.bind(undefined, stream) with an arrow function. Writable creation +29.92% Duplex creation +19.91% streams/creation.js kind='duplex' n=50000000 ...
Opengraph URL: https://github.com/nodejs/node/pull/62087
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:00871830-c8d8-28cc-129f-7eee586397ae |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8588:2C345B:10659E:15A21A:6A4C2164 |
| html-safe-nonce | d5d833321c18e45d0554ce43145060e5c239a364c95c9ecddffa7513ee845ac6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTg4OjJDMzQ1QjoxMDY1OUU6MTVBMjFBOjZBNEMyMTY0IiwidmlzaXRvcl9pZCI6IjgzMjQyNzM2MTM2NDIxNDYxNDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6cfd43716f718fb810198e1233b7bc4301fd2e83960268206044cfa033010db3 |
| hovercard-subject-tag | pull_request:3348775997 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/62087/files |
| twitter:image | https://avatars.githubusercontent.com/u/24819103?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/24819103?s=400&v=4 |
| og:image:alt | Replace onwrite.bind(undefined, stream) with an arrow function. Writable creation +29.92% Duplex creation +19.91% streams/creation.js kind='duplex' n=50000000 ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1b6b16d04026f131a36d57e3b01d0f4d26a51800edf48bf5ed0256e0ac905511 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f95fb36c72adc940ff991c03531114b2245658d0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width