René's URL Explorer Experiment


Title: test_runner: fix run() none-isolation teardown hang by inoway46 · Pull Request #62056 · nodejs/node · GitHub

Open Graph Title: test_runner: fix run() none-isolation teardown hang by inoway46 · Pull Request #62056 · nodejs/node

X Title: test_runner: fix run() none-isolation teardown hang by inoway46 · Pull Request #62056 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: When run({ isolation: 'none' }) is used from a cluster worker, live handles such as IPC can keep the process open after the tests finish. In that case teardown may be delayed and the run() ...

X Description: When run({ isolation: 'none' }) is used from a cluster worker, live handles such as IPC can keep the process open after the tests finish. In that case teardown may be delayed and th...

Opengraph URL: https://github.com/nodejs/node/pull/62056

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cff54e6f-3412-9f35-c516-042f977a347d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE0C:55AC6:4E5F44:65BA10:6AED251C
html-safe-nonce7a5dcfd276eb89cb81b8ed8ddfd60fdf470008280ac3a24bd4b36eb6e46939e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTBDOjU1QUM2OjRFNUY0NDo2NUJBMTA6NkFFRDI1MUMiLCJ2aXNpdG9yX2lkIjoiNDkxMDc1MzEwMTM3MjAwNzcwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdafc1c03ac52bc067df07735d912e14e7af4b848277bc8cb6928fa50173fac4a
hovercard-subject-tagpull_request:3340130440
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/62056/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c132d530c7ffd7a8a4f949c931fd512c78850bda82c16715b496905361dd1e3d/nodejs/node/pull/62056
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c132d530c7ffd7a8a4f949c931fd512c78850bda82c16715b496905361dd1e3d/nodejs/node/pull/62056
og:image:altWhen run({ isolation: 'none' }) is used from a cluster worker, live handles such as IPC can keep the process open after the tests finish. In that case teardown may be delayed and the run() ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameinoway46
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/62056#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62056
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62056
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/62056
Reloadhttps://github.com/nodejs/node/pull/62056
Reloadhttps://github.com/nodejs/node/pull/62056
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
inoway46https://github.com/inoway46
nodejs:mainhttps://github.com/nodejs/node/tree/main
inoway46:fix-60020-run-none-teardownhttps://github.com/inoway46/node/tree/fix-60020-run-none-teardown
Conversationhttps://github.com/nodejs/node/pull/62056
Commits1 (1)https://github.com/nodejs/node/pull/62056/commits
Checkshttps://github.com/nodejs/node/pull/62056/checks
Files changedhttps://github.com/nodejs/node/pull/62056/files
test_runner: fix run() none-isolation teardown hanghttps://github.com/nodejs/node/pull/62056#top
inoway46https://github.com/inoway46
nodejs:mainhttps://github.com/nodejs/node/tree/main
inoway46:fix-60020-run-none-teardownhttps://github.com/inoway46/node/tree/fix-60020-run-none-teardown
https://github.com/inoway46
inoway46https://github.com/inoway46
Mar 1, 2026https://github.com/nodejs/node/pull/62056#issue-4006413095
Please reload this pagehttps://github.com/nodejs/node/pull/62056
#60020https://github.com/nodejs/node/issues/60020
#60020https://github.com/nodejs/node/issues/60020
Please reload this pagehttps://github.com/nodejs/node/pull/62056
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 1, 2026https://github.com/nodejs/node/pull/62056#issuecomment-3979229271
Please reload this pagehttps://github.com/nodejs/node/pull/62056
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Mar 1, 2026https://github.com/nodejs/node/pull/62056#event-23166216425
https://github.com/inoway46
inoway46https://github.com/inoway46
force-pushedhttps://github.com/nodejs/node/compare/2e503c7962dd58863d874c968445d686668d229e..d00a7b17aa2d3b298545f7e7ac0e1b7cbc8f83bd
2e503c7https://github.com/nodejs/node/commit/2e503c7962dd58863d874c968445d686668d229e
d00a7b1https://github.com/nodejs/node/commit/d00a7b17aa2d3b298545f7e7ac0e1b7cbc8f83bd
Compare https://github.com/nodejs/node/compare/2e503c7962dd58863d874c968445d686668d229e..d00a7b17aa2d3b298545f7e7ac0e1b7cbc8f83bd
March 8, 2026 14:36https://github.com/nodejs/node/pull/62056#event-23373351732
https://github.com/inoway46
test_runner: fix run() none-isolation teardown hanghttps://github.com/nodejs/node/pull/62056/commits/c8bf2a8bbdbf05f6ae7905523de1e365a9331d0d
c8bf2a8https://github.com/nodejs/node/pull/62056/commits/c8bf2a8bbdbf05f6ae7905523de1e365a9331d0d
https://github.com/inoway46
inoway46https://github.com/inoway46
force-pushedhttps://github.com/nodejs/node/compare/d00a7b17aa2d3b298545f7e7ac0e1b7cbc8f83bd..c8bf2a8bbdbf05f6ae7905523de1e365a9331d0d
d00a7b1https://github.com/nodejs/node/commit/d00a7b17aa2d3b298545f7e7ac0e1b7cbc8f83bd
c8bf2a8https://github.com/nodejs/node/commit/c8bf2a8bbdbf05f6ae7905523de1e365a9331d0d
Compare https://github.com/nodejs/node/compare/d00a7b17aa2d3b298545f7e7ac0e1b7cbc8f83bd..c8bf2a8bbdbf05f6ae7905523de1e365a9331d0d
March 8, 2026 14:41https://github.com/nodejs/node/pull/62056#event-23373391630
https://github.com/inoway46
inoway46https://github.com/inoway46
Mar 8, 2026https://github.com/nodejs/node/pull/62056#event-23373417343
https://github.com/inoway46
inoway46https://github.com/inoway46
March 8, 2026 14:54https://github.com/nodejs/node/pull/62056#event-23373496343
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Mar 8, 2026https://github.com/nodejs/node/pull/62056#issuecomment-4019375830
Please reload this pagehttps://github.com/nodejs/node/pull/62056
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/62056?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
3725bd2https://app.codecov.io/gh/nodejs/node/commit/3725bd2145b1effcf49dd8a41ed7fadfd3cee1e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
c8bf2a8https://app.codecov.io/gh/nodejs/node/commit/c8bf2a8bbdbf05f6ae7905523de1e365a9331d0d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/62056?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/test_runner/runner.jshttps://app.codecov.io/gh/nodejs/node/pull/62056?src=pr&el=tree&filepath=lib%2Finternal%2Ftest_runner%2Frunner.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Rlc3RfcnVubmVyL3J1bm5lci5qcw==
41 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/62056/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/62056
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Mar 8, 2026https://github.com/nodejs/node/pull/62056#issuecomment-4019386953
#57394https://github.com/nodejs/node/pull/57394
Please reload this pagehttps://github.com/nodejs/node/pull/62056
https://github.com/inoway46
inoway46https://github.com/inoway46
Mar 8, 2026https://github.com/nodejs/node/pull/62056#issuecomment-4019414239
@JakobJingleheimerhttps://github.com/JakobJingleheimer
#57394https://github.com/nodejs/node/pull/57394
Please reload this pagehttps://github.com/nodejs/node/pull/62056
https://github.com/inoway46
inoway46https://github.com/inoway46
Mar 8, 2026https://github.com/nodejs/node/pull/62056#event-23374438162
https://github.com/inoway46
inoway46https://github.com/inoway46
March 8, 2026 16:29https://github.com/nodejs/node/pull/62056#event-23374440902
https://github.com/inoway46
inoway46https://github.com/inoway46
Mar 8, 2026 https://github.com/nodejs/node/pull/62056#ref-pullrequest-2905726158
test_runner: ensure proper teardown when tests run without isolation #57394 https://github.com/nodejs/node/pull/57394
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
duplicate https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aduplicate
Mar 8, 2026https://github.com/nodejs/node/pull/62056#event-23374685626
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62056
Please reload this pagehttps://github.com/nodejs/node/pull/62056
duplicate https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aduplicate
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Test runner with isolation=none does not work in child process https://github.com/nodejs/node/issues/60020
Please reload this pagehttps://github.com/nodejs/node/pull/62056
https://github.com/inoway46
https://github.com/nodejs-github-bot
https://github.com/JakobJingleheimer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.