René's URL Explorer Experiment

Title: [v22.x] backport module loader & loader hook fixes by joyeecheung · Pull Request #62029 · nodejs/node · GitHub

Open Graph Title: [v22.x] backport module loader & loader hook fixes by joyeecheung · Pull Request #62029 · nodejs/node

X Title: [v22.x] backport module loader & loader hook fixes by joyeecheung · Pull Request #62029 · nodejs/node

Description: Fixes: #61801 This backports the following bug fixes/refactors: #59679 #59874 #59929 #60072 #61088 #61479 #61529 As discussed in #61801 (comment), #59929 is backported with an additional diff to check how the module is loaded differently (by observing NODE_DEBUG output, instead of checking that require.cache does not exist) for the --experimental-default-type=module test, since this feature was only in early development and had been removed since v23.4.0, backporting a small behavior change to v22 (which arguably is the less surprising behavior) should be fine. see diff diff --git a/test/es-module/test-esm-type-flag-errors.mjs b/test/es-module/test-esm-type-flag-errors.mjs index 2f7a1db35d2..fbef806b907 100644 --- a/test/es-module/test-esm-type-flag-errors.mjs +++ b/test/es-module/test-esm-type-flag-errors.mjs @@ -36,14 +36,16 @@ describe('--experimental-default-type=module', { concurrency: !process.env.TEST_ const result = await spawnPromisified(process.execPath, [ '--experimental-default-type=module', fixtures.path('es-modules/package-type-commonjs/echo-require-cache.js'), - ]); - - deepStrictEqual(result, { - code: 0, - stderr: '', - stdout: 'undefined\n', - signal: null, + ], { + env: { + ...process.env, + NODE_DEBUG: 'esm', + } }); + match(result.stderr, /Translating CJSModule file.+echo-require-cache\.js/); + match(result.stdout, /Object: null prototype/); + strictEqual(result.code, 0); + strictEqual(result.signal, null); }); it('should affect .cjs files that are imported', async () => { @@ -51,25 +53,34 @@ describe('--experimental-default-type=module', { concurrency: !process.env.TEST_ '--experimental-default-type=module', '-e', `import ${JSON.stringify(fixtures.fileURL('es-module-require-cache/echo.cjs'))}`, - ]); - - deepStrictEqual(result, { - code: 0, - stderr: '', - stdout: 'undefined\n', - signal: null, + ], { + env: { + ...process.env, + NODE_DEBUG: 'esm', + } }); + + match(result.stderr, /Translating CJSModule file.+echo\.cjs/); + match(result.stdout, /Object: null prototype/); + strictEqual(result.code, 0); + strictEqual(result.signal, null); }); it('should affect entry point .cjs files (with no hooks)', async () => { - const { stderr, stdout, code } = await spawnPromisified(process.execPath, [ + const result = await spawnPromisified(process.execPath, [ '--experimental-default-type=module', fixtures.path('es-module-require-cache/echo.cjs'), - ]); + ], { + env: { + ...process.env, + NODE_DEBUG: 'esm', + } + }); - strictEqual(stderr, ''); - match(stdout, /^undefined\n$/); - strictEqual(code, 0); + match(result.stderr, /Translating CJSModule file.+echo\.cjs/); + match(result.stdout, /Object: null prototype/); + strictEqual(result.code, 0); + strictEqual(result.signal, null); }); it('should affect entry point .cjs files (when any hooks is registered)', async () => {

Open Graph Description: Fixes: #61801 This backports the following bug fixes/refactors: #59679 #59874 #59929 #60072 #61088 #61479 #61529 As discussed in #61801 (comment), #59929 is backported with an additional diff to ...

X Description: Fixes: #61801 This backports the following bug fixes/refactors: #59679 #59874 #59929 #60072 #61088 #61479 #61529 As discussed in #61801 (comment), #59929 is backported with an additional diff to ...

Opengraph URL: https://github.com/nodejs/node/pull/62029

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width