René's URL Explorer Experiment


Title: tls: forward keepAlive, keepAliveInitialDelay, noDelay to socket by tadjik1 · Pull Request #62004 · nodejs/node · GitHub

Open Graph Title: tls: forward keepAlive, keepAliveInitialDelay, noDelay to socket by tadjik1 · Pull Request #62004 · nodejs/node

X Title: tls: forward keepAlive, keepAliveInitialDelay, noDelay to socket by tadjik1 · Pull Request #62004 · nodejs/node

Description: Summary tls.connect() silently ignores keepAlive, keepAliveInitialDelay, and noDelay options. The documentation states it accepts any socket.connect() option, and net.createConnection() with the same options works correctly. This forwards the options through both points so net.Socket's constructor stores them on the internal symbols (kSetNoDelay, kSetKeepAlive, kSetKeepAliveInitialDelay), which afterConnect() then applies to the handle. Fixes: #62003 I believe this is a good candidate for backport, as it fixes a silent options-dropping bug in tls.connect() that affects keepAlive/noDelay behavior (in particular with AWS Lambda on 20.x runtime).

Open Graph Description: Summary tls.connect() silently ignores keepAlive, keepAliveInitialDelay, and noDelay options. The documentation states it accepts any socket.connect() option, and net.createConnection() with the sa...

X Description: Summary tls.connect() silently ignores keepAlive, keepAliveInitialDelay, and noDelay options. The documentation states it accepts any socket.connect() option, and net.createConnection() with the sa...

Opengraph URL: https://github.com/nodejs/node/pull/62004

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:11f39e58-c120-aad2-ac27-7495822a75ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA668:36DB52:35A601:4C3372:6A4C9E50
html-safe-nonce1788c69fa955e965819b6427fa73376dc08cd6bf5983e31e2f2e667267f2b4a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjY4OjM2REI1MjozNUE2MDE6NEMzMzcyOjZBNEM5RTUwIiwidmlzaXRvcl9pZCI6IjY1ODQ3OTEzODAzNTgxMTA4MDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd6c40ec739084854a7681fda71d69183f6e3218e291efbba98a05f285c1e5114
hovercard-subject-tagpull_request:3330436474
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/62004/files
twitter:imagehttps://avatars.githubusercontent.com/u/1452895?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1452895?s=400&v=4
og:image:altSummary tls.connect() silently ignores keepAlive, keepAliveInitialDelay, and noDelay options. The documentation states it accepts any socket.connect() option, and net.createConnection() with the sa...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseae90d426644ca15e89bacceb72e51f4e9dbf85f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/62004/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62004%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F62004%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/62004/files
Reloadhttps://github.com/nodejs/node/pull/62004/files
Reloadhttps://github.com/nodejs/node/pull/62004/files
Please reload this pagehttps://github.com/nodejs/node/pull/62004/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/62004/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tadjik1:fix/tls-connect-keepalive-nodelayhttps://github.com/tadjik1/node/tree/fix/tls-connect-keepalive-nodelay
Conversation 12 https://github.com/nodejs/node/pull/62004
Commits 1 https://github.com/nodejs/node/pull/62004/commits
Checks 51 https://github.com/nodejs/node/pull/62004/checks
Files changed https://github.com/nodejs/node/pull/62004/files
Please reload this pagehttps://github.com/nodejs/node/pull/62004/files
tls: forward keepAlive, keepAliveInitialDelay, noDelay to socket https://github.com/nodejs/node/pull/62004/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/62004/files
a373f56 tls: forward keepAlive, keepAliveInitialDelay, noDelay to socket tadjik1 Feb 26, 2026 https://github.com/nodejs/node/pull/62004/commits/a373f5685f4ab01989f9ed9da205eb9f51fdbe77
Clear filters https://github.com/nodejs/node/pull/62004/files
Please reload this pagehttps://github.com/nodejs/node/pull/62004/files
Please reload this pagehttps://github.com/nodejs/node/pull/62004/files
net.js https://github.com/nodejs/node/pull/62004/files#diff-5a4538cd718c611584a97c379b5445c006a886ea9b90734080f3434c4abc1ff0
wrap.js https://github.com/nodejs/node/pull/62004/files#diff-8686e670562f560649e7076f50048297afc8610c68dc41b5fe050cd45e7129dc
net.js https://github.com/nodejs/node/pull/62004/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
test-tls-connect-keepalive-nodelay.js https://github.com/nodejs/node/pull/62004/files#diff-57ab5d082e94c684b14fb9fb8d5b4a43b7f4610d27d77ca10385c111445faa08
lib/internal/net.jshttps://github.com/nodejs/node/pull/62004/files#diff-5a4538cd718c611584a97c379b5445c006a886ea9b90734080f3434c4abc1ff0
View file https://github.com/tadjik1/node/blob/a373f5685f4ab01989f9ed9da205eb9f51fdbe77/lib/internal/net.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/62004/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/62004/files#diff-5a4538cd718c611584a97c379b5445c006a886ea9b90734080f3434c4abc1ff0
https://github.com/nodejs/node/pull/62004/files#diff-5a4538cd718c611584a97c379b5445c006a886ea9b90734080f3434c4abc1ff0
lib/internal/tls/wrap.jshttps://github.com/nodejs/node/pull/62004/files#diff-8686e670562f560649e7076f50048297afc8610c68dc41b5fe050cd45e7129dc
View file https://github.com/tadjik1/node/blob/a373f5685f4ab01989f9ed9da205eb9f51fdbe77/lib/internal/tls/wrap.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/62004/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/62004/files#diff-8686e670562f560649e7076f50048297afc8610c68dc41b5fe050cd45e7129dc
https://github.com/nodejs/node/pull/62004/files#diff-8686e670562f560649e7076f50048297afc8610c68dc41b5fe050cd45e7129dc
https://github.com/nodejs/node/pull/62004/files#diff-8686e670562f560649e7076f50048297afc8610c68dc41b5fe050cd45e7129dc
https://github.com/nodejs/node/pull/62004/files#diff-8686e670562f560649e7076f50048297afc8610c68dc41b5fe050cd45e7129dc
lib/net.jshttps://github.com/nodejs/node/pull/62004/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
View file https://github.com/tadjik1/node/blob/a373f5685f4ab01989f9ed9da205eb9f51fdbe77/lib/net.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/62004/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/62004/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
https://github.com/nodejs/node/pull/62004/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
https://github.com/nodejs/node/pull/62004/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
https://github.com/nodejs/node/pull/62004/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
test/parallel/test-tls-connect-keepalive-nodelay.jshttps://github.com/nodejs/node/pull/62004/files#diff-57ab5d082e94c684b14fb9fb8d5b4a43b7f4610d27d77ca10385c111445faa08
View file https://github.com/tadjik1/node/blob/a373f5685f4ab01989f9ed9da205eb9f51fdbe77/test/parallel/test-tls-connect-keepalive-nodelay.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/62004/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodejs/node/pull/62004/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.