René's URL Explorer Experiment


Title: src: avoid JS callback for deprecated Promise resolve-after-resolved events by jorgitin02 · Pull Request #61960 · nodejs/node · GitHub

Open Graph Title: src: avoid JS callback for deprecated Promise resolve-after-resolved events by jorgitin02 · Pull Request #61960 · nodejs/node

X Title: src: avoid JS callback for deprecated Promise resolve-after-resolved events by jorgitin02 · Pull Request #61960 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Summary return early in src/node_task_queue.cc for kPromiseResolveAfterResolved and kPromiseRejectAfterResolved avoid invoking the JS promise reject callback for event types that JS-side logic alr...

X Description: Summary return early in src/node_task_queue.cc for kPromiseResolveAfterResolved and kPromiseRejectAfterResolved avoid invoking the JS promise reject callback for event types that JS-side logic alr...

Opengraph URL: https://github.com/nodejs/node/pull/61960

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3a60f34b-e11c-6f94-bb73-a0abf47eaeef
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8DE0:136654:69506:8D8EC:6A4D8C7F
html-safe-nonce98d036b1a635f0577b2174390a980d16032c77c30ea3a0ec67401c7384ea7915
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REUwOjEzNjY1NDo2OTUwNjo4RDhFQzo2QTREOEM3RiIsInZpc2l0b3JfaWQiOiI0OTExODU2MDQ4OTYzMTYxMjE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0adb60073d02cca41e77bacf48d191613c3b4dfc7867edc87f7dae93ad799776
hovercard-subject-tagpull_request:3317988022
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/61960/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a4ca61a729a59ffef2dea9ad0b96f98bc1fbfa16882e2261e4cf8c71702ba1d4/nodejs/node/pull/61960
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a4ca61a729a59ffef2dea9ad0b96f98bc1fbfa16882e2261e4cf8c71702ba1d4/nodejs/node/pull/61960
og:image:altSummary return early in src/node_task_queue.cc for kPromiseResolveAfterResolved and kPromiseRejectAfterResolved avoid invoking the JS promise reject callback for event types that JS-side logic alr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejorgitin02
hostnamegithub.com
expected-hostnamegithub.com
None9f8758a3953dfe943439713a6fa4f90d542a3431f10e861ca03dd7f39009f320
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebffd5484f01713a661b03469b77678f72b6574ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/61960#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61960
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61960
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/61960
Reloadhttps://github.com/nodejs/node/pull/61960
Reloadhttps://github.com/nodejs/node/pull/61960
Please reload this pagehttps://github.com/nodejs/node/pull/61960
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/61960
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jorgitin02https://github.com/jorgitin02
nodejs:mainhttps://github.com/nodejs/node/tree/main
jorgitin02:fix/51452-promise-race-memory-leakhttps://github.com/jorgitin02/node/tree/fix/51452-promise-race-memory-leak
Conversationhttps://github.com/nodejs/node/pull/61960
Commits1 (1)https://github.com/nodejs/node/pull/61960/commits
Checkshttps://github.com/nodejs/node/pull/61960/checks
Files changedhttps://github.com/nodejs/node/pull/61960/files
src: avoid JS callback for deprecated Promise resolve-after-resolved eventshttps://github.com/nodejs/node/pull/61960#top
jorgitin02https://github.com/jorgitin02
nodejs:mainhttps://github.com/nodejs/node/tree/main
jorgitin02:fix/51452-promise-race-memory-leakhttps://github.com/jorgitin02/node/tree/fix/51452-promise-race-memory-leak
https://github.com/jorgitin02
jorgitin02https://github.com/jorgitin02
Feb 23, 2026https://github.com/nodejs/node/pull/61960#issue-3980511348
#51452https://github.com/nodejs/node/issues/51452
Please reload this pagehttps://github.com/nodejs/node/pull/61960
https://github.com/jorgitin02
src: prevent memory leak from Promise.race with immediate resolveshttps://github.com/nodejs/node/pull/61960/commits/0aa15193284f6fd3987588d40abd9a2820729ae0
0aa1519https://github.com/nodejs/node/pull/61960/commits/0aa15193284f6fd3987588d40abd9a2820729ae0
#51452https://github.com/nodejs/node/issues/51452
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Feb 23, 2026https://github.com/nodejs/node/pull/61960#event-23015633755
https://github.com/jorgitin02
jorgitin02https://github.com/jorgitin02
Feb 26, 2026https://github.com/nodejs/node/pull/61960#event-23089069897
Felipenesshttps://github.com/Felipeness
Mar 19, 2026 https://github.com/nodejs/node/pull/61960#ref-commit-debf239
https://github.com/Felipeness
fix: skip JS callback for settled Promise.race losershttps://github.com/Felipeness/node/commit/debf2395e12a2aa066238d6c90db0a0f18acce72
debf239https://github.com/Felipeness/node/commit/debf2395e12a2aa066238d6c90db0a0f18acce72
nodejs#58707https://github.com/nodejs/node/pull/58707
nodejs#51452https://github.com/nodejs/node/issues/51452
nodejs#60184https://github.com/nodejs/node/pull/60184
nodejs#61960https://github.com/nodejs/node/pull/61960
https://github.com/Felipeness
Felipenesshttps://github.com/Felipeness
Mar 19, 2026 https://github.com/nodejs/node/pull/61960#ref-pullrequest-4101455765
src: skip JS callback for settled Promise.race losers #62336 https://github.com/nodejs/node/pull/62336
Felipenesshttps://github.com/Felipeness
Mar 19, 2026 https://github.com/nodejs/node/pull/61960#ref-commit-7033537
https://github.com/Felipeness
fix: skip JS callback for settled Promise.race losershttps://github.com/Felipeness/node/commit/7033537a17ff22c18a94a3057464143123fba12f
7033537https://github.com/Felipeness/node/commit/7033537a17ff22c18a94a3057464143123fba12f
nodejs#58707https://github.com/nodejs/node/pull/58707
nodejs#51452https://github.com/nodejs/node/issues/51452
nodejs#60184https://github.com/nodejs/node/pull/60184
nodejs#61960https://github.com/nodejs/node/pull/61960
jasnellhttps://github.com/jasnell
May 6, 2026 https://github.com/nodejs/node/pull/61960#ref-commit-1aebbde
https://github.com/Felipeness
https://github.com/jasnell
src: skip JS callback for settled Promise.race losershttps://github.com/nodejs/node/commit/1aebbdef06065cef6566525ca4a042ffb8fb5308
1aebbdehttps://github.com/nodejs/node/commit/1aebbdef06065cef6566525ca4a042ffb8fb5308
#58707https://github.com/nodejs/node/pull/58707
#51452https://github.com/nodejs/node/issues/51452
#60184https://github.com/nodejs/node/pull/60184
#61960https://github.com/nodejs/node/pull/61960
#62336https://github.com/nodejs/node/pull/62336
#51452https://github.com/nodejs/node/issues/51452
aduh95https://github.com/aduh95
May 19, 2026 https://github.com/nodejs/node/pull/61960#ref-commit-31a1ce4
https://github.com/Felipeness
https://github.com/aduh95
src: skip JS callback for settled Promise.race losershttps://github.com/nodejs/node/commit/31a1ce4cc0d791f0de258cd42c732db38e749cc6
31a1ce4https://github.com/nodejs/node/commit/31a1ce4cc0d791f0de258cd42c732db38e749cc6
#58707https://github.com/nodejs/node/pull/58707
#51452https://github.com/nodejs/node/issues/51452
#60184https://github.com/nodejs/node/pull/60184
#61960https://github.com/nodejs/node/pull/61960
#62336https://github.com/nodejs/node/pull/62336
#51452https://github.com/nodejs/node/issues/51452
aduh95https://github.com/aduh95
May 19, 2026 https://github.com/nodejs/node/pull/61960#ref-commit-7703f11
https://github.com/Felipeness
https://github.com/aduh95
src: skip JS callback for settled Promise.race losershttps://github.com/nodejs/node/commit/7703f11b3cb9ebe591e43ced4311fd227015e601
7703f11https://github.com/nodejs/node/commit/7703f11b3cb9ebe591e43ced4311fd227015e601
#58707https://github.com/nodejs/node/pull/58707
#51452https://github.com/nodejs/node/issues/51452
#60184https://github.com/nodejs/node/pull/60184
#61960https://github.com/nodejs/node/pull/61960
#62336https://github.com/nodejs/node/pull/62336
#51452https://github.com/nodejs/node/issues/51452
araujoguihttps://github.com/araujogui
May 26, 2026 https://github.com/nodejs/node/pull/61960#ref-commit-8138302
https://github.com/Felipeness
https://github.com/araujogui
src: skip JS callback for settled Promise.race losershttps://github.com/araujogui/node/commit/8138302545a2fb20ecc2b8932ccfc9608b6ce22d
8138302https://github.com/araujogui/node/commit/8138302545a2fb20ecc2b8932ccfc9608b6ce22d
nodejs#58707https://github.com/nodejs/node/pull/58707
nodejs#51452https://github.com/nodejs/node/issues/51452
nodejs#60184https://github.com/nodejs/node/pull/60184
nodejs#61960https://github.com/nodejs/node/pull/61960
nodejs#62336https://github.com/nodejs/node/pull/62336
nodejs#51452https://github.com/nodejs/node/issues/51452
sxahttps://github.com/sxa
Jun 18, 2026 https://github.com/nodejs/node/pull/61960#ref-commit-a37cb94
https://github.com/Felipeness
https://github.com/sxa
src: skip JS callback for settled Promise.race losershttps://github.com/sxa/node/commit/a37cb94d4f2c4311424f01e10393a3bb2082bf03
a37cb94https://github.com/sxa/node/commit/a37cb94d4f2c4311424f01e10393a3bb2082bf03
nodejs#58707https://github.com/nodejs/node/pull/58707
nodejs#51452https://github.com/nodejs/node/issues/51452
nodejs#60184https://github.com/nodejs/node/pull/60184
nodejs#61960https://github.com/nodejs/node/pull/61960
nodejs#62336https://github.com/nodejs/node/pull/62336
nodejs#51452https://github.com/nodejs/node/issues/51452
sxahttps://github.com/sxa
Jun 18, 2026 https://github.com/nodejs/node/pull/61960#ref-commit-929f6a9
https://github.com/Felipeness
https://github.com/sxa
src: skip JS callback for settled Promise.race losershttps://github.com/sxa/node/commit/929f6a9a28954c0090cd5f7a731da1f3fc5b9a1f
929f6a9https://github.com/sxa/node/commit/929f6a9a28954c0090cd5f7a731da1f3fc5b9a1f
nodejs#58707https://github.com/nodejs/node/pull/58707
nodejs#51452https://github.com/nodejs/node/issues/51452
nodejs#60184https://github.com/nodejs/node/pull/60184
nodejs#61960https://github.com/nodejs/node/pull/61960
nodejs#62336https://github.com/nodejs/node/pull/62336
nodejs#51452https://github.com/nodejs/node/issues/51452
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61960
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/61960
https://github.com/jorgitin02
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.