| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e3b2860b-b017-825e-1ecb-cff332da2c3e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C6E6:3E6EAA:3F78498:5886B21:6A4F5CC2 |
| html-safe-nonce | efb314095d88bd381919a148b32e67632684206ff15be2f0eaa4cf86fc18c4df |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkU2OjNFNkVBQTozRjc4NDk4OjU4ODZCMjE6NkE0RjVDQzIiLCJ2aXNpdG9yX2lkIjoiMjAwMjIxNjQxNDAzOTk4OTQ0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2498f658de6fe7812e1a61236561ebcef927da90ae4255b702d8c5ac36f5df56 |
| hovercard-subject-tag | pull_request:3287681636 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/61845/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8d6e200d2ce6129b9818e30ac2f36b7ad9ce353f98bde4809e7d05e8ee0324d5/nodejs/node/pull/61845 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8d6e200d2ce6129b9818e30ac2f36b7ad9ce353f98bde4809e7d05e8ee0324d5/nodejs/node/pull/61845 |
| og:image:alt | Fixes: #61586
Summary
When a branch is entirely on ignored lines (via c8 ignore comments), it should not appear in the BRDA output at all, rather than appearing with 0 coverage.
Changes
Modified th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | drtootsie |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/61845#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61845 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61845 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/61845 |
| Reload | https://github.com/nodejs/node/pull/61845 |
| Reload | https://github.com/nodejs/node/pull/61845 |
| Please reload this page | https://github.com/nodejs/node/pull/61845 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/61845 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
970
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| drtootsie | https://github.com/drtootsie |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| drtootsie:fix-coverage-ignore-branches | https://github.com/drtootsie/node/tree/fix-coverage-ignore-branches |
| Conversation | https://github.com/nodejs/node/pull/61845 |
| Commits1 (1) | https://github.com/nodejs/node/pull/61845/commits |
| Checks | https://github.com/nodejs/node/pull/61845/checks |
| Files changed | https://github.com/nodejs/node/pull/61845/files |
| test_runner: skip branches entirely on ignored lines | https://github.com/nodejs/node/pull/61845#top |
| drtootsie | https://github.com/drtootsie |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| drtootsie:fix-coverage-ignore-branches | https://github.com/drtootsie/node/tree/fix-coverage-ignore-branches |
|
| https://github.com/drtootsie |
| drtootsie | https://github.com/drtootsie |
| Feb 15, 2026 | https://github.com/nodejs/node/pull/61845#issue-3945073307 |
| #61586 | https://github.com/nodejs/node/issues/61586 |
| Please reload this page | https://github.com/nodejs/node/pull/61845 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 15, 2026 | https://github.com/nodejs/node/pull/61845#issuecomment-3905315992 |
| Please reload this page | https://github.com/nodejs/node/pull/61845 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
test_runner
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner |
| Feb 15, 2026 | https://github.com/nodejs/node/pull/61845#event-22809726950 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Feb 16, 2026
| https://github.com/nodejs/node/pull/61845#ref-pullrequest-3945073500 |
|
test: make snapshot path matching CWD-agnostic
#61846
| https://github.com/nodejs/node/pull/61846 |
| https://github.com/pmarchini |
| pmarchini | https://github.com/pmarchini |
|
Feb 16, 2026
| https://github.com/nodejs/node/pull/61845#pullrequestreview-3808063945 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/61845/files |
| lib/internal/test_runner/coverage.js | https://github.com/nodejs/node/pull/61845/files#diff-0e00da74475521ee48fdbfb1d8e6a6a7458bc8c70957e39b6fa1b0213509fa4d |
| pmarchini | https://github.com/pmarchini |
| Feb 16, 2026 | https://github.com/nodejs/node/pull/61845#discussion_r2811933031 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/61845 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Feb 24, 2026 | https://github.com/nodejs/node/pull/61845#issuecomment-3949874368 |
| Please reload this page | https://github.com/nodejs/node/pull/61845 |
| #61598 | https://github.com/nodejs/node/pull/61598 |
| Please reload this page | https://github.com/nodejs/node/pull/61845 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
duplicate
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aduplicate |
| Feb 24, 2026 | https://github.com/nodejs/node/pull/61845#event-23050156625 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
Feb 24, 2026
| https://github.com/nodejs/node/pull/61845#ref-pullrequest-3878988415 |
|
test_runner: exclude ignored lines from BRDA in lcov output
#61598
| https://github.com/nodejs/node/pull/61598 |
|
| https://github.com/drtootsie |
| test_runner: skip branches entirely on ignored lines | https://github.com/nodejs/node/pull/61845/commits/06c7fa2f3a5a784c0beab1a8083660bbd15ac04c |
| 06c7fa2 | https://github.com/nodejs/node/pull/61845/commits/06c7fa2f3a5a784c0beab1a8083660bbd15ac04c |
| nodejs#61586 | https://github.com/nodejs/node/issues/61586 |
| https://github.com/drtootsie |
| drtootsie | https://github.com/drtootsie |
| force-pushed | https://github.com/nodejs/node/compare/7911b51f398332307f468ee23d38447297d381e8..06c7fa2f3a5a784c0beab1a8083660bbd15ac04c |
| 7911b51 | https://github.com/nodejs/node/commit/7911b51f398332307f468ee23d38447297d381e8 |
| 06c7fa2 | https://github.com/nodejs/node/commit/06c7fa2f3a5a784c0beab1a8083660bbd15ac04c |
|
Compare
| https://github.com/nodejs/node/compare/7911b51f398332307f468ee23d38447297d381e8..06c7fa2f3a5a784c0beab1a8083660bbd15ac04c |
| March 11, 2026 02:51 | https://github.com/nodejs/node/pull/61845#event-23453921342 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| #61598 | https://github.com/nodejs/node/pull/61598 |
| Mar 11, 2026 | https://github.com/nodejs/node/pull/61845#event-23484984876 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Jun 17, 2026 | https://github.com/nodejs/node/pull/61845#event-26851412886 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61845 |
|
| https://github.com/pmarchini |
|
pmarchini
| https://github.com/pmarchini |
|
| https://github.com/nodejs/node/pull/61845/files/7911b51f398332307f468ee23d38447297d381e8 |
|
duplicate
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aduplicate |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
test_runner
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner |
|
test_runner: node:coverage ignore comments exclude DA but leave BRDA in lcov output
| https://github.com/nodejs/node/issues/61586 |
| Please reload this page | https://github.com/nodejs/node/pull/61845 |
|
| https://github.com/drtootsie |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/pmarchini |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |