René's URL Explorer Experiment

Title: esm: detect ESM syntax in extensionless files under type:commonjs by scott-memco · Pull Request #61737 · nodejs/node · GitHub

Open Graph Title: esm: detect ESM syntax in extensionless files under type:commonjs by scott-memco · Pull Request #61737 · nodejs/node

X Title: esm: detect ESM syntax in extensionless files under type:commonjs by scott-memco · Pull Request #61737 · nodejs/node

Description: Summary Fixes a silent failure where extensionless files containing ES module syntax produce no output and exit with code 0 when the nearest package.json has "type": "commonjs". This is a common scenario for CLI tools that use shebangs (#!/usr/bin/env node) without a file extension. Reproduction echo '{ "type": "commonjs" }' > package.json printf '#!/usr/bin/env node\nconsole.log("started")\nimport { version } from "node:process"\nconsole.log(version)\n' > script chmod +x script ./script ; echo "exit: $?" # Output: exit: 0 # Expected: either the script runs, or an error is printed Root Cause In lib/internal/modules/esm/get_format.js, getFileProtocolModuleFormat() handles extensionless files (line 159-177). When packageType is 'commonjs', it returns 'commonjs' immediately without checking the file content for ESM syntax (line 164-165). This causes the ESM loader to treat the file as a CJS module, routing it through createCJSModuleWrap in the translators, which wraps the ESM code as CJS — silently producing an empty/non-functional module. Compare with: The 'none' (no type field) case for extensionless files, which does call detectModuleFormat(source, url) at line 176 The .js extension case with no type field, which does call detectModuleFormat(source, url) at line 127 Fix For extensionless files when packageType !== 'none' (i.e., explicitly 'commonjs'), check the source content via detectModuleFormat() before returning the package type. If the file contains ES module syntax, return 'module' so it's loaded correctly. if (packageType !== 'none') { if (source) { const detected = detectModuleFormat(source, url); if (detected === 'module') { return detected; } } return packageType; } This is consistent with how ambiguous files are already handled elsewhere in the same function, and relies on the existing containsModuleSyntax V8 binding (used by detectModuleFormat) which is already enabled by default via --experimental-detect-module. Test test/parallel/test-esm-extensionless-commonjs-type.js — creates an extensionless ESM file in a type: commonjs project, runs it, and asserts it does not silently exit with code 0. Fixes: #61104 Made with Cursor

Open Graph Description: Summary Fixes a silent failure where extensionless files containing ES module syntax produce no output and exit with code 0 when the nearest package.json has "type": "commonjs"....

X Description: Summary Fixes a silent failure where extensionless files containing ES module syntax produce no output and exit with code 0 when the nearest package.json has "type": "com...

Opengraph URL: https://github.com/nodejs/node/pull/61737

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width