René's URL Explorer Experiment


Title: stream: make null an invalid chunk to write in object mode by calvinmetcalf · Pull Request #6170 · nodejs/node · GitHub

Open Graph Title: stream: make null an invalid chunk to write in object mode by calvinmetcalf · Pull Request #6170 · nodejs/node

X Title: stream: make null an invalid chunk to write in object mode by calvinmetcalf · Pull Request #6170 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist tests and code linting passes a test and/or benchmark is included documentation is changed or added (current documentation implies this behavior) the commit message follows commit g...

X Description: Checklist tests and code linting passes a test and/or benchmark is included documentation is changed or added (current documentation implies this behavior) the commit message follows commit g...

Mail addresses
notifications@github.com

Opengraph URL: https://github.com/nodejs/node/pull/6170

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:287a59e7-bcb3-50d8-96a8-cf355e324d86
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4BC:A3A4:2AB8BA:3F2421:6AED325C
html-safe-noncec0eebaeb2d3fcb54e0e16013b0069b1c742638b96bbc0a09f7d6c3ea637edb40
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEJDOkEzQTQ6MkFCOEJBOjNGMjQyMTo2QUVEMzI1QyIsInZpc2l0b3JfaWQiOiI4OTU1MjkyOTc0NzM5OTYwNDEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac91582accb63c6bf3b85746a7895810aaba6be82f721170790dd5403407928e1f
hovercard-subject-tagpull_request:66216452
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/6170/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9facd35950515d96b9389e45e9a21d6a044882afa925c3a989b5d44ad6cb18f1/nodejs/node/pull/6170
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9facd35950515d96b9389e45e9a21d6a044882afa925c3a989b5d44ad6cb18f1/nodejs/node/pull/6170
og:image:altChecklist tests and code linting passes a test and/or benchmark is included documentation is changed or added (current documentation implies this behavior) the commit message follows commit g...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecalvinmetcalf
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/6170#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6170
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6170
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/6170
Reloadhttps://github.com/nodejs/node/pull/6170
Reloadhttps://github.com/nodejs/node/pull/6170
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
calvinmetcalfhttps://github.com/calvinmetcalf
nodejs:masterhttps://github.com/nodejs/node/tree/master
calvinmetcalf:fail-write-nullhttps://github.com/calvinmetcalf/io.js/tree/fail-write-null
Conversationhttps://github.com/nodejs/node/pull/6170
Commits1 (1)https://github.com/nodejs/node/pull/6170/commits
Checkshttps://github.com/nodejs/node/pull/6170/checks
Files changedhttps://github.com/nodejs/node/pull/6170/files
stream: make null an invalid chunk to write in object modehttps://github.com/nodejs/node/pull/6170#top
calvinmetcalfhttps://github.com/calvinmetcalf
nodejs:masterhttps://github.com/nodejs/node/tree/master
calvinmetcalf:fail-write-nullhttps://github.com/calvinmetcalf/io.js/tree/fail-write-null
https://github.com/calvinmetcalf
calvinmetcalfhttps://github.com/calvinmetcalf
Apr 12, 2016https://github.com/nodejs/node/pull/6170#issue-147854829
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/calvinmetcalf
calvinmetcalfhttps://github.com/calvinmetcalf
force-pushedhttps://github.com/nodejs/node/compare/7f3a0cb10ce29ceb8102d1028a5b3e31f36b08f7..85454ee9ef80410932a026089d4be702b7ed91b8
7f3a0cbhttps://github.com/nodejs/node/commit/7f3a0cb10ce29ceb8102d1028a5b3e31f36b08f7
85454eehttps://github.com/nodejs/node/commit/85454ee9ef80410932a026089d4be702b7ed91b8
Compare https://github.com/nodejs/node/compare/7f3a0cb10ce29ceb8102d1028a5b3e31f36b08f7..85454ee9ef80410932a026089d4be702b7ed91b8
April 12, 2016 19:47https://github.com/nodejs/node/pull/6170#event-624710513
https://github.com/mscdex
mscdexhttps://github.com/mscdex
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Apr 12, 2016https://github.com/nodejs/node/pull/6170#event-624723487
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Apr 12, 2016https://github.com/nodejs/node/pull/6170#issuecomment-209078848
https://ci.nodejs.org/job/node-test-pull-request/2249/https://ci.nodejs.org/job/node-test-pull-request/2249/
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 12, 2016https://github.com/nodejs/node/pull/6170#issuecomment-209087826
@calvinmetcalfhttps://github.com/calvinmetcalf
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/calvinmetcalf
calvinmetcalfhttps://github.com/calvinmetcalf
Apr 12, 2016https://github.com/nodejs/node/pull/6170#issuecomment-209095460
@calvinmetcalfhttps://github.com/calvinmetcalf
https://github.com/calvinmetcalfhttps://github.com/calvinmetcalf
#6170 (comment)https://github.com/nodejs/node/pull/6170#issuecomment-209087826
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/calvinmetcalf
calvinmetcalfhttps://github.com/calvinmetcalf
Apr 12, 2016https://github.com/nodejs/node/pull/6170#issuecomment-209108328
@Fishrock123https://github.com/Fishrock123
https://www.youtube.com/watch?v=4cVLul6gPpAhttps://www.youtube.com/watch?v=4cVLul6gPpA
Please reload this pagehttps://github.com/nodejs/node/pull/6170
jasnellhttps://github.com/jasnell
Apr 13, 2016 https://github.com/nodejs/node/pull/6170#discussion-diff-59487718
View reviewed changes https://github.com/nodejs/node/pull/6170/files#diff-eb5de37b79d210ce2e60af76f9fa9acbfa6ec69dcc93fcab90e38205620e6ed2
test/parallel/test-stream-writable-null.jshttps://github.com/nodejs/node/pull/6170/files#diff-eb5de37b79d210ce2e60af76f9fa9acbfa6ec69dcc93fcab90e38205620e6ed2
jasnellhttps://github.com/jasnell
Apr 13, 2016https://github.com/nodejs/node/pull/6170#discussion_r59487718
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 13, 2016https://github.com/nodejs/node/pull/6170#issuecomment-209208080
Please reload this pagehttps://github.com/nodejs/node/pull/6170
mcollinahttps://github.com/mcollina
Apr 13, 2016 https://github.com/nodejs/node/pull/6170#discussion-diff-59500881
View reviewed changes https://github.com/nodejs/node/pull/6170/files#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3
lib/_stream_writable.jshttps://github.com/nodejs/node/pull/6170/files#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3
mcollinahttps://github.com/mcollina
Apr 13, 2016https://github.com/nodejs/node/pull/6170#discussion_r59500881
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/6170
calvinmetcalfhttps://github.com/calvinmetcalf
Apr 13, 2016https://github.com/nodejs/node/pull/6170#discussion_r59542552
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Apr 13, 2016https://github.com/nodejs/node/pull/6170#issuecomment-209262687
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/calvinmetcalf
calvinmetcalfhttps://github.com/calvinmetcalf
force-pushedhttps://github.com/nodejs/node/compare/85454ee9ef80410932a026089d4be702b7ed91b8..94e0df5b6cba5a663bb70e099f18d2d06444815a
85454eehttps://github.com/nodejs/node/commit/85454ee9ef80410932a026089d4be702b7ed91b8
94e0df5https://github.com/nodejs/node/commit/94e0df5b6cba5a663bb70e099f18d2d06444815a
Compare https://github.com/nodejs/node/compare/85454ee9ef80410932a026089d4be702b7ed91b8..94e0df5b6cba5a663bb70e099f18d2d06444815a
April 13, 2016 14:12https://github.com/nodejs/node/pull/6170#event-625837460
https://github.com/calvinmetcalf
calvinmetcalfhttps://github.com/calvinmetcalf
Apr 13, 2016https://github.com/nodejs/node/pull/6170#issuecomment-209465626
Please reload this pagehttps://github.com/nodejs/node/pull/6170
jasnellhttps://github.com/jasnell
Apr 13, 2016 https://github.com/nodejs/node/pull/6170#discussion-diff-59564623
View reviewed changes https://github.com/nodejs/node/pull/6170/files#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3
lib/_stream_writable.jshttps://github.com/nodejs/node/pull/6170/files#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3
jasnellhttps://github.com/jasnell
Apr 13, 2016https://github.com/nodejs/node/pull/6170#discussion_r59564623
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Apr 13, 2016https://github.com/nodejs/node/pull/6170#issuecomment-209500107
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/calvinmetcalf
stream: make null an invalid chunk to write in object modehttps://github.com/nodejs/node/pull/6170/commits/401ff75945d39b28b26c4e54863f312b19c0a2dd
401ff75https://github.com/nodejs/node/pull/6170/commits/401ff75945d39b28b26c4e54863f312b19c0a2dd
https://github.com/calvinmetcalf
calvinmetcalfhttps://github.com/calvinmetcalf
force-pushedhttps://github.com/nodejs/node/compare/94e0df5b6cba5a663bb70e099f18d2d06444815a..401ff75945d39b28b26c4e54863f312b19c0a2dd
94e0df5https://github.com/nodejs/node/commit/94e0df5b6cba5a663bb70e099f18d2d06444815a
401ff75https://github.com/nodejs/node/commit/401ff75945d39b28b26c4e54863f312b19c0a2dd
Compare https://github.com/nodejs/node/compare/94e0df5b6cba5a663bb70e099f18d2d06444815a..401ff75945d39b28b26c4e54863f312b19c0a2dd
April 13, 2016 16:34https://github.com/nodejs/node/pull/6170#event-626062925
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 18, 2016https://github.com/nodejs/node/pull/6170#issuecomment-211604403
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 18, 2016https://github.com/nodejs/node/pull/6170#issuecomment-211610339
https://ci.nodejs.org/job/thealphanerd-smoker/199/https://ci.nodejs.org/job/thealphanerd-smoker/199/
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Apr 19, 2016https://github.com/nodejs/node/pull/6170#issuecomment-211780708
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 20, 2016https://github.com/nodejs/node/pull/6170#issuecomment-212510368
@thealphanerdhttps://github.com/thealphanerd
75487f0https://github.com/nodejs/node/commit/75487f0db80e70a3e27fabfe323a33258dfbbea8
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 20, 2016https://github.com/nodejs/node/pull/6170#issuecomment-212538559
https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/204/https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/204/
Please reload this pagehttps://github.com/nodejs/node/pull/6170
jasnellhttps://github.com/jasnell
Apr 20, 2016 https://github.com/nodejs/node/pull/6170#ref-commit-e7c077c
https://github.com/calvinmetcalf
https://github.com/jasnell
stream: make null an invalid chunk to write in object modehttps://github.com/nodejs/node/commit/e7c077c610afa371430180fbd447bfef60ebc5ea
e7c077chttps://github.com/nodejs/node/commit/e7c077c610afa371430180fbd447bfef60ebc5ea
#6170https://github.com/nodejs/node/pull/6170
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 20, 2016https://github.com/nodejs/node/pull/6170#issuecomment-212596552
e7c077chttps://github.com/nodejs/node/commit/e7c077c610afa371430180fbd447bfef60ebc5ea
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 20, 2016https://github.com/nodejs/node/pull/6170#event-635149373
joelostrowskihttps://github.com/joelostrowski
Apr 25, 2016 https://github.com/nodejs/node/pull/6170#ref-commit-70b7bc3
https://github.com/calvinmetcalf
https://github.com/joelostrowski
stream: make null an invalid chunk to write in object modehttps://github.com/joelostrowski/node/commit/70b7bc370d917c431d7bad42fd2bc850a6b9c99c
70b7bc3https://github.com/joelostrowski/node/commit/70b7bc370d917c431d7bad42fd2bc850a6b9c99c
nodejs#6170https://github.com/nodejs/node/pull/6170
jasnellhttps://github.com/jasnell
Apr 26, 2016 https://github.com/nodejs/node/pull/6170#ref-commit-c0abecd
https://github.com/calvinmetcalf
https://github.com/jasnell
stream: make null an invalid chunk to write in object modehttps://github.com/nodejs/node/commit/c0abecdaf32e84a7922dc149286b4434acf48885
c0abecdhttps://github.com/nodejs/node/commit/c0abecdaf32e84a7922dc149286b4434acf48885
#6170https://github.com/nodejs/node/pull/6170
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6170
Please reload this pagehttps://github.com/nodejs/node/pull/6170
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/6170
https://github.com/calvinmetcalf
https://github.com/mscdex
https://github.com/Fishrock123
https://github.com/jasnell
https://github.com/mcollina
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.