René's URL Explorer Experiment

Title: src: consolidate C++ ReadFileSync/WriteFileSync utilities by joyeecheung · Pull Request #61662 · nodejs/node · GitHub

Open Graph Title: src: consolidate C++ ReadFileSync/WriteFileSync utilities by joyeecheung · Pull Request #61662 · nodejs/node

X Title: src: consolidate C++ ReadFileSync/WriteFileSync utilities by joyeecheung · Pull Request #61662 · nodejs/node

Description: This patch moves ReadFileSync and WriteFileSync from src/util.cc to src/node_file_utils.cc, consolidates the implementation to reuse code, and adds a few more enhancements: For ReadFileSync: Use fstat-based pre-allocation to minimize buffer resizing and repeated reads for bigger files. Handle various potential overflows in size conversions. Handle fallback for 0-byte special files. For WriteFileSync: Handle potential partial writes for big enough files and support non-seekable files (with -1 as offset). Handle 0-byte writes correctly. In both cases, this now avoids hard aborts and return error code for the caller to handle as much as possible, except std::vector ReadFileSync(FILE* fp) which is part of the embedder API. This patch uses the new ReadFileSync to address a TODO in node_sea.bin.cc. Some numbers from --build-sea (note that most of the time is spent on parsing the executable and building the SEA, but even so there's a measurable difference just from the file I/O because the binary is ~120MB). $ hyperfine "out/Release/node --build-sea sea-config.json" "./node_main --build-sea sea-config.json" --warmup 5 Benchmark 1: out/Release/node --build-sea sea-config.json Time (mean ± σ): 1.696 s ± 0.040 s [User: 1.509 s, System: 0.173 s] Range (min … max): 1.651 s … 1.756 s 10 runs Benchmark 2: ./node_main --build-sea sea-config.json Time (mean ± σ): 1.730 s ± 0.030 s [User: 1.530 s, System: 0.183 s] Range (min … max): 1.681 s … 1.787 s 10 runs Summary out/Release/node --build-sea sea-config.json ran 1.02 ± 0.03 times faster than ./node_main --build-sea sea-config.json

Open Graph Description: This patch moves ReadFileSync and WriteFileSync from src/util.cc to src/node_file_utils.cc, consolidates the implementation to reuse code, and adds a few more enhancements: For ReadFileSync: Use f...

X Description: This patch moves ReadFileSync and WriteFileSync from src/util.cc to src/node_file_utils.cc, consolidates the implementation to reuse code, and adds a few more enhancements: For ReadFileSync: Use f...

Opengraph URL: https://github.com/nodejs/node/pull/61662

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width