Title: stream: rename `Duplex.toWeb()` type option to `readableType` by Renegade334 · Pull Request #61632 · nodejs/node · GitHub
Open Graph Title: stream: rename `Duplex.toWeb()` type option to `readableType` by Renegade334 · Pull Request #61632 · nodejs/node
X Title: stream: rename `Duplex.toWeb()` type option to `readableType` by Renegade334 · Pull Request #61632 · nodejs/node
Description: The webstreams standard uses the name readableType for a source property which specifies the type of the readable component of a constructed readable-writable pair.1 Although this is only future-proofed nomenclature at the moment, we should probably follow this convention here, for consistency and just in case we also need to support WritableStream types in the future. This paradigm would also be consistent with Duplex.toWeb() taking readableStrategy and writableStrategy options in the future, if so desired. Because Duplex.toWeb() is no longer marked as experimental, I believe that removing options.type entirely would need a full deprecation cycle, so I've just turned it into a silent alias for simplicity. Refs: #58664 Footnotes https://streams.spec.whatwg.org/#dictdef-transformer ↩
Open Graph Description: The webstreams standard uses the name readableType for a source property which specifies the type of the readable component of a constructed readable-writable pair.1 Although this is only future-pr...
X Description: The webstreams standard uses the name readableType for a source property which specifies the type of the readable component of a constructed readable-writable pair.1 Although this is only future-pr...
Opengraph URL: https://github.com/nodejs/node/pull/61632
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3fa494cd-f633-ddbf-9a43-8052fc5f388d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D396:3BA192:C0FE5C:10CC6FC:6A4BDEB6 |
| html-safe-nonce | 7585b2cf851724c516a662562887b9ddde8448a660d8c4aea14ad38cbad13d70 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzk2OjNCQTE5MjpDMEZFNUM6MTBDQzZGQzo2QTRCREVCNiIsInZpc2l0b3JfaWQiOiI1ODIyMjkzNDE1MjUzNzYxNzE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 66b74cd55465a5151b72fa91a29b4621cbb75d340058374442b35dc7fdaeaf9d |
| hovercard-subject-tag | pull_request:3234471224 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/61632/files |
| twitter:image | https://avatars.githubusercontent.com/u/9092381?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/9092381?s=400&v=4 |
| og:image:alt | The webstreams standard uses the name readableType for a source property which specifies the type of the readable component of a constructed readable-writable pair.1 Although this is only future-pr... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0f5d3ba365b3985d75c32a5957c8635488d58dcf027ae6ae958eee7edaa306a2 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 253920ac2dc35b0849cca4633895f1f2e5f03051 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width