René's URL Explorer Experiment


Title: test: fix flaky test-performance-eventloopdelay by mcollina · Pull Request #61629 · nodejs/node · GitHub

Open Graph Title: test: fix flaky test-performance-eventloopdelay by mcollina · Pull Request #61629 · nodejs/node

X Title: test: fix flaky test-performance-eventloopdelay by mcollina · Pull Request #61629 · nodejs/node

Description: Summary Fixes flaky test test/sequential/test-performance-eventloopdelay.js The test was failing intermittently on IBM sharedlibs containers Problem The test was flaky because the histogram sampling might not have completed before the assertions ran. The assertion assert(histogram.min > 0) could fail if no samples were recorded yet. Solution Wrapped the assertions in setImmediate(common.mustCall(() => {...})) to give the event loop a chance to record final samples before checking Added an explicit check for histogram.count > 0 to provide a clearer error message if no samples are recorded Verification Verified with python3 tools/test.py --repeat 50 without failures. Refs: nodejs/reliability#1450

Open Graph Description: Summary Fixes flaky test test/sequential/test-performance-eventloopdelay.js The test was failing intermittently on IBM sharedlibs containers Problem The test was flaky because the histogram sampl...

X Description: Summary Fixes flaky test test/sequential/test-performance-eventloopdelay.js The test was failing intermittently on IBM sharedlibs containers Problem The test was flaky because the histogram sampl...

Opengraph URL: https://github.com/nodejs/node/pull/61629

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b4ae8cc0-8a75-0494-c97a-0537296385fc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4BA:3E084C:1513ACE:1CBD13A:6A4C7CD0
html-safe-noncebe2d7d6c060e6059d8e50ec361d71aa2cf73b211db47ce773210714f199f706f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEJBOjNFMDg0QzoxNTEzQUNFOjFDQkQxM0E6NkE0QzdDRDAiLCJ2aXNpdG9yX2lkIjoiNDg1NTc2NjM2MTY0NzY0Mzg1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccc1d63feeb548c83ad802b6c9d341460c31c28d6131d21e68815c221a078813f
hovercard-subject-tagpull_request:3233858406
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/61629/files
twitter:imagehttps://avatars.githubusercontent.com/u/52195?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/52195?s=400&v=4
og:image:altSummary Fixes flaky test test/sequential/test-performance-eventloopdelay.js The test was failing intermittently on IBM sharedlibs containers Problem The test was flaky because the histogram sampl...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecd470457e909b9d062f8002cf438ba870e6acff6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/61629/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61629%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61629%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/61629/files
Reloadhttps://github.com/nodejs/node/pull/61629/files
Reloadhttps://github.com/nodejs/node/pull/61629/files
Please reload this pagehttps://github.com/nodejs/node/pull/61629/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/61629/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
mcollina:fix-flaky-test-performance-eventloopdelayhttps://github.com/mcollina/node/tree/fix-flaky-test-performance-eventloopdelay
Conversation 3 https://github.com/nodejs/node/pull/61629
Commits 1 https://github.com/nodejs/node/pull/61629/commits
Checks 47 https://github.com/nodejs/node/pull/61629/checks
Files changed https://github.com/nodejs/node/pull/61629/files
Please reload this pagehttps://github.com/nodejs/node/pull/61629/files
test: fix flaky test-performance-eventloopdelay https://github.com/nodejs/node/pull/61629/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/61629/files
25ea05c test: fix flaky test-performance-eventloopdelay mcollina Feb 1, 2026 https://github.com/nodejs/node/pull/61629/commits/25ea05c5c6e92c786d27d57c141c66b29ab82370
Clear filters https://github.com/nodejs/node/pull/61629/files
Please reload this pagehttps://github.com/nodejs/node/pull/61629/files
Please reload this pagehttps://github.com/nodejs/node/pull/61629/files
test/sequential/test-performance-eventloopdelay.jshttps://github.com/nodejs/node/pull/61629/files#diff-63f1b78a31827dfc4932cd19464faf0ccf12194e96a6dbd4f5a4e9eee64c77fb
View file https://github.com/mcollina/node/blob/25ea05c5c6e92c786d27d57c141c66b29ab82370/test/sequential/test-performance-eventloopdelay.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/61629/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/61629/files#diff-63f1b78a31827dfc4932cd19464faf0ccf12194e96a6dbd4f5a4e9eee64c77fb
https://github.com/nodejs/node/pull/61629/files#diff-63f1b78a31827dfc4932cd19464faf0ccf12194e96a6dbd4f5a4e9eee64c77fb
Please reload this pagehttps://github.com/nodejs/node/pull/61629/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.