René's URL Explorer Experiment


Title: repl: fix flaky test-repl-programmatic-history by mcollina · Pull Request #61614 · nodejs/node · GitHub

Open Graph Title: repl: fix flaky test-repl-programmatic-history by mcollina · Pull Request #61614 · nodejs/node

X Title: repl: fix flaky test-repl-programmatic-history by mcollina · Pull Request #61614 · nodejs/node

Description: Summary Fixes flaky test test/parallel/test-repl-programmatic-history.js. Problem The test was flaky because the FileHandle for the history file could be garbage collected before being explicitly closed, causing ERR_INVALID_STATE errors when the handle was already closed by the GC finalizer. Solution Added an explicit closeHandle() method to ReplHistory class Modified REPLServer.close() to wait for the history file handle to be properly closed before completing the close operation This ensures deterministic cleanup regardless of GC timing Verification Verified with python3 tools/test.py --repeat 1000 test/parallel/test-repl-programmatic-history.js - all 1000 runs passed with 0 failures. Refs: nodejs/reliability#1450

Open Graph Description: Summary Fixes flaky test test/parallel/test-repl-programmatic-history.js. Problem The test was flaky because the FileHandle for the history file could be garbage collected before being explicitly c...

X Description: Summary Fixes flaky test test/parallel/test-repl-programmatic-history.js. Problem The test was flaky because the FileHandle for the history file could be garbage collected before being explicitly c...

Opengraph URL: https://github.com/nodejs/node/pull/61614

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:04572322-7a2d-4303-e173-8a6042baf540
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF90:3A75DA:BA157F:FB84B8:6A4C52CD
html-safe-nonce5d36360437615b479466322cb5a8267d82521b8fb11941770734ad0e29248d93
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjkwOjNBNzVEQTpCQTE1N0Y6RkI4NEI4OjZBNEM1MkNEIiwidmlzaXRvcl9pZCI6IjIxMDM1ODY3MzQ2NzExNTU5MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1e6c996986fe9f0c42e30dc5c534867fa26d4ac76227e78dc0b94b859fd54f47
hovercard-subject-tagpull_request:3233272714
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/61614/files
twitter:imagehttps://avatars.githubusercontent.com/u/52195?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/52195?s=400&v=4
og:image:altSummary Fixes flaky test test/parallel/test-repl-programmatic-history.js. Problem The test was flaky because the FileHandle for the history file could be garbage collected before being explicitly c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release14099438da5379150f15a2892474c7c7e6c0e55e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/61614/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61614%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61614%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/61614/files
Reloadhttps://github.com/nodejs/node/pull/61614/files
Reloadhttps://github.com/nodejs/node/pull/61614/files
Please reload this pagehttps://github.com/nodejs/node/pull/61614/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/61614/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
mcollina:fix-flaky-test-repl-programmatic-historyhttps://github.com/mcollina/node/tree/fix-flaky-test-repl-programmatic-history
Conversation 8 https://github.com/nodejs/node/pull/61614
Commits 1 https://github.com/nodejs/node/pull/61614/commits
Checks 42 https://github.com/nodejs/node/pull/61614/checks
Files changed https://github.com/nodejs/node/pull/61614/files
Please reload this pagehttps://github.com/nodejs/node/pull/61614/files
repl: fix flaky test-repl-programmatic-history https://github.com/nodejs/node/pull/61614/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/61614/files
d715296 repl: fix flaky test-repl-programmatic-history mcollina Feb 1, 2026 https://github.com/nodejs/node/pull/61614/commits/d715296dfa4a97e7a4c1835a276f434d62a610aa
Clear filters https://github.com/nodejs/node/pull/61614/files
Please reload this pagehttps://github.com/nodejs/node/pull/61614/files
Please reload this pagehttps://github.com/nodejs/node/pull/61614/files
history.js https://github.com/nodejs/node/pull/61614/files#diff-6e4d0ac8c3464727bace437f66320b66535a6d3663100c71be558616aae74ae4
repl.js https://github.com/nodejs/node/pull/61614/files#diff-392b628f0a5eb047b1117351e6eedcefb8ec70a48933479e0e9bdc711a04f047
lib/internal/repl/history.jshttps://github.com/nodejs/node/pull/61614/files#diff-6e4d0ac8c3464727bace437f66320b66535a6d3663100c71be558616aae74ae4
View file https://github.com/mcollina/node/blob/d715296dfa4a97e7a4c1835a276f434d62a610aa/lib/internal/repl/history.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/61614/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/61614/files#diff-6e4d0ac8c3464727bace437f66320b66535a6d3663100c71be558616aae74ae4
https://github.com/nodejs/node/pull/61614/files#diff-6e4d0ac8c3464727bace437f66320b66535a6d3663100c71be558616aae74ae4
https://github.com/nodejs/node/pull/61614/files#diff-6e4d0ac8c3464727bace437f66320b66535a6d3663100c71be558616aae74ae4
https://github.com/nodejs/node/pull/61614/files#diff-6e4d0ac8c3464727bace437f66320b66535a6d3663100c71be558616aae74ae4
lib/repl.jshttps://github.com/nodejs/node/pull/61614/files#diff-392b628f0a5eb047b1117351e6eedcefb8ec70a48933479e0e9bdc711a04f047
View file https://github.com/mcollina/node/blob/d715296dfa4a97e7a4c1835a276f434d62a610aa/lib/repl.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/61614/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/61614/files#diff-392b628f0a5eb047b1117351e6eedcefb8ec70a48933479e0e9bdc711a04f047
https://github.com/nodejs/node/pull/61614/files#diff-392b628f0a5eb047b1117351e6eedcefb8ec70a48933479e0e9bdc711a04f047
Please reload this pagehttps://github.com/nodejs/node/pull/61614/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.