Title: lib: add utf16 fast path for TextDecoder by ChALkeR · Pull Request #61559 · nodejs/node · GitHub
Open Graph Title: lib: add utf16 fast path for TextDecoder by ChALkeR · Pull Request #61559 · nodejs/node
X Title: lib: add utf16 fast path for TextDecoder by ChALkeR · Pull Request #61559 · nodejs/node
Description: Tracking: #61041 Better reviewed with whitespace hidden. Builds on top of #61549 Like that PR, this is based on the logic in https://github.com/ExodusOSS/bytes Previously, ICU and string_decoder were used on with-intl and without-intl variants correspondingly for UTF-16 implementation. ICU path was slow, string_decoder path was wrong and lacked BE anyway. Instead, just use the codepath from #61549 with simple UTF-16 decoding methods. This: Speeds up utf-16le decoding about 3x Speeds up utf-16be decoding about 2x Adds fatal utf-16le support to without-intl TextDecoder Fixes utf-16le replacement for without-intl TextDecoder, previously it was silently returning wrong results Adds utf-16be support (both fatal and replacement) to without-intl TextDecoder Unifies the logic, using a single codepath everywhere for Unicode Benchmarks https://ci.nodejs.org/view/Node.js benchmark/job/benchmark-node-micro-benchmarks/1804/
Open Graph Description: Tracking: #61041 Better reviewed with whitespace hidden. Builds on top of #61549 Like that PR, this is based on the logic in https://github.com/ExodusOSS/bytes Previously, ICU and string_decoder we...
X Description: Tracking: #61041 Better reviewed with whitespace hidden. Builds on top of #61549 Like that PR, this is based on the logic in https://github.com/ExodusOSS/bytes Previously, ICU and string_decoder we...
Opengraph URL: https://github.com/nodejs/node/pull/61559
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7070e8e0-4877-5076-7cac-edc48f275fba |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9B1A:36F6BD:4256B:5F981:6A4D0298 |
| html-safe-nonce | 080d6fa562a0000c2505d22f04b2d956889a263542f8ec197ad68658b9441467 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjFBOjM2RjZCRDo0MjU2Qjo1Rjk4MTo2QTREMDI5OCIsInZpc2l0b3JfaWQiOiIyNTIyMjA4MTk5MDU1ODM1ODAwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 74f20c0dd6fe79d702d395620715717b6343ee2866d786783da1eaf060711540 |
| hovercard-subject-tag | pull_request:3217383427 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/61559/files |
| twitter:image | https://avatars.githubusercontent.com/u/291301?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/291301?s=400&v=4 |
| og:image:alt | Tracking: #61041 Better reviewed with whitespace hidden. Builds on top of #61549 Like that PR, this is based on the logic in https://github.com/ExodusOSS/bytes Previously, ICU and string_decoder we... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 31e4db13a9e20081f2fac78f441659a6576e582bbb15e153f9c7fb6473aa29f5 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fb70bd3c4b2bec429781b65419e912c66e2d5581 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width