René's URL Explorer Experiment

Title: src: initial support for ESM in embedder API by joyeecheung · Pull Request #61548 · nodejs/node · GitHub

Open Graph Title: src: initial support for ESM in embedder API by joyeecheung · Pull Request #61548 · nodejs/node

X Title: src: initial support for ESM in embedder API by joyeecheung · Pull Request #61548 · nodejs/node

Description: This patch extends LoadEnvironment to support loading ES modules, and adds the following new types: enum class ModuleFormat : uint8_t { kCommonJS, kModule, }; // Data for specifying an entry point script for LoadEnvironment(). // This class uses an opaque layout to allow future additions without // breaking ABI. Use the setter methods to configure the entry point. class ModuleData { void set_source(std::string_view source); void set_format(ModuleFormat format); void set_resource_name(std::string_view name); std::string_view source() const; ModuleFormat format() const; std::string_view resource_name() const; }; class StartExecutionCallbackInfoWithModule { void set_env(Environment* env); void set_process_object(v8::Local process_object); void set_native_require(v8::Local native_require); void set_run_module(v8::Local run_module); void set_data(void* data); Environment* env(); v8::Local process(); v8::Local native_require(); v8::Local run_module(); void* data(); }; And two new LoadEnvironment() overloads: // Run entry point with ModuleData configuration MaybeLocal LoadEnvironment( Environment* env, const ModuleData* entry_point, EmbedderPreloadCallback preload = nullptr); // Callback-based with new StartExecutionCallbackInfoWithModule MaybeLocal LoadEnvironment( Environment* env, StartExecutionCallbackWithModule cb, EmbedderPreloadCallback preload = nullptr, void* callback_data = nullptr); Notes about the run_module function: The run_cjs function is renamed to run_module and now accepts three arguments: (source, format, resourceName) where format corresponds to ModuleFormat values. This keeps the old StartExecutionCallback backward-compatible, and reuses this new function for StartExecutionCallbackWithModule. ESM entry points return the module namespace object, CJS entry points continue to return the wrapper's return value. The following are left as TODO for follow-up PRs. Support for import() and import.meta Support for SEA: I have a branch here to support ESM in SEA via the new API. Support for snapshot: this requires integration of ModuleWrap objects Support for code cache: needs more plumbing for v8::Module cache Refs: #53565

Open Graph Description: This patch extends LoadEnvironment to support loading ES modules, and adds the following new types: enum class ModuleFormat : uint8_t { kCommonJS, kModule, }; // Data for specifying an entry p...

X Description: This patch extends LoadEnvironment to support loading ES modules, and adds the following new types: enum class ModuleFormat : uint8_t { kCommonJS, kModule, }; // Data for specifying an entry p...

Opengraph URL: https://github.com/nodejs/node/pull/61548

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width