Title: lib: unify ICU and no-ICU TextDecoder by ChALkeR · Pull Request #61409 · nodejs/node · GitHub
Open Graph Title: lib: unify ICU and no-ICU TextDecoder by ChALkeR · Pull Request #61409 · nodejs/node
X Title: lib: unify ICU and no-ICU TextDecoder by ChALkeR · Pull Request #61409 · nodejs/node
Description: Better reviewed with whitespace ignored Fix #61411 Add support for fatal UTF-8 decoder in no-ICU version unless streaming is used add utf-8 fast path to no-ICU version reduce duplication of TextDecoder source normalize how this[kHandle] was not set in no-ICU version The refactor changes the encoding reported in the no-ICU version when encoding is recognized but unsupported: now the actual resolved encoding name is reported as unsupported when previously the original input string was reported. I don't think this is major, and reporting the actual encoding name is better in that case. This will allow further fixes and common fast path for UTF-16 / fixed impl for UTF-16 as string_decoder doesn't implement UTF-16 per spec. UTF-16 is still broken in no-ICU version here, this PR does not address that. Tracking: #61041
Open Graph Description: Better reviewed with whitespace ignored Fix #61411 Add support for fatal UTF-8 decoder in no-ICU version unless streaming is used add utf-8 fast path to no-ICU version reduce duplication of TextDe...
X Description: Better reviewed with whitespace ignored Fix #61411 Add support for fatal UTF-8 decoder in no-ICU version unless streaming is used add utf-8 fast path to no-ICU version reduce duplication of TextDe...
Opengraph URL: https://github.com/nodejs/node/pull/61409
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3a53796c-0ea5-463a-ebb9-680249e09dde |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E31A:306DA5:61A698:83FB97:6A4C7CDA |
| html-safe-nonce | 2daf7592c5e04a0341612ca265543436f63eb3f7f1e6b486b480a3563dbbc459 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzFBOjMwNkRBNTo2MUE2OTg6ODNGQjk3OjZBNEM3Q0RBIiwidmlzaXRvcl9pZCI6IjEzODExNzE1NDc1NjE4MTkzNTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3ff2f679f35a3ee8032fa63f45ba9339404e62e6a6ea92d4884a479120d7f9c1 |
| hovercard-subject-tag | pull_request:3184097389 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/61409/files |
| twitter:image | https://avatars.githubusercontent.com/u/291301?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/291301?s=400&v=4 |
| og:image:alt | Better reviewed with whitespace ignored Fix #61411 Add support for fatal UTF-8 decoder in no-ICU version unless streaming is used add utf-8 fast path to no-ICU version reduce duplication of TextDe... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cd470457e909b9d062f8002cf438ba870e6acff6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width