Title: test: split test-esm-loader-hooks by joyeecheung · Pull Request #61374 · nodejs/node · GitHub
Open Graph Title: test: split test-esm-loader-hooks by joyeecheung · Pull Request #61374 · nodejs/node
X Title: test: split test-esm-loader-hooks by joyeecheung · Pull Request #61374 · nodejs/node
Description: Previously whenever one of the test case fails in the CI, it barely logged anything useful in the CI and it was difficult to nail down the specific failing case with a local reproduction, especially when the test fixutre is inline JavaScript. This patch: Puts all the inline JavaScript in on-disk fixtures so that they can be re-run easily. Split the tests into individual files so that it's easier to nail down the failure Use spawnSyncAndAssert which logs useful information when the child process does not behave as expected. Rename the tests as module-hooks/test-async-loader-hooks-* because they belong to the module hooks test suite and are not esm-specific. Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-01-13.md cc @RafaelGSS @marco-ippolito
Open Graph Description: Previously whenever one of the test case fails in the CI, it barely logged anything useful in the CI and it was difficult to nail down the specific failing case with a local reproduction, especiall...
X Description: Previously whenever one of the test case fails in the CI, it barely logged anything useful in the CI and it was difficult to nail down the specific failing case with a local reproduction, especiall...
Opengraph URL: https://github.com/nodejs/node/pull/61374
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8c54f65e-b09f-9a22-779c-cc5847c50dbe |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 98CA:327B79:23C2547:327E012:6A4CE477 |
| html-safe-nonce | 29ea6dfb67106ed62b5f49f2e01c5fcdbfd1744a9c2d4acb88f114a3412c42b3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OENBOjMyN0I3OToyM0MyNTQ3OjMyN0UwMTI6NkE0Q0U0NzciLCJ2aXNpdG9yX2lkIjoiMjA4MzAzNTE1Mjk1MTA3NTk1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 01672f54b3aeb4a74d84a3050a5db71b34d2dd1ee957a14c5a6a010183b2057a |
| hovercard-subject-tag | pull_request:3170266950 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/61374/files |
| twitter:image | https://avatars.githubusercontent.com/u/4299420?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4299420?s=400&v=4 |
| og:image:alt | Previously whenever one of the test case fails in the CI, it barely logged anything useful in the CI and it was difficult to nail down the specific failing case with a local reproduction, especiall... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 299b43bca6e02ad35197ffeba30d2466846d5fb02ab96fbced5b5e6cec589fb8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c5a57f04eeb310f57c73fd6d751d957e2ca27ed2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width